From: "Cédric Le Goater" <clg@redhat.com>
To: qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: "Jamin Lin" <jamin_lin@aspeedtech.com>,
"Cédric Le Goater" <clg@redhat.com>
Subject: [PULL 4/6] aspeed/soc: Fix possible divide by zero
Date: Tue, 2 Jul 2024 10:00:40 +0200 [thread overview]
Message-ID: <20240702080042.464220-5-clg@redhat.com> (raw)
In-Reply-To: <20240702080042.464220-1-clg@redhat.com>
From: Jamin Lin <jamin_lin@aspeedtech.com>
Coverity reports a possible DIVIDE_BY_ZERO issue regarding the
"ram_size" object property. This can not happen because RAM has
predefined valid sizes per SoC. Nevertheless, add a test to
close the issue.
Fixes: Coverity CID 1547113
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
[ clg: Rewrote commit log ]
Signed-off-by: Cédric Le Goater <clg@redhat.com>
---
hw/arm/aspeed_ast27x0.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c
index b6876b4862ff..18e6a8b10cae 100644
--- a/hw/arm/aspeed_ast27x0.c
+++ b/hw/arm/aspeed_ast27x0.c
@@ -211,6 +211,8 @@ static void aspeed_ram_capacity_write(void *opaque, hwaddr addr, uint64_t data,
ram_size = object_property_get_uint(OBJECT(&s->sdmc), "ram-size",
&error_abort);
+ assert(ram_size > 0);
+
/*
* Emulate ddr capacity hardware behavior.
* If writes the data to the address which is beyond the ram size,
--
2.45.2
next prev parent reply other threads:[~2024-07-02 8:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 8:00 [PULL 0/6] aspeed queue Cédric Le Goater
2024-07-02 8:00 ` [PULL 1/6] hw/gpio/aspeed: Add reg_table_count to AspeedGPIOClass Cédric Le Goater
2024-07-02 8:00 ` [PULL 2/6] aspeed: Deprecate the tacoma-bmc machine Cédric Le Goater
2024-07-02 8:00 ` [PULL 3/6] aspeed/sdmc: Check RAM size value at realize time Cédric Le Goater
2024-07-02 8:00 ` Cédric Le Goater [this message]
2024-07-02 8:00 ` [PULL 5/6] aspeed/sdmc: Remove extra R_MAIN_STATUS case Cédric Le Goater
2024-07-02 8:00 ` [PULL 6/6] hw/net:ftgmac100: fix coding style Cédric Le Goater
2024-07-02 22:47 ` [PULL 0/6] aspeed queue Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240702080042.464220-5-clg@redhat.com \
--to=clg@redhat.com \
--cc=jamin_lin@aspeedtech.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).