From: "Michael S. Tsirkin" <mst@redhat.com>
To: Mikhail Krasheninnikov <krashmisha@gmail.com>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
qemu-devel@nongnu.org,
"Matwey Kornilov" <matwey.kornilov@gmail.com>,
qemu-block@nongnu.org, "Kevin Wolf" <kwolf@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: Re: [PATCH v3] virtio: Implement Virtio Backend for SD/MMC in QEMU
Date: Thu, 4 Jul 2024 03:38:22 -0400 [thread overview]
Message-ID: <20240704033637-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <e0e1e2bd-a230-a460-79b2-dd9318e7c92e@gmail.com>
On Thu, Jul 04, 2024 at 10:25:53AM +0300, Mikhail Krasheninnikov wrote:
>
> On Wed, 3 Jul 2024, Michael S. Tsirkin wrote:
>
> > On Wed, Jul 03, 2024 at 10:55:17PM +0300, Mikhail Krasheninnikov wrote:
> > >
> > > Hello, Alex!
> > >
> > > No, there's no patch to the VirtIO specification yet. This is
> > > proof-of-concept solution since I'm not sure that I did everything
> > > correct with the design (and as folks' reviews show, for a good reason).
> > > As soon as most obvious issues would be out of the way, I think I'll
> > > submit a patch.
> >
> >
> > Mikhail, if you want people to review your patches but not merge
> > them yet, pls use an RFC tag in the subject to avoid confusion.
> >
> > Thanks,
> >
> > --
> > MST
> >
> >
>
> Hello, Michael!
>
> I was planning to submit three patches: to the kernel, emulator and Virtio
> specification around the same time - as soon as the obvious bugs are
> fixed, I'll submit a patch to the specification. I thought it wasn't
> necessary to use the RFC tag in that case, but if you think it is,
> I'll include it with the next version of the patch.
RFC means "this is proof of concept". On the one hand some people
won't bother reviewing then. On the other your patch will be
judged less harshly. If your code still has debugging printks,
it's clearly an RFC at best.
--
MST
next prev parent reply other threads:[~2024-07-04 7:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 14:59 [PATCH v3] virtio: Implement Virtio Backend for SD/MMC in QEMU Mikhail Krasheninnikov
2024-07-03 16:07 ` Alex Bennée
2024-07-03 19:55 ` Mikhail Krasheninnikov
2024-07-03 20:05 ` Michael S. Tsirkin
2024-07-04 7:25 ` Mikhail Krasheninnikov
2024-07-04 7:38 ` Michael S. Tsirkin [this message]
2024-07-04 8:23 ` Ми
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240704033637-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=krashmisha@gmail.com \
--cc=kwolf@redhat.com \
--cc=matwey.kornilov@gmail.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).