From: junjiehua <halouworls@gmail.com>
To: qemu-devel@nongnu.org
Cc: Akihiko Odaki <akihiko.odaki@daynix.com>,
Viktor Prutyanov <viktor.prutyanov@phystech.edu>,
junjiehua <junjiehua@tencent.com>
Subject: [PATCH] contrib/elf2dmp: a workaround for the buggy msvcrt.dll!fwrite
Date: Mon, 8 Jul 2024 19:25:20 +0800 [thread overview]
Message-ID: <20240708112520.106127-1-junjiehua@tencent.com> (raw)
when building elf2dump with x86_64-w64-mingw32-gcc, fwrite is imported from
msvcrt.dll. However, the implementation of msvcrt.dll!fwrite is buggy:
it enters an infinite loop when the size of a single write exceeds 4GB.
This patch addresses the issue by splitting large physical memory
blocks into smaller chunks.
Signed-off-by: junjiehua <junjiehua@tencent.com>
---
contrib/elf2dmp/main.c | 19 +++++++++++++++----
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/contrib/elf2dmp/main.c b/contrib/elf2dmp/main.c
index d046a72ae6..1994553d95 100644
--- a/contrib/elf2dmp/main.c
+++ b/contrib/elf2dmp/main.c
@@ -23,6 +23,8 @@
#define INITIAL_MXCSR 0x1f80
#define MAX_NUMBER_OF_RUNS 42
+#define MAX_CHUNK_SIZE (128 * 1024 * 1024)
+
typedef struct idt_desc {
uint16_t offset1; /* offset bits 0..15 */
uint16_t selector;
@@ -434,13 +436,22 @@ static bool write_dump(struct pa_space *ps,
for (i = 0; i < ps->block_nr; i++) {
struct pa_block *b = &ps->block[i];
+ size_t offset = 0;
+ size_t chunk_size;
printf("Writing block #%zu/%zu of %"PRIu64" bytes to file...\n", i,
ps->block_nr, b->size);
- if (fwrite(b->addr, b->size, 1, dmp_file) != 1) {
- eprintf("Failed to write block\n");
- fclose(dmp_file);
- return false;
+
+ while (offset < b->size) {
+ chunk_size = (b->size - offset > MAX_CHUNK_SIZE)
+ ? MAX_CHUNK_SIZE
+ : (b->size - offset);
+ if (fwrite(b->addr + offset, chunk_size, 1, dmp_file) != 1) {
+ eprintf("Failed to write block\n");
+ fclose(dmp_file);
+ return false;
+ }
+ offset += chunk_size;
}
}
--
2.45.2
next reply other threads:[~2024-07-08 13:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 11:25 junjiehua [this message]
2024-07-09 14:39 ` [PATCH] contrib/elf2dmp: a workaround for the buggy msvcrt.dll!fwrite Peter Maydell
2024-07-10 8:02 ` hellord
2024-07-10 16:25 ` Peter Maydell
2024-07-11 16:24 ` junjiehua
2024-07-11 7:53 ` Akihiko Odaki
2024-07-11 16:20 ` junjiehua
2024-07-11 16:31 ` Daniel P. Berrangé
2024-07-11 16:49 ` junjiehua
2024-07-11 17:05 ` Daniel P. Berrangé
2024-07-13 12:56 ` Akihiko Odaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240708112520.106127-1-junjiehua@tencent.com \
--to=halouworls@gmail.com \
--cc=akihiko.odaki@daynix.com \
--cc=junjiehua@tencent.com \
--cc=qemu-devel@nongnu.org \
--cc=viktor.prutyanov@phystech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).