qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
	"Andrew Jeffery" <andrew@codeconstruct.com.au>,
	qemu-block@nongnu.org, "Cédric Le Goater" <clg@kaod.org>,
	"Bin Meng" <bmeng.cn@gmail.com>, "Joel Stanley" <joel@jms.id.au>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Jamin Lin" <jamin_lin@aspeedtech.com>,
	"Steven Lee" <steven_lee@aspeedtech.com>,
	"Troy Lee" <leetroy@gmail.com>
Subject: [PATCH v47 07/19] hw/sd/sdcard: Fix SET_BLOCK_COUNT command argument on eMMC (CMD23)
Date: Tue,  9 Jul 2024 17:25:44 +0200	[thread overview]
Message-ID: <20240709152556.52896-8-philmd@linaro.org> (raw)
In-Reply-To: <20240709152556.52896-1-philmd@linaro.org>

From: Cédric Le Goater <clg@kaod.org>

The number of blocks is defined in the lower bits [15:0].

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20240628070216.92609-88-philmd@linaro.org>
---
 hw/sd/sd.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index 83d45c897f..216d4dfa89 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -1533,6 +1533,9 @@ static sd_rsp_type_t sd_cmd_SET_BLOCK_COUNT(SDState *sd, SDRequest req)
     }
 
     sd->multi_blk_cnt = req.arg;
+    if (sd_is_emmc(sd)) {
+        sd->multi_blk_cnt &= 0xffff;
+    }
     trace_sdcard_set_block_count(sd->multi_blk_cnt);
 
     return sd_r1;
-- 
2.41.0



  parent reply	other threads:[~2024-07-09 15:27 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-09 15:25 [PATCH v47 00/19] hw/sd/sdcard: Add eMMC support Philippe Mathieu-Daudé
2024-07-09 15:25 ` [PATCH v47 01/19] hw/sd/sdcard: Basis for " Philippe Mathieu-Daudé
2024-07-09 15:25 ` [PATCH v47 02/19] hw/sd/sdcard: Register generic command handlers Philippe Mathieu-Daudé
2024-07-09 15:25 ` [PATCH v47 03/19] hw/sd/sdcard: Register unimplemented " Philippe Mathieu-Daudé
2024-07-09 15:25 ` [PATCH v47 04/19] hw/sd/sdcard: Implement emmc_set_cid() Philippe Mathieu-Daudé
2024-07-09 15:25 ` [PATCH v47 05/19] hw/sd/sdcard: Implement emmc_set_csd() Philippe Mathieu-Daudé
2024-07-09 15:25 ` [PATCH v47 06/19] hw/sd/sdcard: Add emmc_cmd_SET_RELATIVE_ADDR handler (CMD3) Philippe Mathieu-Daudé
2024-07-09 15:25 ` Philippe Mathieu-Daudé [this message]
2024-07-09 15:25 ` [PATCH v47 08/19] hw/sd/sdcard: Add mmc_cmd_PROGRAM_CID handler (CMD26) Philippe Mathieu-Daudé
2024-07-09 15:25 ` [PATCH v47 09/19] hw/sd/sdcard: Implement eMMC sleep state (CMD5) Philippe Mathieu-Daudé
2024-07-09 15:25 ` [PATCH v47 10/19] hw/sd/sdcard: Add emmc_cmd_SEND_EXT_CSD handler (CMD8) Philippe Mathieu-Daudé
2024-07-09 15:25 ` [PATCH v47 11/19] hw/sd/sdcard: Add eMMC 'boot-size' property Philippe Mathieu-Daudé
2024-07-09 15:45   ` Cédric Le Goater
2024-07-09 15:25 ` [PATCH v47 12/19] hw/sd/sdcard: Simplify EXT_CSD values for spec v4.3 Philippe Mathieu-Daudé
2024-07-09 15:43   ` Cédric Le Goater
2024-07-09 21:33     ` Philippe Mathieu-Daudé
2024-07-09 15:25 ` [PATCH v47 13/19] hw/sd/sdcard: Migrate ExtCSD 'modes' register Philippe Mathieu-Daudé
2024-07-09 15:25 ` [PATCH v47 14/19] hw/sd/sdcard: Add mmc SWITCH function support (CMD6) Philippe Mathieu-Daudé
2024-07-09 15:25 ` [PATCH v47 15/19] hw/sd/sdcard: Implement eMMC 'boot-mode' Philippe Mathieu-Daudé
2024-07-09 15:25 ` [Aspeed PATCH v47 16/19] hw/sd/sdcard: Support boot area in emmc image Philippe Mathieu-Daudé
2024-07-09 15:51   ` Cédric Le Goater
2024-07-09 15:25 ` [Aspeed PATCH v47 17/19] hw/sd/sdcard: Subtract bootarea size from blk Philippe Mathieu-Daudé
2024-07-09 15:25 ` [Aspeed PATCH v47 18/19] hw/sd/sdcard: Add boot config support Philippe Mathieu-Daudé
2024-07-09 15:52   ` Cédric Le Goater
2024-07-09 16:17     ` Philippe Mathieu-Daudé
2024-07-09 15:25 ` [PATCH v47 19/19] hw/sd/sdcard: Enable TYPE_EMMC card model Philippe Mathieu-Daudé
2024-07-09 15:42   ` Cédric Le Goater
2024-07-09 15:58 ` [PATCH v47 00/19] hw/sd/sdcard: Add eMMC support Cédric Le Goater
2024-07-09 21:39   ` Philippe Mathieu-Daudé
2024-07-10  4:58     ` Cédric Le Goater
2024-07-10  8:09       ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240709152556.52896-8-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=andrew@codeconstruct.com.au \
    --cc=bmeng.cn@gmail.com \
    --cc=clg@kaod.org \
    --cc=jamin_lin@aspeedtech.com \
    --cc=joel@jms.id.au \
    --cc=leetroy@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=steven_lee@aspeedtech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).