From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Bin Meng" <bmeng.cn@gmail.com>,
"Steven Lee" <steven_lee@aspeedtech.com>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Francisco Iglesias" <francisco.iglesias@amd.com>,
"Sai Pavan Boddu" <sai.pavan.boddu@amd.com>,
"Luc Michel" <luc.michel@amd.com>,
qemu-arm@nongnu.org, qemu-block@nongnu.org,
"Troy Lee" <leetroy@gmail.com>,
"Jamin Lin" <jamin_lin@aspeedtech.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Joel Stanley" <joel@jms.id.au>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Edgar E . Iglesias" <edgar.iglesias@amd.com>,
"Cédric Le Goater" <clg@kaod.org>
Subject: [PATCH v48 09/12] hw/sd/sdcard: Add eMMC 'boot-size' property
Date: Wed, 10 Jul 2024 16:14:05 +0200 [thread overview]
Message-ID: <20240710141408.69275-10-philmd@linaro.org> (raw)
In-Reply-To: <20240710141408.69275-1-philmd@linaro.org>
Avoid hardcoding 1MiB boot size in EXT_CSD_BOOT_MULT,
expose it as QOM property.
By default, do not use any size. The board is responsible
to set the boot size property.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/sd/sd.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index e6f1cc2066..57a9eb91d0 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -135,6 +135,7 @@ struct SDState {
/* Static properties */
uint8_t spec_version;
+ uint64_t boot_part_size;
BlockBackend *blk;
const SDProto *proto;
@@ -492,7 +493,8 @@ static void mmc_set_ext_csd(SDState *sd, uint64_t size)
/* Properties segment (RO) */
sd->ext_csd[EXT_CSD_S_CMD_SET] = 0b1; /* supported command sets */
sd->ext_csd[EXT_CSD_BOOT_INFO] = 0x0; /* Boot information */
- sd->ext_csd[EXT_CSD_BOOT_MULT] = 0x8; /* Boot partition size. 128KB unit */
+ /* Boot partition size. 128KB unit */
+ sd->ext_csd[EXT_CSD_BOOT_MULT] = sd->boot_part_size / (128 * KiB);
sd->ext_csd[EXT_CSD_ACC_SIZE] = 0x1; /* Access size */
sd->ext_csd[EXT_CSD_HC_ERASE_GRP_SIZE] = 0x01; /* HC Erase unit size */
sd->ext_csd[EXT_CSD_ERASE_TIMEOUT_MULT] = 0x01; /* HC erase timeout */
@@ -2704,6 +2706,7 @@ static Property sd_properties[] = {
};
static Property emmc_properties[] = {
+ DEFINE_PROP_UINT64("boot-size", SDState, boot_part_size, 0),
DEFINE_PROP_END_OF_LIST()
};
--
2.41.0
next prev parent reply other threads:[~2024-07-10 14:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 14:13 [PATCH v48 00/12] hw/sd/sdcard: Add eMMC support Philippe Mathieu-Daudé
2024-07-10 14:13 ` [PATCH v48 01/12] hw/sd/sdcard: Basis for " Philippe Mathieu-Daudé
2024-07-10 14:13 ` [PATCH v48 02/12] hw/sd/sdcard: Register generic command handlers Philippe Mathieu-Daudé
2024-07-10 14:13 ` [PATCH v48 03/12] hw/sd/sdcard: Register unimplemented " Philippe Mathieu-Daudé
2024-07-10 14:14 ` [PATCH v48 04/12] hw/sd/sdcard: Add emmc_cmd_SET_RELATIVE_ADDR handler (CMD3) Philippe Mathieu-Daudé
2024-07-10 14:14 ` [PATCH v48 05/12] hw/sd/sdcard: Fix SET_BLOCK_COUNT command argument on eMMC (CMD23) Philippe Mathieu-Daudé
2024-07-10 14:14 ` [PATCH v48 06/12] hw/sd/sdcard: Add mmc_cmd_PROGRAM_CID handler (CMD26) Philippe Mathieu-Daudé
2024-07-10 14:14 ` [PATCH v48 07/12] hw/sd/sdcard: Implement eMMC sleep state (CMD5) Philippe Mathieu-Daudé
2024-07-10 14:14 ` [PATCH v48 08/12] hw/sd/sdcard: Add emmc_cmd_SEND_EXT_CSD handler (CMD8) Philippe Mathieu-Daudé
2024-07-10 14:14 ` Philippe Mathieu-Daudé [this message]
2024-07-10 14:14 ` [PATCH v48 10/12] hw/sd/sdcard: Implement eMMC 'boot-mode' Philippe Mathieu-Daudé
2024-07-10 14:14 ` [PATCH v48 11/12] hw/sd/sdcard: Add mmc SWITCH function support (CMD6) Philippe Mathieu-Daudé
2024-07-10 14:14 ` [PATCH v48 12/12] hw/sd/sdcard: Support boot area in emmc image Philippe Mathieu-Daudé
2024-07-10 15:35 ` [PATCH v48 00/12] hw/sd/sdcard: Add eMMC support Cédric Le Goater
2024-07-10 16:57 ` Philippe Mathieu-Daudé
2024-07-10 19:20 ` Cédric Le Goater
2024-07-11 11:03 ` Cédric Le Goater
2024-07-11 14:08 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240710141408.69275-10-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=andrew@codeconstruct.com.au \
--cc=bmeng.cn@gmail.com \
--cc=clg@kaod.org \
--cc=edgar.iglesias@amd.com \
--cc=francisco.iglesias@amd.com \
--cc=jamin_lin@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=leetroy@gmail.com \
--cc=luc.michel@amd.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sai.pavan.boddu@amd.com \
--cc=steven_lee@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).