From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CBE7C3DA49 for ; Thu, 11 Jul 2024 12:13:11 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sRsfO-0004YB-Ey; Thu, 11 Jul 2024 08:12:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRsfM-0004Q0-JS for qemu-devel@nongnu.org; Thu, 11 Jul 2024 08:12:52 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRsfI-0005Fm-4p for qemu-devel@nongnu.org; Thu, 11 Jul 2024 08:12:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720699965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vv5NTnJoowLB9Po9W64tEIIxmWAKOLu+98q44yY8x+0=; b=H09TItFEhzlB1h1V1PqLy0ddUrF9x08u5EtlnnxN3XpSx/UQ3MRUuQBJhv4w8u8TVA4by+ hnDGSrAnVn8qwvUAcKSMSsE+PnZtv0uf96x4Lb9Z7oq5RfKJI2//E1xbRImgh4vNHUv6nJ mvayOZ/UdFUM8gQLxsxLHOL+F+IWX3I= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-537-rplgKdqmNeW4qPKdrg2NSA-1; Thu, 11 Jul 2024 08:12:43 -0400 X-MC-Unique: rplgKdqmNeW4qPKdrg2NSA-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4265464ddc9so4504975e9.1 for ; Thu, 11 Jul 2024 05:12:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720699962; x=1721304762; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vv5NTnJoowLB9Po9W64tEIIxmWAKOLu+98q44yY8x+0=; b=dQKFxwm/m3Mu2Q/IZfTyhbtnEkMMtLKczKD9160QWN7VfmBt2WGAroZ2tCLakQbHF6 kNoLVKugCBozXGRWUQietq/bC8rfk2MDcwAhzMeMEgWdRflngu2smvGoKCXhqe4jGi4M +GeB5CEwACwEer2IYAkTlCGE13cNR63F4ZfL4FKhEuvn7eQ7It7cs63Z43BDqLV2/zc/ faaDW4WhvRNzHX+7k9RpyZU7Hd3QnV+j89Q4aJpQ2YDTgYujVBraVbVrGCDVki6bSrqL bP8KvN63es/LG4vNjaurRZnfTJT6XorhaXCueQydUYetk3kVBuZ0XB+Khjq7vr8aCNt1 FyWQ== X-Forwarded-Encrypted: i=1; AJvYcCUz9cKsJ/du6FkLfAPyNrmAOCmrdFxof6Rn7Pjo4QQ4YdxQ9c6WNc0jWeQzsNNPE/MXC4rodGzHq/Vidvbztx/Hm8Uw0l4= X-Gm-Message-State: AOJu0YyK+lmjV4GqCiraRvQcz+SimuylshP1E/jZLMfHa0K+swNiwptq fmCqWubO1B0MyiJqRAU7mPa31imv6DsI6Vy7LI65osfjj/WapkSMkYaQAdsXYlYbablWAC1XehX DoAN2oVsbRLc+f69P1HsJTM3MKcrvJCTWC3CXwhtqjBL9ETCDSvPH X-Received: by 2002:a05:600c:2297:b0:426:706c:a55a with SMTP id 5b1f17b1804b1-427981b2265mr22358235e9.2.1720699962449; Thu, 11 Jul 2024 05:12:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGwEPCamNUNUNQAYP2H6/A2vbZTgDFgbv7Bkc+kZHDW20GC/zNT9z44VnRcdcxSL7xbZoVnUw== X-Received: by 2002:a05:600c:2297:b0:426:706c:a55a with SMTP id 5b1f17b1804b1-427981b2265mr22358065e9.2.1720699962034; Thu, 11 Jul 2024 05:12:42 -0700 (PDT) Received: from imammedo.users.ipa.redhat.com (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4266f7362d9sm113730155e9.30.2024.07.11.05.12.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jul 2024 05:12:41 -0700 (PDT) Date: Thu, 11 Jul 2024 14:12:40 +0200 From: Igor Mammedov To: Jonathan Cameron Cc: , Markus Armbruster , , , , , Richard Henderson , , Dave Jiang , Huang Ying , Paolo Bonzini , , , Michael Roth , Ani Sinha Subject: Re: [PATCH v4 06/13] acpi/pci: Move Generic Initiator object handling into acpi/pci.* Message-ID: <20240711141240.0ec77fd2@imammedo.users.ipa.redhat.com> In-Reply-To: <20240702131428.664859-7-Jonathan.Cameron@huawei.com> References: <20240702131428.664859-1-Jonathan.Cameron@huawei.com> <20240702131428.664859-7-Jonathan.Cameron@huawei.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.142, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, 2 Jul 2024 14:14:11 +0100 Jonathan Cameron wrote: > Whilst ACPI SRAT Generic Initiator Afinity Structures are able to refer to > both PCI and ACPI Device Handles, the QEMU implementation only implements > the PCI Device Handle case. For now move the code into the existing > hw/acpi/pci.c file and header. If support for ACPI Device Handles is > added in the future, perhaps this will be moved again. > > Also push the struct AcpiGenericInitiator down into the c file as not > used outside pci.c. > > Suggested-by: Igor Mammedov > Signed-off-by: Jonathan Cameron > > --- > v4: Update busnr naming > --- > include/hw/acpi/acpi_generic_initiator.h | 24 ----- > include/hw/acpi/pci.h | 6 ++ > hw/acpi/acpi_generic_initiator.c | 117 ---------------------- > hw/acpi/pci.c | 118 +++++++++++++++++++++++ > hw/arm/virt-acpi-build.c | 1 - > hw/i386/acpi-build.c | 1 - > hw/acpi/meson.build | 1 - > 7 files changed, 124 insertions(+), 144 deletions(-) > > diff --git a/include/hw/acpi/acpi_generic_initiator.h b/include/hw/acpi/acpi_generic_initiator.h > deleted file mode 100644 > index 7b98676713..0000000000 > --- a/include/hw/acpi/acpi_generic_initiator.h > +++ /dev/null > @@ -1,24 +0,0 @@ > -// SPDX-License-Identifier: GPL-2.0-only > -/* > - * Copyright (c) 2024, NVIDIA CORPORATION & AFFILIATES. All rights reserved > - */ > - > -#ifndef ACPI_GENERIC_INITIATOR_H > -#define ACPI_GENERIC_INITIATOR_H > - > -#include "qom/object_interfaces.h" > - > -#define TYPE_ACPI_GENERIC_INITIATOR "acpi-generic-initiator" > - > -typedef struct AcpiGenericInitiator { > - /* private */ > - Object parent; > - > - /* public */ > - char *pci_dev; > - uint16_t node; > -} AcpiGenericInitiator; > - > -void build_srat_generic_pci_initiator(GArray *table_data); > - > -#endif > diff --git a/include/hw/acpi/pci.h b/include/hw/acpi/pci.h > index 467a99461c..9adf1887da 100644 > --- a/include/hw/acpi/pci.h > +++ b/include/hw/acpi/pci.h > @@ -28,6 +28,7 @@ > > #include "hw/acpi/bios-linker-loader.h" > #include "hw/acpi/acpi_aml_interface.h" > +#include "qom/object_interfaces.h" ... > + > +#define TYPE_ACPI_GENERIC_INITIATOR "acpi-generic-initiator" why object_interfaces.h and type name is in header, at this point I don't see it used elsewhere beside the single C file. If they must be exported, than mention in commit message where it will be used. > + > +void build_srat_generic_pci_initiator(GArray *table_data); > + > #endif > diff --git a/hw/acpi/acpi_generic_initiator.c b/hw/acpi/acpi_generic_initiator.c > deleted file mode 100644 > index f2711c91ef..0000000000 > --- a/hw/acpi/acpi_generic_initiator.c > +++ /dev/null > @@ -1,117 +0,0 @@ > -// SPDX-License-Identifier: GPL-2.0-only > -/* > - * Copyright (c) 2024, NVIDIA CORPORATION & AFFILIATES. All rights reserved > - */ > - > -#include "qemu/osdep.h" > -#include "hw/acpi/acpi_generic_initiator.h" > -#include "hw/acpi/aml-build.h" > -#include "hw/boards.h" > -#include "hw/pci/pci_device.h" > -#include "qemu/error-report.h" > -#include "qapi/error.h" > - > -typedef struct AcpiGenericInitiatorClass { > - ObjectClass parent_class; > -} AcpiGenericInitiatorClass; > - > -OBJECT_DEFINE_TYPE_WITH_INTERFACES(AcpiGenericInitiator, acpi_generic_initiator, > - ACPI_GENERIC_INITIATOR, OBJECT, > - { TYPE_USER_CREATABLE }, > - { NULL }) > - > -OBJECT_DECLARE_SIMPLE_TYPE(AcpiGenericInitiator, ACPI_GENERIC_INITIATOR) > - > -static void acpi_generic_initiator_init(Object *obj) > -{ > - AcpiGenericInitiator *gi = ACPI_GENERIC_INITIATOR(obj); > - > - gi->node = MAX_NODES; > - gi->pci_dev = NULL; > -} > - > -static void acpi_generic_initiator_finalize(Object *obj) > -{ > - AcpiGenericInitiator *gi = ACPI_GENERIC_INITIATOR(obj); > - > - g_free(gi->pci_dev); > -} > - > -static void acpi_generic_initiator_set_pci_device(Object *obj, const char *val, > - Error **errp) > -{ > - AcpiGenericInitiator *gi = ACPI_GENERIC_INITIATOR(obj); > - > - gi->pci_dev = g_strdup(val); > -} > - > -static void acpi_generic_initiator_set_node(Object *obj, Visitor *v, > - const char *name, void *opaque, > - Error **errp) > -{ > - AcpiGenericInitiator *gi = ACPI_GENERIC_INITIATOR(obj); > - MachineState *ms = MACHINE(qdev_get_machine()); > - uint32_t value; > - > - if (!visit_type_uint32(v, name, &value, errp)) { > - return; > - } > - > - if (value >= MAX_NODES) { > - error_printf("%s: Invalid NUMA node specified\n", > - TYPE_ACPI_GENERIC_INITIATOR); > - exit(1); > - } > - > - gi->node = value; > - ms->numa_state->nodes[gi->node].has_gi = true; > -} > - > -static void acpi_generic_initiator_class_init(ObjectClass *oc, void *data) > -{ > - object_class_property_add_str(oc, "pci-dev", NULL, > - acpi_generic_initiator_set_pci_device); > - object_class_property_add(oc, "node", "int", NULL, > - acpi_generic_initiator_set_node, NULL, NULL); > -} > - > -static int build_acpi_generic_initiator(Object *obj, void *opaque) > -{ > - MachineState *ms = MACHINE(qdev_get_machine()); > - AcpiGenericInitiator *gi; > - GArray *table_data = opaque; > - uint8_t bus, devfn; > - Object *o; > - > - if (!object_dynamic_cast(obj, TYPE_ACPI_GENERIC_INITIATOR)) { > - return 0; > - } > - > - gi = ACPI_GENERIC_INITIATOR(obj); > - if (gi->node >= ms->numa_state->num_nodes) { > - error_printf("%s: Specified node %d is invalid.\n", > - TYPE_ACPI_GENERIC_INITIATOR, gi->node); > - exit(1); > - } > - > - o = object_resolve_path_type(gi->pci_dev, TYPE_PCI_DEVICE, NULL); > - if (!o) { > - error_printf("%s: Specified device must be a PCI device.\n", > - TYPE_ACPI_GENERIC_INITIATOR); > - exit(1); > - } > - > - bus = object_property_get_uint(o, "busnr", &error_fatal); > - devfn = object_property_get_uint(o, "addr", &error_fatal); > - > - build_srat_pci_generic_initiator(table_data, gi->node, 0, bus, devfn); > - > - return 0; > -} > - > -void build_srat_generic_pci_initiator(GArray *table_data) > -{ > - object_child_foreach_recursive(object_get_root(), > - build_acpi_generic_initiator, > - table_data); > -} > diff --git a/hw/acpi/pci.c b/hw/acpi/pci.c > index 20b70dcd81..174b490e5f 100644 > --- a/hw/acpi/pci.c > +++ b/hw/acpi/pci.c > @@ -24,8 +24,12 @@ > */ > > #include "qemu/osdep.h" > +#include "qemu/error-report.h" > +#include "qapi/error.h" is this necessary? it seems to be compiling just fine without it. > +#include "hw/boards.h" > #include "hw/acpi/aml-build.h" > #include "hw/acpi/pci.h" > +#include "hw/pci/pci_device.h" > #include "hw/pci/pcie_host.h" > > /* > @@ -59,3 +63,117 @@ void build_mcfg(GArray *table_data, BIOSLinker *linker, AcpiMcfgInfo *info, > > acpi_table_end(linker, &table); > } > + > +typedef struct AcpiGenericInitiator { > + /* private */ > + Object parent; > + > + /* public */ > + char *pci_dev; > + uint16_t node; > +} AcpiGenericInitiator; > + > +typedef struct AcpiGenericInitiatorClass { > + ObjectClass parent_class; > +} AcpiGenericInitiatorClass; > + > +OBJECT_DEFINE_TYPE_WITH_INTERFACES(AcpiGenericInitiator, acpi_generic_initiator, > + ACPI_GENERIC_INITIATOR, OBJECT, > + { TYPE_USER_CREATABLE }, > + { NULL }) > + > +OBJECT_DECLARE_SIMPLE_TYPE(AcpiGenericInitiator, ACPI_GENERIC_INITIATOR) > + > +static void acpi_generic_initiator_init(Object *obj) > +{ > + AcpiGenericInitiator *gi = ACPI_GENERIC_INITIATOR(obj); > + > + gi->node = MAX_NODES; > + gi->pci_dev = NULL; > +} > + > +static void acpi_generic_initiator_finalize(Object *obj) > +{ > + AcpiGenericInitiator *gi = ACPI_GENERIC_INITIATOR(obj); > + > + g_free(gi->pci_dev); > +} > + > +static void acpi_generic_initiator_set_pci_device(Object *obj, const char *val, > + Error **errp) > +{ > + AcpiGenericInitiator *gi = ACPI_GENERIC_INITIATOR(obj); > + > + gi->pci_dev = g_strdup(val); > +} > + > +static void acpi_generic_initiator_set_node(Object *obj, Visitor *v, > + const char *name, void *opaque, > + Error **errp) > +{ > + AcpiGenericInitiator *gi = ACPI_GENERIC_INITIATOR(obj); > + MachineState *ms = MACHINE(qdev_get_machine()); > + uint32_t value; > + > + if (!visit_type_uint32(v, name, &value, errp)) { > + return; > + } > + > + if (value >= MAX_NODES) { > + error_printf("%s: Invalid NUMA node specified\n", > + TYPE_ACPI_GENERIC_INITIATOR); > + exit(1); > + } > + > + gi->node = value; > + ms->numa_state->nodes[gi->node].has_gi = true; > +} > + > +static void acpi_generic_initiator_class_init(ObjectClass *oc, void *data) > +{ > + object_class_property_add_str(oc, "pci-dev", NULL, > + acpi_generic_initiator_set_pci_device); > + object_class_property_add(oc, "node", "int", NULL, > + acpi_generic_initiator_set_node, NULL, NULL); > +} > + > +static int build_acpi_generic_initiator(Object *obj, void *opaque) > +{ > + MachineState *ms = MACHINE(qdev_get_machine()); > + AcpiGenericInitiator *gi; > + GArray *table_data = opaque; > + uint8_t bus, devfn; > + Object *o; > + > + if (!object_dynamic_cast(obj, TYPE_ACPI_GENERIC_INITIATOR)) { > + return 0; > + } > + > + gi = ACPI_GENERIC_INITIATOR(obj); > + if (gi->node >= ms->numa_state->num_nodes) { > + error_printf("%s: Specified node %d is invalid.\n", > + TYPE_ACPI_GENERIC_INITIATOR, gi->node); > + exit(1); > + } > + > + o = object_resolve_path_type(gi->pci_dev, TYPE_PCI_DEVICE, NULL); > + if (!o) { > + error_printf("%s: Specified device must be a PCI device.\n", > + TYPE_ACPI_GENERIC_INITIATOR); > + exit(1); > + } > + > + bus = object_property_get_uint(o, "busnr", &error_fatal); > + devfn = object_property_get_uint(o, "addr", &error_fatal); > + > + build_srat_pci_generic_initiator(table_data, gi->node, 0, bus, devfn); > + > + return 0; > +} > + > +void build_srat_generic_pci_initiator(GArray *table_data) > +{ > + object_child_foreach_recursive(object_get_root(), > + build_acpi_generic_initiator, > + table_data); > +} > diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c > index b2366f24f9..138514b26a 100644 > --- a/hw/arm/virt-acpi-build.c > +++ b/hw/arm/virt-acpi-build.c > @@ -57,7 +57,6 @@ > #include "migration/vmstate.h" > #include "hw/acpi/ghes.h" > #include "hw/acpi/viot.h" > -#include "hw/acpi/acpi_generic_initiator.h" > #include "hw/virtio/virtio-acpi.h" > #include "target/arm/multiprocessing.h" > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index f4e366f64f..ee92783836 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -68,7 +68,6 @@ > #include "hw/acpi/utils.h" > #include "hw/acpi/pci.h" > #include "hw/acpi/cxl.h" > -#include "hw/acpi/acpi_generic_initiator.h" > > #include "qom/qom-qobject.h" > #include "hw/i386/amd_iommu.h" > diff --git a/hw/acpi/meson.build b/hw/acpi/meson.build > index fa5c07db90..5441c9b1e4 100644 > --- a/hw/acpi/meson.build > +++ b/hw/acpi/meson.build > @@ -1,6 +1,5 @@ > acpi_ss = ss.source_set() > acpi_ss.add(files( > - 'acpi_generic_initiator.c', > 'acpi_interface.c', > 'aml-build.c', > 'bios-linker-loader.c',