From: Jonathan Cameron via <qemu-devel@nongnu.org>
To: Igor Mammedov <imammedo@redhat.com>
Cc: <mst@redhat.com>, Markus Armbruster <armbru@redhat.com>,
<qemu-devel@nongnu.org>, <ankita@nvidia.com>,
<marcel.apfelbaum@gmail.com>, <philmd@linaro.org>,
Richard Henderson <richard.henderson@linaro.org>,
<linuxarm@huawei.com>, Dave Jiang <dave.jiang@intel.com>,
Huang Ying <ying.huang@intel.com>,
Paolo Bonzini <pbonzini@redhat.com>, <eduardo@habkost.net>,
<linux-cxl@vger.kernel.org>, Michael Roth <michael.roth@amd.com>,
Ani Sinha <anisinha@redhat.com>
Subject: Re: [PATCH v4 06/13] acpi/pci: Move Generic Initiator object handling into acpi/pci.*
Date: Thu, 11 Jul 2024 16:38:51 +0100 [thread overview]
Message-ID: <20240711163851.00002f93@Huawei.com> (raw)
In-Reply-To: <20240711141240.0ec77fd2@imammedo.users.ipa.redhat.com>
> > diff --git a/hw/acpi/pci.c b/hw/acpi/pci.c
> > index 20b70dcd81..174b490e5f 100644
> > --- a/hw/acpi/pci.c
> > +++ b/hw/acpi/pci.c
> > @@ -24,8 +24,12 @@
> > */
> >
> > #include "qemu/osdep.h"
> > +#include "qemu/error-report.h"
>
> > +#include "qapi/error.h"
> is this necessary?
> it seems to be compiling just fine without it.
The error_fatal extern is in there.
I guess there is a non obvious path via which that's getting included
anyway. is in there and it's not obvious how it is included I'd rather
keep it as an explicit include to reduce fragility if the chain of
includes involved gets changed.
>
> > +#include "hw/boards.h"
> > #include "hw/acpi/aml-build.h"
> > #include "hw/acpi/pci.h"
> > +#include "hw/pci/pci_device.h"
> > #include "hw/pci/pcie_host.h"
> >
next prev parent reply other threads:[~2024-07-11 15:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 13:14 [PATCH v4 00/13] acpi: NUMA nodes for CXL HB as GP + complex NUMA test Jonathan Cameron via
2024-07-02 13:14 ` [PATCH v4 01/13] hw/acpi: Fix ordering of BDF in Generic Initiator PCI Device Handle Jonathan Cameron via
2024-07-02 13:14 ` [PATCH v4 02/13] hw/acpi/GI: Fix trivial parameter alignment issue Jonathan Cameron via
2024-07-02 13:14 ` [PATCH v4 03/13] hw/acpi: Move AML building code for Generic Initiators to aml_build.c Jonathan Cameron via
2024-07-02 13:14 ` [PATCH v4 04/13] hw/acpi: Rename build_all_acpi_generic_initiators() to build_acpi_generic_initiator() Jonathan Cameron via
2024-07-02 13:14 ` [PATCH v4 05/13] hw/pci: Add a busnr property to pci_props and use for acpi/gi Jonathan Cameron via
2024-07-11 11:53 ` Igor Mammedov
2024-07-11 12:23 ` Igor Mammedov
2024-07-11 15:43 ` Jonathan Cameron via
2024-07-02 13:14 ` [PATCH v4 06/13] acpi/pci: Move Generic Initiator object handling into acpi/pci.* Jonathan Cameron via
2024-07-11 12:12 ` Igor Mammedov
2024-07-11 15:38 ` Jonathan Cameron via [this message]
2024-07-11 15:40 ` Michael S. Tsirkin
2024-07-02 13:14 ` [PATCH v4 07/13] hw/pci-bridge: Add acpi_uid property to TYPE_PXB_BUS Jonathan Cameron via
2024-07-11 12:27 ` Igor Mammedov
2024-07-02 13:14 ` [PATCH v4 08/13] hw/i386/acpi: Use TYPE_PXB_BUS property acpi_uid for DSDT Jonathan Cameron via
2024-07-11 12:34 ` Igor Mammedov
2024-07-02 13:14 ` [PATCH v4 09/13] hw/pci-host/gpex-acpi: Use acpi_uid property Jonathan Cameron via
2024-07-02 13:14 ` [PATCH v4 10/13] hw/acpi: Generic Port Affinity Structure support Jonathan Cameron via
2024-07-02 13:14 ` [PATCH v4 11/13] bios-tables-test: Allow for new acpihmat-generic-x test data Jonathan Cameron via
2024-07-02 13:14 ` [PATCH v4 12/13] bios-tables-test: Add complex SRAT / HMAT test for GI GP Jonathan Cameron via
2024-07-02 13:14 ` [PATCH v4 13/13] bios-tables-test: Add data for complex numa test (GI, GP etc) Jonathan Cameron via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240711163851.00002f93@Huawei.com \
--to=qemu-devel@nongnu.org \
--cc=Jonathan.Cameron@Huawei.com \
--cc=anisinha@redhat.com \
--cc=ankita@nvidia.com \
--cc=armbru@redhat.com \
--cc=dave.jiang@intel.com \
--cc=eduardo@habkost.net \
--cc=imammedo@redhat.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=michael.roth@amd.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=richard.henderson@linaro.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).