qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Joao Martins <joao.m.martins@oracle.com>
To: qemu-devel@nongnu.org
Cc: Yi Liu <yi.l.liu@intel.com>, Eric Auger <eric.auger@redhat.com>,
	Zhenzhong Duan <zhenzhong.duan@intel.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Cedric Le Goater <clg@redhat.com>,
	Jason Gunthorpe <jgg@nvidia.com>,
	Avihai Horon <avihaih@nvidia.com>,
	Joao Martins <joao.m.martins@oracle.com>
Subject: [PATCH v4 11/12] vfio/migration: Don't block migration device dirty tracking is unsupported
Date: Fri, 12 Jul 2024 12:47:03 +0100	[thread overview]
Message-ID: <20240712114704.8708-12-joao.m.martins@oracle.com> (raw)
In-Reply-To: <20240712114704.8708-1-joao.m.martins@oracle.com>

By default VFIO migration is set to auto, which will support live
migration if the migration capability is set *and* also dirty page
tracking is supported.

For testing purposes one can force enable without dirty page tracking
via enable-migration=on, but that option is generally left for testing
purposes.

So starting with IOMMU dirty tracking it can use to acomodate the lack of
VF dirty page tracking allowing us to minimize the VF requirements for
migration and thus enabling migration by default for those too.

Signed-off-by: Joao Martins <joao.m.martins@oracle.com>
---
 hw/vfio/migration.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c
index 34d4be2ce1b1..ce3d1b6e9a25 100644
--- a/hw/vfio/migration.c
+++ b/hw/vfio/migration.c
@@ -1036,7 +1036,8 @@ bool vfio_migration_realize(VFIODevice *vbasedev, Error **errp)
         return !vfio_block_migration(vbasedev, err, errp);
     }
 
-    if (!vbasedev->dirty_pages_supported) {
+    if (!vbasedev->dirty_pages_supported &&
+        !vbasedev->bcontainer->dirty_pages_supported) {
         if (vbasedev->enable_migration == ON_OFF_AUTO_AUTO) {
             error_setg(&err,
                        "%s: VFIO device doesn't support device dirty tracking",
-- 
2.17.2



  parent reply	other threads:[~2024-07-12 11:50 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-12 11:46 [PATCH v4 00/12] hw/iommufd: IOMMUFD Dirty Tracking Joao Martins
2024-07-12 11:46 ` [PATCH v4 01/12] vfio/pci: Extract mdev check into an helper Joao Martins
2024-07-16  9:21   ` Cédric Le Goater
2024-07-16  9:33     ` Joao Martins
2024-07-12 11:46 ` [PATCH v4 02/12] vfio/iommufd: Don't initialize nor set a HOST_IOMMU_DEVICE with mdev Joao Martins
2024-07-16  9:21   ` Cédric Le Goater
2024-07-16 13:26   ` Eric Auger
2024-07-17  1:34   ` Duan, Zhenzhong
2024-07-12 11:46 ` [PATCH v4 03/12] backends/iommufd: Extend iommufd_backend_get_device_info() to fetch HW capabilities Joao Martins
2024-07-16  9:22   ` Cédric Le Goater
2024-07-16 13:34   ` Eric Auger
2024-07-12 11:46 ` [PATCH v4 04/12] vfio/iommufd: Return errno in iommufd_cdev_attach_ioas_hwpt() Joao Martins
2024-07-16  9:27   ` Cédric Le Goater
2024-07-16 13:36   ` Eric Auger
2024-07-17  1:37   ` Duan, Zhenzhong
2024-07-12 11:46 ` [PATCH v4 05/12] vfio/iommufd: Introduce auto domain creation Joao Martins
2024-07-16  9:39   ` Cédric Le Goater
2024-07-16  9:47     ` Joao Martins
2024-07-16 12:54   ` Cédric Le Goater
2024-07-16 16:04   ` Eric Auger
2024-07-16 16:44     ` Joao Martins
2024-07-16 16:46       ` Joao Martins
2024-07-17  2:52         ` Duan, Zhenzhong
2024-07-17  9:09           ` Joao Martins
2024-07-17  9:28             ` Cédric Le Goater
2024-07-17  9:31               ` Joao Martins
2024-07-18 13:47                 ` Joao Martins
2024-07-19  6:06                   ` Cédric Le Goater
2024-07-17  9:48             ` Duan, Zhenzhong
2024-07-17  9:53               ` Joao Martins
2024-07-16 17:32       ` Eric Auger
2024-07-17  2:18   ` Duan, Zhenzhong
2024-07-17  9:04     ` Joao Martins
2024-07-17 10:05       ` Duan, Zhenzhong
2024-07-17 11:04         ` Joao Martins
2024-07-18  7:44           ` Duan, Zhenzhong
2024-07-18  9:16             ` Joao Martins
2024-07-19  2:36               ` Duan, Zhenzhong
2024-07-12 11:46 ` [PATCH v4 06/12] vfio/{iommufd,container}: Remove caps::aw_bits Joao Martins
2024-07-16 10:19   ` Cédric Le Goater
2024-07-16 17:40   ` Eric Auger
2024-07-16 18:22     ` Joao Martins
2024-07-17 11:48       ` Eric Auger
2024-07-12 11:46 ` [PATCH v4 07/12] vfio/{iommufd, container}: Initialize HostIOMMUDeviceCaps during attach_device() Joao Martins via
2024-07-16 10:20   ` [PATCH v4 07/12] vfio/{iommufd,container}: " Cédric Le Goater
2024-07-16 10:40     ` Joao Martins
2024-07-17  2:05   ` Duan, Zhenzhong
2024-07-17  8:55     ` Joao Martins
2024-07-17 12:19   ` Eric Auger
2024-07-17 12:33     ` Joao Martins
2024-07-17 13:41       ` Eric Auger
2024-07-17 15:34         ` Joao Martins
2024-07-12 11:47 ` [PATCH v4 08/12] vfio/iommufd: Probe and request hwpt dirty tracking capability Joao Martins
2024-07-16 12:21   ` Cédric Le Goater
2024-07-17 12:27   ` Eric Auger
2024-07-17 12:38     ` Joao Martins
2024-07-17 13:43       ` Eric Auger
2024-07-12 11:47 ` [PATCH v4 09/12] vfio/iommufd: Implement VFIOIOMMUClass::set_dirty_tracking support Joao Martins
2024-07-16 12:24   ` Cédric Le Goater
2024-07-17  2:24   ` Duan, Zhenzhong
2024-07-17  9:14     ` Joao Martins
2024-07-17 12:36   ` Eric Auger
2024-07-17 12:41     ` Joao Martins
2024-07-17 13:34       ` Eric Auger
2024-07-17 15:18         ` Joao Martins
2024-07-12 11:47 ` [PATCH v4 10/12] vfio/iommufd: Implement VFIOIOMMUClass::query_dirty_bitmap support Joao Martins
2024-07-16 12:31   ` Cédric Le Goater
2024-07-16 12:53   ` Cédric Le Goater
2024-07-17 12:50   ` Eric Auger
2024-07-12 11:47 ` Joao Martins [this message]
2024-07-17  2:38   ` [PATCH v4 11/12] vfio/migration: Don't block migration device dirty tracking is unsupported Duan, Zhenzhong
2024-07-17  9:20     ` Joao Martins
2024-07-17 15:35       ` Joao Martins
2024-07-17 16:02         ` Joao Martins
2024-07-17 16:54           ` Joao Martins
2024-07-18  7:20       ` Duan, Zhenzhong
2024-07-18  9:05         ` Joao Martins
2024-07-17 12:57   ` Eric Auger
2024-07-12 11:47 ` [PATCH v4 12/12] vfio/common: Allow disabling device dirty page tracking Joao Martins
2024-07-16  8:20 ` [PATCH v4 00/12] hw/iommufd: IOMMUFD Dirty Tracking Duan, Zhenzhong
2024-07-16  9:22   ` Joao Martins
2024-07-18  7:50     ` Duan, Zhenzhong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240712114704.8708-12-joao.m.martins@oracle.com \
    --to=joao.m.martins@oracle.com \
    --cc=alex.williamson@redhat.com \
    --cc=avihaih@nvidia.com \
    --cc=clg@redhat.com \
    --cc=eric.auger@redhat.com \
    --cc=jgg@nvidia.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yi.l.liu@intel.com \
    --cc=zhenzhong.duan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).