From: Vincent Vanlaer <libvirt-e6954efa@volkihar.be>
To: qemu-devel@nongnu.org
Cc: John Snow <jsnow@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>,
Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Hanna Reitz <hreitz@redhat.com>,
Vincent Vanlaer <libvirt-e6954efa@volkihar.be>
Subject: [PATCH v2 1/4] block: get type of block allocation in commit_run
Date: Sat, 13 Jul 2024 23:56:41 +0200 [thread overview]
Message-ID: <20240713215644.742244-2-libvirt-e6954efa@volkihar.be> (raw)
In-Reply-To: <20240713215644.742244-1-libvirt-e6954efa@volkihar.be>
bdrv_co_common_block_status_above not only returns whether the block is
allocated, but also if it contains zeroes.
Signed-off-by: Vincent Vanlaer <libvirt-e6954efa@volkihar.be>
---
block/commit.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/block/commit.c b/block/commit.c
index 7c3fdcb0ca..8dee25b313 100644
--- a/block/commit.c
+++ b/block/commit.c
@@ -15,6 +15,8 @@
#include "qemu/osdep.h"
#include "qemu/cutils.h"
#include "trace.h"
+#include "block/block-common.h"
+#include "block/coroutines.h"
#include "block/block_int.h"
#include "block/blockjob_int.h"
#include "qapi/error.h"
@@ -167,9 +169,13 @@ static int coroutine_fn commit_run(Job *job, Error **errp)
break;
}
/* Copy if allocated above the base */
- ret = blk_co_is_allocated_above(s->top, s->base_overlay, true,
- offset, COMMIT_BUFFER_SIZE, &n);
- copy = (ret > 0);
+ WITH_GRAPH_RDLOCK_GUARD() {
+ ret = bdrv_co_common_block_status_above(blk_bs(s->top),
+ s->base_overlay, true, true, offset, COMMIT_BUFFER_SIZE,
+ &n, NULL, NULL, NULL);
+ }
+
+ copy = (ret >= 0 && ret & BDRV_BLOCK_ALLOCATED);
trace_commit_one_iteration(s, offset, n, ret);
if (copy) {
assert(n < SIZE_MAX);
--
2.44.1
next prev parent reply other threads:[~2024-07-13 22:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-13 21:56 [PATCH v2 0/4] block: allow commit to unmap zero blocks Vincent Vanlaer
2024-07-13 21:56 ` Vincent Vanlaer [this message]
2024-08-02 10:09 ` [PATCH v2 1/4] block: get type of block allocation in commit_run Vladimir Sementsov-Ogievskiy
2024-07-13 21:56 ` [PATCH v2 2/4] block: refactor commit_run for multiple write types Vincent Vanlaer
2024-08-02 10:22 ` Vladimir Sementsov-Ogievskiy
2024-07-13 21:56 ` [PATCH v2 3/4] block: allow commit to unmap zero blocks Vincent Vanlaer
2024-08-02 10:58 ` Vladimir Sementsov-Ogievskiy
2024-09-01 10:25 ` Vincent Vanlaer
2024-07-13 21:56 ` [PATCH v2 4/4] block: add test non-active commit with zeroed data Vincent Vanlaer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240713215644.742244-2-libvirt-e6954efa@volkihar.be \
--to=libvirt-e6954efa@volkihar.be \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).