* [PATCH] meson: Use -fno-sanitize=function when available
@ 2024-07-14 10:42 Akihiko Odaki
2024-07-15 7:10 ` Alex Bennée
2024-07-16 8:46 ` Paolo Bonzini
0 siblings, 2 replies; 4+ messages in thread
From: Akihiko Odaki @ 2024-07-14 10:42 UTC (permalink / raw)
To: Alex Bennée, Philippe Mathieu-Daudé, Thomas Huth,
Wainer dos Santos Moschetta, Beraldo Leal, Paolo Bonzini,
Marc-André Lureau, Daniel P. Berrangé
Cc: qemu-devel, Akihiko Odaki
Commit 23ef50ae2d0c (".gitlab-ci.d/buildtest.yml: Use
-fno-sanitize=function in the clang-system job") adds
-fno-sanitize=function for the CI but doesn't add the flag in the
other context. Move it to meson.build.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
meson.build | 1 +
.gitlab-ci.d/buildtest.yml | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 6a93da48e1b5..80447833f07a 100644
--- a/meson.build
+++ b/meson.build
@@ -609,6 +609,7 @@ if host_os != 'openbsd' and \
endif
qemu_common_flags += cc.get_supported_arguments(hardening_flags)
+qemu_common_flags += cc.get_supported_arguments('-fno-sanitize=function')
add_global_arguments(qemu_common_flags, native: false, language: all_languages)
add_global_link_arguments(qemu_ldflags, native: false, language: all_languages)
diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
index e3a0758bd9e5..a57822d65182 100644
--- a/.gitlab-ci.d/buildtest.yml
+++ b/.gitlab-ci.d/buildtest.yml
@@ -430,7 +430,6 @@ clang-system:
IMAGE: fedora
CONFIGURE_ARGS: --cc=clang --cxx=clang++
--extra-cflags=-fsanitize=undefined --extra-cflags=-fno-sanitize-recover=undefined
- --extra-cflags=-fno-sanitize=function
TARGETS: alpha-softmmu arm-softmmu m68k-softmmu mips64-softmmu s390x-softmmu
MAKE_CHECK_ARGS: check-qtest check-tcg
---
base-commit: f2cb4026fccfe073f84a4b440e41d3ed0c3134f6
change-id: 20240714-function-7d32c723abbc
Best regards,
--
Akihiko Odaki <akihiko.odaki@daynix.com>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] meson: Use -fno-sanitize=function when available
2024-07-14 10:42 [PATCH] meson: Use -fno-sanitize=function when available Akihiko Odaki
@ 2024-07-15 7:10 ` Alex Bennée
2024-07-15 7:19 ` Akihiko Odaki
2024-07-16 8:46 ` Paolo Bonzini
1 sibling, 1 reply; 4+ messages in thread
From: Alex Bennée @ 2024-07-15 7:10 UTC (permalink / raw)
To: Akihiko Odaki
Cc: Philippe Mathieu-Daudé, Thomas Huth,
Wainer dos Santos Moschetta, Beraldo Leal, Paolo Bonzini,
Marc-André Lureau, Daniel P. Berrangé, qemu-devel
Akihiko Odaki <akihiko.odaki@daynix.com> writes:
> Commit 23ef50ae2d0c (".gitlab-ci.d/buildtest.yml: Use
> -fno-sanitize=function in the clang-system job") adds
> -fno-sanitize=function for the CI but doesn't add the flag in the
> other context. Move it to meson.build.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> meson.build | 1 +
> .gitlab-ci.d/buildtest.yml | 1 -
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 6a93da48e1b5..80447833f07a 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -609,6 +609,7 @@ if host_os != 'openbsd' and \
> endif
>
> qemu_common_flags += cc.get_supported_arguments(hardening_flags)
> +qemu_common_flags +=
> cc.get_supported_arguments('-fno-sanitize=function')
What about checking the other hardening flags?
>
> add_global_arguments(qemu_common_flags, native: false, language: all_languages)
> add_global_link_arguments(qemu_ldflags, native: false, language: all_languages)
> diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
> index e3a0758bd9e5..a57822d65182 100644
> --- a/.gitlab-ci.d/buildtest.yml
> +++ b/.gitlab-ci.d/buildtest.yml
> @@ -430,7 +430,6 @@ clang-system:
> IMAGE: fedora
> CONFIGURE_ARGS: --cc=clang --cxx=clang++
> --extra-cflags=-fsanitize=undefined --extra-cflags=-fno-sanitize-recover=undefined
> - --extra-cflags=-fno-sanitize=function
> TARGETS: alpha-softmmu arm-softmmu m68k-softmmu mips64-softmmu s390x-softmmu
> MAKE_CHECK_ARGS: check-qtest check-tcg
>
>
> ---
> base-commit: f2cb4026fccfe073f84a4b440e41d3ed0c3134f6
> change-id: 20240714-function-7d32c723abbc
>
> Best regards,
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] meson: Use -fno-sanitize=function when available
2024-07-15 7:10 ` Alex Bennée
@ 2024-07-15 7:19 ` Akihiko Odaki
0 siblings, 0 replies; 4+ messages in thread
From: Akihiko Odaki @ 2024-07-15 7:19 UTC (permalink / raw)
To: Alex Bennée
Cc: Philippe Mathieu-Daudé, Thomas Huth,
Wainer dos Santos Moschetta, Beraldo Leal, Paolo Bonzini,
Marc-André Lureau, Daniel P. Berrangé, qemu-devel
On 2024/07/15 16:10, Alex Bennée wrote:
> Akihiko Odaki <akihiko.odaki@daynix.com> writes:
>
>> Commit 23ef50ae2d0c (".gitlab-ci.d/buildtest.yml: Use
>> -fno-sanitize=function in the clang-system job") adds
>> -fno-sanitize=function for the CI but doesn't add the flag in the
>> other context. Move it to meson.build.
>>
>> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
>> ---
>> meson.build | 1 +
>> .gitlab-ci.d/buildtest.yml | 1 -
>> 2 files changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meson.build b/meson.build
>> index 6a93da48e1b5..80447833f07a 100644
>> --- a/meson.build
>> +++ b/meson.build
>> @@ -609,6 +609,7 @@ if host_os != 'openbsd' and \
>> endif
>>
>> qemu_common_flags += cc.get_supported_arguments(hardening_flags)
>> +qemu_common_flags +=
>> cc.get_supported_arguments('-fno-sanitize=function')
>
> What about checking the other hardening flags?
-fsanitize=function is the only hardening flag that we decided to
disable for now. Context:
https://lore.kernel.org/qemu-devel/618857e6-dd88-4834-af1b-561228fd7dc1@redhat.com/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] meson: Use -fno-sanitize=function when available
2024-07-14 10:42 [PATCH] meson: Use -fno-sanitize=function when available Akihiko Odaki
2024-07-15 7:10 ` Alex Bennée
@ 2024-07-16 8:46 ` Paolo Bonzini
1 sibling, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2024-07-16 8:46 UTC (permalink / raw)
To: Akihiko Odaki
Cc: Alex Bennée, Philippe Mathieu-Daudé, Thomas Huth,
Wainer dos Santos Moschetta, Beraldo Leal, Marc-André Lureau,
Daniel P . Berrangé, qemu-devel
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-07-16 8:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-14 10:42 [PATCH] meson: Use -fno-sanitize=function when available Akihiko Odaki
2024-07-15 7:10 ` Alex Bennée
2024-07-15 7:19 ` Akihiko Odaki
2024-07-16 8:46 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).