From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0A86C3DA49 for ; Sun, 14 Jul 2024 07:48:01 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sStwa-0008H0-FT; Sun, 14 Jul 2024 03:46:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sStwZ-0008Fz-Dp for qemu-devel@nongnu.org; Sun, 14 Jul 2024 03:46:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sStwX-0005me-C5 for qemu-devel@nongnu.org; Sun, 14 Jul 2024 03:46:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720943207; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/WHD3oTajkUFk9t4DLQ9JCWDvoQfv3i/z/ncx3CwhAk=; b=Wes56DD58v/Z5nBmE0rtAxvwMONyQc6EYdbMPFk28pcvPUQZRZN8xCX1Hidc2XVeFHwabp Zj5adImwj1Uzvtk/XQ9KARw1HnumvW3p4rUHJGfPnS1h+/R2n64NVzypoabkszYoRAc0vy aGJE5UJWp7y91k2NmS1k2JrfW82EggY= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-495-aWS-jzthOYuD8pTFhkswyg-1; Sun, 14 Jul 2024 03:46:45 -0400 X-MC-Unique: aWS-jzthOYuD8pTFhkswyg-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2ee8ceb0852so31026841fa.0 for ; Sun, 14 Jul 2024 00:46:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720943204; x=1721548004; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/WHD3oTajkUFk9t4DLQ9JCWDvoQfv3i/z/ncx3CwhAk=; b=ZkwOwaKjCUh97jjbRZizHsQzlp5DY0i44EY/h3BBNzX1LEFghrnllNiXTfI8BlSiYJ YRE7uLxZenH3+4fqMoFIwjUAgCcntAHx336kcCPZF4EhQeCVKIv8ckSq30Nof2D6XbD2 5SiwOAXoKM4BxU4qeYCldqz+i3jUqDuvYEOFfppn2UFPUaRgPVu3x/fFkrtDGxHtdoA8 BkGml1VFSLPiNlwoz9zi23dchvorP+XyBsXbXr20dM3eHoF+sBsXzI0o7Phk2wra1cBf sG7IFmGjL/QxVq4/zmKnCO5AbaXrDo/3X8jlwHKbA+TWUoFyy7TnPCB6Ugc3NdBitm/4 sQfA== X-Forwarded-Encrypted: i=1; AJvYcCWXZz+6XinzWkuwLUZqwTZXIYXR8H29gnMUyHNIO12J/V9AqwdJdXRDzM2iHqk6uBIszbIquQ5Xmrre8D3UJTqKxJs3NOQ= X-Gm-Message-State: AOJu0YyQU5A690EITRieeGT8HFhcCcFfr82GX/iImdT7RhHMTAL0Fndw OyZVcM9FxGnLqIHZnFhkP07UejArHVFsNKAVZ7kR0vA82havK6P1UCbFwyi1qf0KFfT+IrD2NnJ ixC1b6L0UMm5i8mdDALPWbqw53SMZygDASacavbnSmGsrZBdVnrS/ X-Received: by 2002:a05:6512:3ca4:b0:52c:859c:91dd with SMTP id 2adb3069b0e04-52eb998e6aemr12911364e87.5.1720943204239; Sun, 14 Jul 2024 00:46:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEF9Zjyqo7KkW28tMLk2o5m/EjC3XgCNWJhOzoE1SXdZTSA0ib155F8cHkIO3U/hyZIJbPmiQ== X-Received: by 2002:a05:6512:3ca4:b0:52c:859c:91dd with SMTP id 2adb3069b0e04-52eb998e6aemr12911308e87.5.1720943202492; Sun, 14 Jul 2024 00:46:42 -0700 (PDT) Received: from redhat.com ([2a0d:6fc7:240:5146:27c:20a3:47d4:904]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4279f276c52sm78255915e9.22.2024.07.14.00.46.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Jul 2024 00:46:41 -0700 (PDT) Date: Sun, 14 Jul 2024 03:46:36 -0400 From: "Michael S. Tsirkin" To: Igor Mammedov Cc: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Sunil V L , qemu-devel@nongnu.org, qemu-riscv@nongnu.org, Palmer Dabbelt , Alistair Francis , Bin Meng , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Ani Sinha Subject: Re: [PATCH v2 0/9] RISC-V: ACPI: Namespace updates Message-ID: <20240714034105-mutt-send-email-mst@kernel.org> References: <20240708114741.3499585-1-sunilvl@ventanamicro.com> <20240712144319.233c19a7@imammedo.users.ipa.redhat.com> <20240712155010.3756bb82@imammedo.users.ipa.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240712155010.3756bb82@imammedo.users.ipa.redhat.com> Received-SPF: pass client-ip=170.10.129.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.143, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Jul 12, 2024 at 03:50:10PM +0200, Igor Mammedov wrote: > On Fri, 12 Jul 2024 13:51:04 +0100 > Daniel P. Berrangé wrote: > > > On Fri, Jul 12, 2024 at 02:43:19PM +0200, Igor Mammedov wrote: > > > On Mon, 8 Jul 2024 17:17:32 +0530 > > > Sunil V L wrote: > > > > > > > This series adds few updates to RISC-V ACPI namespace for virt platform. > > > > Additionally, it has patches to enable ACPI table testing for RISC-V. > > > > > > > > 1) PCI Link devices need to be created outside the scope of the PCI root > > > > complex to ensure correct probe ordering by the OS. This matches the > > > > example given in ACPI spec as well. > > > > > > > > 2) Add PLIC and APLIC as platform devices as well to ensure probing > > > > order as per BRS spec [1] requirement. > > > > > > > > 3) BRS spec requires RISC-V to use new ACPI ID for the generic UART. So, > > > > update the HID of the UART. > > > > > > > > 4) Enabled ACPI tables tests for RISC-V which were originally part of > > > > [2] but couldn't get merged due to updates required in the expected AML > > > > files. I think combining those patches with this series makes it easier > > > > to merge since expected AML files are updated. > > > > > > > > [1] - https://github.com/riscv-non-isa/riscv-brs > > > > [2] - https://lists.gnu.org/archive/html/qemu-devel/2024-06/msg04734.html > > > > > > btw: CI is not happy about series, see: > > > https://gitlab.com/imammedo/qemu/-/pipelines/1371119552 > > > also 'cross-i686-tci' job routinely timeouts on bios-tables-test > > > but we still keep adding more tests to it. > > > We should either bump timeout to account for slowness or > > > disable bios-tables-test for that job. > > > > Asumming the test is functionally correct, and not hanging, then bumping > > the timeout is the right answer. You can do this in the meson.build > > file > > I think test is fine, since once in a while it passes (I guess it depends on runner host/load) > > Overal job timeout is 1h, but that's not what fails. > What I see is, the test aborts after 10min timeout. > it's likely we hit boot_sector_test()/acpi_find_rsdp_address_uefi() timeout. > That's what we should try to bump. > > PS: > I've just started the job with 5min bump, lets see if it is enough. Because we should wait for 5min CPU time, not wall time. Why don't we do that? Something like getrusage should work I think. > > We should never disable tests only in CI, because non-CI users > > are just as likely to hit timeouts. > > > > > > With regards, > > Daniel