From: Akihiko Odaki <akihiko.odaki@daynix.com>
To: "Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Dmitry Fleytman" <dmitry.fleytman@gmail.com>,
"Phil Dennis-Jordan" <phil@philjordan.eu>
Cc: qemu-devel@nongnu.org, Akihiko Odaki <akihiko.odaki@daynix.com>
Subject: [PATCH v3 0/4] ui/cocoa: Add cursor composition
Date: Mon, 15 Jul 2024 14:25:41 +0900 [thread overview]
Message-ID: <20240715-cursor-v3-0-afa5b9492dbf@daynix.com> (raw)
Add accelerated cursor composition to ui/cocoa. This does not only
improve performance for display devices that exposes the capability to
the guest according to dpy_cursor_define_supported(), but fixes the
cursor display for devices that unconditionally expects the availability
of the capability (e.g., virtio-gpu).
The common pattern to implement accelerated cursor composition is to
replace the cursor and warp it so that the replaced cursor is shown at
the correct position on the guest display for relative pointer devices.
Unfortunately, ui/cocoa cannot do the same because warping the cursor
position interfers with the mouse input so it uses CALayer instead;
although it is not specialized for cursor composition, it still can
compose images with hardware acceleration.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
Changes in v3:
- Incorporated changes from:
"[PATCH v3 1/4] ui/cocoa: Typo fix in based-on patches"
- Link to v2: https://lore.kernel.org/r/20240627-cursor-v2-0-c3cd3ee35616@daynix.com
Changes in v2:
- Incorporated changes from:
https://lore.kernel.org/r/20240625134931.92279-2-phil@philjordan.eu
("[PATCH v2 1/2] ui/cocoa: Minor fixes to CALayer based cursors")
- Added patch "ui/cocoa: Release CGColorSpace"
- Added patch "ui/console: Convert mouse visibility parameter into bool"
- Noted that the problem with warping is relevant only for relative
pointer devices.
- Link to v1: https://lore.kernel.org/r/20240318-cursor-v1-0-0bbe6c382217@daynix.com
---
Akihiko Odaki (4):
ui/cocoa: Release CGColorSpace
ui/console: Convert mouse visibility parameter into bool
ui/cocoa: Add cursor composition
ui/console: Remove dpy_cursor_define_supported()
meson.build | 3 +-
include/ui/console.h | 5 +--
hw/display/ati.c | 2 +-
hw/display/qxl-render.c | 4 --
hw/display/virtio-gpu.c | 3 +-
hw/display/vmware_vga.c | 8 ++--
ui/console.c | 18 ++-------
ui/dbus-listener.c | 2 +-
ui/gtk.c | 2 +-
ui/sdl2.c | 4 +-
ui/spice-display.c | 11 ++---
ui/vnc.c | 2 +-
ui/cocoa.m | 104 +++++++++++++++++++++++++++++++++++++++++++++++-
13 files changed, 126 insertions(+), 42 deletions(-)
---
base-commit: 74abb45dac6979e7ff76172b7f0a24e869405184
change-id: 20240318-cursor-3491b1806582
Best regards,
--
Akihiko Odaki <akihiko.odaki@daynix.com>
next reply other threads:[~2024-07-15 5:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 5:25 Akihiko Odaki [this message]
2024-07-15 5:25 ` [PATCH v3 1/4] ui/cocoa: Release CGColorSpace Akihiko Odaki
2024-07-15 6:57 ` Philippe Mathieu-Daudé
2024-07-15 5:25 ` [PATCH v3 2/4] ui/console: Convert mouse visibility parameter into bool Akihiko Odaki
2024-07-15 6:56 ` Philippe Mathieu-Daudé
2024-07-15 5:25 ` [PATCH v3 3/4] ui/cocoa: Add cursor composition Akihiko Odaki
2024-07-15 5:25 ` [PATCH v3 4/4] ui/console: Remove dpy_cursor_define_supported() Akihiko Odaki
2024-07-16 17:55 ` [PATCH v3 0/4] ui/cocoa: Add cursor composition Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240715-cursor-v3-0-afa5b9492dbf@daynix.com \
--to=akihiko.odaki@daynix.com \
--cc=berrange@redhat.com \
--cc=dmitry.fleytman@gmail.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=phil@philjordan.eu \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).