From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: danikhan632@git.sr.ht, qemu-arm@nongnu.org,
Daniyal Khan <danikhan632@gmail.com>,
qemu-stable@nongnu.org
Subject: [PATCH 1/3] target/arm: Use float_status copy in sme_fmopa_s
Date: Mon, 15 Jul 2024 15:58:18 +1000 [thread overview]
Message-ID: <20240715055820.319035-2-richard.henderson@linaro.org> (raw)
In-Reply-To: <20240715055820.319035-1-richard.henderson@linaro.org>
From: Daniyal Khan <danikhan632@gmail.com>
We made a copy above because the fp exception flags
are not propagated back to the FPST register, but
then failed to use the copy.
Cc: qemu-stable@nongnu.org
Fixes: 558e956c719 ("target/arm: Implement FMOPA, FMOPS (non-widening)")
Signed-off-by: Daniyal Khan <danikhan632@gmail.com>
[rth: Split from a larger patch]
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/tcg/sme_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/arm/tcg/sme_helper.c b/target/arm/tcg/sme_helper.c
index e2e0575039..5a6dd76489 100644
--- a/target/arm/tcg/sme_helper.c
+++ b/target/arm/tcg/sme_helper.c
@@ -916,7 +916,7 @@ void HELPER(sme_fmopa_s)(void *vza, void *vzn, void *vzm, void *vpn,
if (pb & 1) {
uint32_t *a = vza_row + H1_4(col);
uint32_t *m = vzm + H1_4(col);
- *a = float32_muladd(n, *m, *a, 0, vst);
+ *a = float32_muladd(n, *m, *a, 0, &fpst);
}
col += 4;
pb >>= 4;
--
2.43.0
next prev parent reply other threads:[~2024-07-15 5:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 5:58 [PATCH 0/3] target/arm: Fixes for SME FMOPA (#2373) Richard Henderson
2024-07-15 5:58 ` Richard Henderson [this message]
2024-07-15 6:35 ` [PATCH 1/3] target/arm: Use float_status copy in sme_fmopa_s Philippe Mathieu-Daudé
2024-07-15 9:34 ` Alex Bennée
2024-07-15 5:58 ` [PATCH 2/3] target/arm: Use FPST_F16 for SME FMOPA (widening) Richard Henderson
2024-07-15 6:02 ` Richard Henderson
2024-07-15 10:03 ` Alex Bennée
2024-07-15 5:58 ` [PATCH 3/3] tests/tcg/aarch64: Add test cases " Richard Henderson
2024-07-15 10:08 ` Alex Bennée
2024-07-16 11:35 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240715055820.319035-2-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=danikhan632@git.sr.ht \
--cc=danikhan632@gmail.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).