qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Zhao Liu <zhao1.liu@intel.com>
To: Michael Tokarev <mjt@tls.msk.ru>, Laurent Vivier <laurent@vivier.eu>
Cc: "Daniel P . Berrangé" <berrange@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Eric Blake" <eblake@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
	"Zhao Liu" <zhao1.liu@intel.com>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Cédric Le Goater" <clg@redhat.com>
Subject: [PATCH 4/7] hw/vfio/container: Get rid of qemu_open_old()
Date: Mon, 15 Jul 2024 16:21:52 +0800	[thread overview]
Message-ID: <20240715082155.28771-5-zhao1.liu@intel.com> (raw)
In-Reply-To: <20240715082155.28771-1-zhao1.liu@intel.com>

For qemu_open_old(), osdep.h said:

> Don't introduce new usage of this function, prefer the following
> qemu_open/qemu_create that take an "Error **errp".

So replace qemu_open_old() with qemu_open().

Cc: Alex Williamson <alex.williamson@redhat.com>
Cc: "Cédric Le Goater" <clg@redhat.com>
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
 hw/vfio/container.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/hw/vfio/container.c b/hw/vfio/container.c
index 425db1a14c07..38a9df34964a 100644
--- a/hw/vfio/container.c
+++ b/hw/vfio/container.c
@@ -600,9 +600,8 @@ static bool vfio_connect_container(VFIOGroup *group, AddressSpace *as,
         }
     }
 
-    fd = qemu_open_old("/dev/vfio/vfio", O_RDWR);
+    fd = qemu_open("/dev/vfio/vfio", O_RDWR, errp);
     if (fd < 0) {
-        error_setg_errno(errp, errno, "failed to open /dev/vfio/vfio");
         goto put_space_exit;
     }
 
@@ -743,9 +742,8 @@ static VFIOGroup *vfio_get_group(int groupid, AddressSpace *as, Error **errp)
     group = g_malloc0(sizeof(*group));
 
     snprintf(path, sizeof(path), "/dev/vfio/%d", groupid);
-    group->fd = qemu_open_old(path, O_RDWR);
+    group->fd = qemu_open(path, O_RDWR, errp);
     if (group->fd < 0) {
-        error_setg_errno(errp, errno, "failed to open %s", path);
         goto free_group_exit;
     }
 
-- 
2.34.1



  parent reply	other threads:[~2024-07-15  8:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-15  8:21 [PATCH 0/7] trivial: Replace some qemu_open_old() with qemu_open() Zhao Liu
2024-07-15  8:21 ` [PATCH 1/7] hw/i386/sgx: Get rid of qemu_open_old() Zhao Liu
2024-07-15  8:21 ` [PATCH 2/7] hw/usb/host-libusb: " Zhao Liu
2024-07-15  9:44   ` Philippe Mathieu-Daudé
2024-07-15  8:21 ` [PATCH 3/7] hw/usb/u2f-passthru: " Zhao Liu
2024-07-15  9:44   ` Philippe Mathieu-Daudé
2024-07-15  8:21 ` Zhao Liu [this message]
2024-07-15  9:46   ` [PATCH 4/7] hw/vfio/container: " Philippe Mathieu-Daudé
2024-07-16 13:43   ` Cédric Le Goater
2024-07-15  8:21 ` [PATCH 5/7] backends/hostmem-epc: " Zhao Liu
2024-07-15  9:45   ` Philippe Mathieu-Daudé
2024-07-15 14:02   ` Igor Mammedov
2024-07-15  8:21 ` [PATCH 6/7] backends/iommufd: " Zhao Liu
2024-07-15  9:45   ` Philippe Mathieu-Daudé
2024-07-16  8:10   ` Yi Liu
2024-07-15  8:21 ` [PATCH 7/7] backends/rng-random: " Zhao Liu
2024-07-15  9:46   ` Philippe Mathieu-Daudé
2024-07-15 10:10     ` Zhao Liu
2024-07-15 11:07       ` Michael Tokarev
2024-07-15 12:44         ` Zhao Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240715082155.28771-5-zhao1.liu@intel.com \
    --to=zhao1.liu@intel.com \
    --cc=alex.williamson@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=clg@redhat.com \
    --cc=eblake@redhat.com \
    --cc=laurent@vivier.eu \
    --cc=mjt@tls.msk.ru \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).