From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ABCE3C3DA59 for ; Mon, 15 Jul 2024 13:55:53 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sTMAE-0006SD-FB; Mon, 15 Jul 2024 09:54:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sTMAB-0006Pk-H2 for qemu-devel@nongnu.org; Mon, 15 Jul 2024 09:54:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sTMA7-0003PC-Od for qemu-devel@nongnu.org; Mon, 15 Jul 2024 09:54:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721051682; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O+1TcXPMJZRHAMo8zpPLaVS6N5uxXxVW7oE+ZXwvL+Q=; b=OJdps710uQgNUMSNE+sjHOrJm1OIOoL8fNvfRzTYIML4udwhAF/NitsMqZDtngoNUUYR4Q wcYi65ReIcLSfStM5us75PJr487+OL1HwzDAGYOxxPUtO/P5mbzd4l96DKYu6QOCpOatz2 QoiVRPEDs6Z8c5x8UAxaGlLU/S9AUIA= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-30-vrHpnAB0OgiTlvs0ZEVbTA-1; Mon, 15 Jul 2024 09:54:40 -0400 X-MC-Unique: vrHpnAB0OgiTlvs0ZEVbTA-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-367f1dc92e3so2681326f8f.0 for ; Mon, 15 Jul 2024 06:54:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721051679; x=1721656479; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O+1TcXPMJZRHAMo8zpPLaVS6N5uxXxVW7oE+ZXwvL+Q=; b=NIOF9TKsqzEjb9oXmxk7OUYF3/bHed1nORLstfXa/UDFSgkpPf69Nr1ufZfOfIF6yZ IWjM3Z+jb7I12ETT0r9Fd7n5VVxmByDa6lpFf2ImxjJeAn86a+2RthzyTx5GSgEPW5oT SyQHAhWRzHfm5MJ6kS5clkkEJNdXJZxLCecqdCmWkHVTMhaOIScTlcGoK/1YJsixR7Vp auIE/KnKbv29pJI0rFdsMsfzdKwxjxNVX0xCKAwAZuekWRrwbWYOga2PKl2tmaVjqvUv 1p5uJxmhDeeoAG8wVy/V/rOFNCWtUdVvia9PeA+assjCLtycRzqZMZSH5q05cqAJldhD Ua7Q== X-Gm-Message-State: AOJu0YzZTunE8AY1aoD8mVGMvpF2Bj8p7L/J7DC5C+QbZlBxlG6/pyKj SwUkQuzVPYPw0V7COsWdAWzmWmmzTk8ZyldRtLIj9EsN9P4oLjuGIu6IgBA4iwp3LosESMcKdSF 7k6Jx9qU1VCXjLbn+++2rxganlUFFa0HeDcX3g1DunQgdzVOgoQ7+ X-Received: by 2002:adf:f64f:0:b0:367:97fd:1d75 with SMTP id ffacd0b85a97d-367cea7cde6mr11483860f8f.27.1721051679443; Mon, 15 Jul 2024 06:54:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFIn8atEF+7wTYO+5qRulZiVw1FIE0QKmeTxfbdv7RHQrPVNeZ6NqDvmbQY3wcI5zTVZrSRUA== X-Received: by 2002:adf:f64f:0:b0:367:97fd:1d75 with SMTP id ffacd0b85a97d-367cea7cde6mr11483834f8f.27.1721051679017; Mon, 15 Jul 2024 06:54:39 -0700 (PDT) Received: from imammedo.users.ipa.redhat.com (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-427a5e77488sm89467615e9.9.2024.07.15.06.54.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jul 2024 06:54:38 -0700 (PDT) Date: Mon, 15 Jul 2024 15:54:36 +0200 From: Igor Mammedov To: Salil Mehta Cc: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH V15 0/7] Add architecture agnostic code to support vCPU Hotplug Message-ID: <20240715155436.577d34c5@imammedo.users.ipa.redhat.com> In-Reply-To: <20240713182516.1457-1-salil.mehta@huawei.com> References: <20240713182516.1457-1-salil.mehta@huawei.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.133.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Sat, 13 Jul 2024 19:25:09 +0100 Salil Mehta wrote: > [Note: References are present at the last after the revision history] >=20 > Virtual CPU hotplug support is being added across various architectures [= 1][3]. > This series adds various code bits common across all architectures: >=20 > 1. vCPU creation and Parking code refactor [Patch 1] > 2. Update ACPI GED framework to support vCPU Hotplug [Patch 2,3] > 3. ACPI CPUs AML code change [Patch 4,5] > 4. Helper functions to support unrealization of CPU objects [Patch 6,7] with patch 1 and 3 fixed should be good to go. Salil, Can you remind me what happened to migration part of this? Ideally it should be a part of of this series as it should be common for everything that uses GED and should be a conditional part of GED's VMSTATE. If this series is just a common base and no actual hotplug on top of it is merged in this release (provided patch 13 is fixed), I'm fine with migration bits being a separate series on top. However if some machine would be introducing cpu hotplug in the same release, then the migration part should be merged before it or be a part that cpu hotplug series.=20 =20 > Repository: >=20 > [*] Architecture *Agnostic* Patch-set (This series) > V14: https://github.com/salil-mehta/qemu.git virt-cpuhp-armv8/rfc-v3.a= rch.agnostic.v15 >=20 > NOTE: This series is meant to work in conjunction with the architectur= e-specific > patch-set. For ARM, a combined patch-set (architecture agnostic + spec= ific) was > earlier pushed as RFC V2 [1]. Later, RFC V2 was split into the ARM Arc= hitecture > specific patch-set RFC V3 [4] (a subset of RFC V2) and the architectur= e agnostic > patch-set. Patch-set V14 is the latest version in that series. This se= ries > works in conjunction with RFC V4-rc2, present at the following link. >=20 > [*] ARM Architecture *Specific* Patch-set > RFC V3 [4]: https://github.com/salil-mehta/qemu.git virt-cpuhp-armv8/r= fc-v3 > RFC V4-rc2: https://github.com/salil-mehta/qemu.git virt-cpuhp-armv8/r= fc-v4-rc2 (combined) >=20 >=20 > Revision History: >=20 > Patch-set V14 -> V15 > 1. Addressed commnet from Igor Mammedov's on [PATCH V14 4/7] > - Removed ACPI_CPU_SCAN_METHOD > - Introduced AML_GED_EVT_CPU_SCAN_METHOD ("\\_SB.GED.CPSCN") macro > 2. Fix the stray change of "assert (" in "PATCH V14 3/7" > Link: https://lore.kernel.org/qemu-devel/20240712134201.214699-4-salil.me= hta@huawei.com/ >=20 > Patch-set V13 -> V14 > 1. Addressed Igor Mammedov's following review comments > - Mentioned abput new external APIs in the header note of [PATCH 1/7] > - Merged Doc [PATCH V13 8/8] with [PATCH V14 3/7] > - Introduced GED realize function for various CPU Hotplug regions init= ializations > - Added back event handler method to indirectly expose \\_SB.CPUS.CSCN= to GED > _EVT. Like for ARM, it would be through \\_SB.GED.CSCN event handler= method > - Collected the Ack given for [Patch V13 6/8] > - Added back the gfree'ing of GDB regs in common finalize and made it = conditional > - Updated the header notes of [PATCH V13 3/8,4/8,5/8] to reflect the c= hanges >=20 > Patch-set V12 -> V13 > 1. Added Reviewed-by Tag of Harsh Prateek Bora's (IBM) [PATCH V12 1/8] > 2. Moved the kvm_{create,park,unpark}_vcpu prototypes from accel/kvm/kvm-= cpus.h > to include/sysemu/kvm.h. These can later be exported through AccelOps. > Link: https://lore.kernel.org/qemu-devel/62f55169-1796-4d8e-a35d-7f003a17= 2750@linux.ibm.com/ >=20 > Patch-set V11 -> V12 > 1. Addressed Harsh Prateek Bora's (IBM) comment > - Changed @cpu to @vcpu_id in the kvm_unpark_vcpu protoype header/ > 2. Added Zhao Liu's (Intel) Tested-by for whole series > - Qtest does not breaks on Intel platforms now. > 3. Added Zhao Liu's (Intel) Reviewed-by for [PATCH V11 {1/8 - 3/8}] > Link: https://lore.kernel.org/qemu-devel/ZlRSPuJGBgyEUW6w@intel.com/ > Link: https://lore.kernel.org/qemu-devel/a5f3d78e-cfed-441f-9c56-e3e78fa5= edee@linux.ibm.com/ >=20 > Patch-set V10 -> V11 > 1. Addressed Nicholas Piggin's (IBM) comment > - moved the traces in kvm_unpark_vcpu and kvm_create_vcpu at the end > - Added the Reviewed-by Tag for [PATCH V10 1/8] > 2. Addressed Alex Benn=C3=A9e's (Linaro) comments > - Added a note explaining dependency of the [PATCH V10 7/8] on Arch sp= ecific patch-set > Link: https://lore.kernel.org/qemu-devel/D1FS5GOOFWWK.2PNRIVL0V6DBL@gmail= .com/=20 > Link: https://lore.kernel.org/qemu-devel/87frubi402.fsf@draig.linaro.org/ >=20 > Patch-set V9 -> V10 > 1. Addressed Nicholas Piggin's (IBM) & Philippe Mathieu-Daud=C3=A9 (Linar= o) comments > - carved out kvm_unpark_vcpu and added its trace > - Widened the scope of the kvm_unpark_vcpu so that it can be used by g= eneric framework > being thought out > Link: https://lore.kernel.org/qemu-devel/20240519210620.228342-1-salil.me= hta@huawei.com/ > Link: https://lore.kernel.org/qemu-devel/e94b0e14-efee-4050-9c9f-08382a36= b63a@linaro.org/ >=20 > Patch-set V8 -> V9 > 1. Addressed Vishnu Pajjuri's (Ampere) comments > - Added kvm_fd to trace in kvm_create_vcpu > - Some clean ups: arch vcpu-id and sbd variable > - Added the missed initialization of cpu->gdb_num_regs > 2. Addressed the commnet from Zhao Liu (Intel) > - Make initialization of CPU Hotplug state conditional (possible_cpu_a= rch_ids!=3DNULL) > Link: https://lore.kernel.org/qemu-devel/20240312020000.12992-1-salil.meh= ta@huawei.com/ >=20 > Patch-set V7 -> V8 > 1. Rebased and Fixed the conflicts >=20 > Patch-set V6 -> V7 > 1. Addressed Alex Benn=C3=A9e's comments > - Updated the docs > 2. Addressed Igor Mammedov's comments > - Merged patches [Patch V6 3/9] & [Patch V6 7/9] with [Patch V6 4/9] > - Updated commit-log of [Patch V6 1/9] and [Patch V6 5/9] =20 > 3. Added Shaoqin Huang's Reviewed-by tags for whole series. > Link: https://lore.kernel.org/qemu-devel/20231013105129.25648-1-salil.meh= ta@huawei.com/ >=20 > Patch-set V5 -> V6 > 1. Addressed Gavin Shan's comments > - Fixed the assert() ranges of address spaces > - Rebased the patch-set to latest changes in the qemu.git > - Added Reviewed-by tags for patches {8,9} > 2. Addressed Jonathan Cameron's comments > - Updated commit-log for [Patch V5 1/9] with mention of trace events > - Added Reviewed-by tags for patches {1,5} > 3. Added Tested-by tags from Xianglai Li > 4. Fixed checkpatch.pl error "Qemu -> QEMU" in [Patch V5 1/9]=20 > Link: https://lore.kernel.org/qemu-devel/20231011194355.15628-1-salil.meh= ta@huawei.com/ >=20 > Patch-set V4 -> V5 > 1. Addressed Gavin Shan's comments > - Fixed the trace events print string for kvm_{create,get,park,destroy= }_vcpu > - Added Reviewed-by tag for patch {1} > 2. Added Shaoqin Huang's Reviewed-by tags for Patches {2,3} > 3. Added Tested-by Tag from Vishnu Pajjuri to the patch-set > 4. Dropped the ARM specific [Patch V4 10/10] > Link: https://lore.kernel.org/qemu-devel/20231009203601.17584-1-salil.meh= ta@huawei.com/ >=20 > Patch-set V3 -> V4 > 1. Addressed David Hilderbrand's comments > - Fixed the wrong doc comment of kvm_park_vcpu API prototype > - Added Reviewed-by tags for patches {2,4} > Link: https://lore.kernel.org/qemu-devel/20231009112812.10612-1-salil.meh= ta@huawei.com/ >=20 > Patch-set V2 -> V3 > 1. Addressed Jonathan Cameron's comments > - Fixed 'vcpu-id' type wrongly changed from 'unsigned long' to 'intege= r' > - Removed unnecessary use of variable 'vcpu_id' in kvm_park_vcpu > - Updated [Patch V2 3/10] commit-log with details of ACPI_CPU_SCAN_MET= HOD macro > - Updated [Patch V2 5/10] commit-log with details of conditional event= handler method > - Added Reviewed-by tags for patches {2,3,4,6,7} > 2. Addressed Gavin Shan's comments > - Remove unnecessary use of variable 'vcpu_id' in kvm_par_vcpu > - Fixed return value in kvm_get_vcpu from -1 to -ENOENT > - Reset the value of 'gdb_num_g_regs' in gdb_unregister_coprocessor_all > - Fixed the kvm_{create,park}_vcpu prototypes docs > - Added Reviewed-by tags for patches {2,3,4,5,6,7,9,10} > 3. Addressed one earlier missed comment by Alex Benn=C3=A9e in RFC V1 > - Added traces instead of DPRINTF in the newly added and some existing= functions > Link: https://lore.kernel.org/qemu-devel/20230930001933.2660-1-salil.meht= a@huawei.com/ >=20 > Patch-set V1 -> V2 > 1. Addressed Alex Benn=C3=A9e's comments > - Refactored the kvm_create_vcpu logic to get rid of goto > - Added the docs for kvm_{create,park}_vcpu prototypes > - Splitted the gdbstub and AddressSpace destruction change into separa= te patches > - Added Reviewed-by tags for patches {2,10} > Link: https://lore.kernel.org/qemu-devel/20230929124304.13672-1-salil.meh= ta@huawei.com/ >=20 > References: >=20 > [1] https://lore.kernel.org/qemu-devel/20230926100436.28284-1-salil.mehta= @huawei.com/ > [2] https://lore.kernel.org/all/20230913163823.7880-1-james.morse@arm.com/ > [3] https://lore.kernel.org/qemu-devel/cover.1695697701.git.lixianglai@lo= ongson.cn/ > [4] https://lore.kernel.org/qemu-devel/20240613233639.202896-2-salil.meht= a@huawei.com/ >=20 > Salil Mehta (7): > accel/kvm: Extract common KVM vCPU {creation,parking} code > hw/acpi: Move CPU ctrl-dev MMIO region len macro to common header file > hw/acpi: Update ACPI GED framework to support vCPU Hotplug > hw/acpi: Update GED _EVT method AML with CPU scan > hw/acpi: Update CPUs AML with cpu-(ctrl)dev change > physmem: Add helper function to destroy CPU AddressSpace > gdbstub: Add helper function to unregister GDB register space >=20 > accel/kvm/kvm-all.c | 95 +++++++++++++++++--------- > accel/kvm/kvm-cpus.h | 1 - > accel/kvm/trace-events | 5 +- > docs/specs/acpi_hw_reduced_hotplug.rst | 3 +- > gdbstub/gdbstub.c | 13 ++++ > hw/acpi/acpi-cpu-hotplug-stub.c | 6 ++ > hw/acpi/cpu.c | 18 +++-- > hw/acpi/generic_event_device.c | 27 ++++++++ > hw/core/cpu-common.c | 4 +- > hw/i386/acpi-build.c | 3 +- > include/exec/cpu-common.h | 8 +++ > include/exec/gdbstub.h | 6 ++ > include/hw/acpi/cpu.h | 7 +- > include/hw/acpi/generic_event_device.h | 5 ++ > include/hw/core/cpu.h | 1 + > include/sysemu/kvm.h | 25 +++++++ > system/physmem.c | 29 ++++++++ > 17 files changed, 212 insertions(+), 44 deletions(-) >=20