From: Michael Kowal <kowal@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, clg@kaod.org, fbarrat@linux.ibm.com,
npiggin@gmail.com, milesg@linux.ibm.com
Subject: [PATCH v2 6/9] pnv/xive2: Enable VST NVG and NVC index compression
Date: Mon, 15 Jul 2024 13:33:29 -0500 [thread overview]
Message-ID: <20240715183332.27287-7-kowal@linux.vnet.ibm.com> (raw)
In-Reply-To: <20240715183332.27287-1-kowal@linux.vnet.ibm.com>
From: Frederic Barrat <fbarrat@linux.ibm.com>
Enable NVG and NVC VST tables for index compression which indicates the number
of bits the address is shifted to the right for the table accesses.
The compression values are defined as:
0000 - No compression
0001 - 1 bit shift
0010 - 2 bit shift
....
1000 - 8 bit shift
1001-1111 - No compression
Signed-off-by: Frederic Barrat <fbarrat@linux.ibm.com>
Signed-off-by: Michael Kowal <kowal@linux.vnet.ibm.com>
---
hw/intc/pnv_xive2_regs.h | 2 ++
hw/intc/pnv_xive2.c | 20 ++++++++++++++++++++
2 files changed, 22 insertions(+)
diff --git a/hw/intc/pnv_xive2_regs.h b/hw/intc/pnv_xive2_regs.h
index ca05255d20..e8b87b3d2c 100644
--- a/hw/intc/pnv_xive2_regs.h
+++ b/hw/intc/pnv_xive2_regs.h
@@ -427,6 +427,8 @@
#define X_PC_NXC_PROC_CONFIG 0x28A
#define PC_NXC_PROC_CONFIG 0x450
#define PC_NXC_PROC_CONFIG_WATCH_ASSIGN PPC_BITMASK(0, 3)
+#define PC_NXC_PROC_CONFIG_NVG_TABLE_COMPRESS PPC_BITMASK(32, 35)
+#define PC_NXC_PROC_CONFIG_NVC_TABLE_COMPRESS PPC_BITMASK(36, 39)
/* NxC Cache Watch 0 Specification */
#define X_PC_NXC_WATCH0_SPEC 0x2A0
diff --git a/hw/intc/pnv_xive2.c b/hw/intc/pnv_xive2.c
index 9e45161869..b14fad1b2e 100644
--- a/hw/intc/pnv_xive2.c
+++ b/hw/intc/pnv_xive2.c
@@ -217,6 +217,20 @@ static uint64_t pnv_xive2_vst_addr_indirect(PnvXive2 *xive, uint32_t type,
return pnv_xive2_vst_addr_direct(xive, type, vsd, (idx % vst_per_page));
}
+static uint8_t pnv_xive2_nvc_table_compress_shift(PnvXive2 *xive)
+{
+ uint8_t shift = GETFIELD(PC_NXC_PROC_CONFIG_NVC_TABLE_COMPRESS,
+ xive->pc_regs[PC_NXC_PROC_CONFIG >> 3]);
+ return shift > 8 ? 0 : shift;
+}
+
+static uint8_t pnv_xive2_nvg_table_compress_shift(PnvXive2 *xive)
+{
+ uint8_t shift = GETFIELD(PC_NXC_PROC_CONFIG_NVG_TABLE_COMPRESS,
+ xive->pc_regs[PC_NXC_PROC_CONFIG >> 3]);
+ return shift > 8 ? 0 : shift;
+}
+
static uint64_t pnv_xive2_vst_addr(PnvXive2 *xive, uint32_t type, uint8_t blk,
uint32_t idx)
{
@@ -238,6 +252,12 @@ static uint64_t pnv_xive2_vst_addr(PnvXive2 *xive, uint32_t type, uint8_t blk,
return xive ? pnv_xive2_vst_addr(xive, type, blk, idx) : 0;
}
+ if (type == VST_NVG) {
+ idx >>= pnv_xive2_nvg_table_compress_shift(xive);
+ } else if (type == VST_NVC) {
+ idx >>= pnv_xive2_nvc_table_compress_shift(xive);
+ }
+
if (VSD_INDIRECT & vsd) {
return pnv_xive2_vst_addr_indirect(xive, type, vsd, idx);
}
--
2.43.0
next prev parent reply other threads:[~2024-07-15 18:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 18:33 [PATCH v2 0/9] XIVE changes for Cache Watch, VSTs, STT and info pic Michael Kowal
2024-07-15 18:33 ` [PATCH v2 1/9] pnv/xive2: XIVE2 Cache Watch, Cache Flush and Sync Injection support Michael Kowal
2024-07-16 7:28 ` Cédric Le Goater
2024-07-16 15:32 ` Mike Kowal
2024-07-16 15:55 ` Mike Kowal
2024-07-15 18:33 ` [PATCH v2 2/9] pnv/xive2: Structure/define alignment changes Michael Kowal
2024-07-16 7:04 ` Cédric Le Goater
2024-07-15 18:33 ` [PATCH v2 3/9] pnv/xive: Support cache flush and queue sync inject with notifications Michael Kowal
2024-07-16 7:26 ` Cédric Le Goater
2024-07-15 18:33 ` [PATCH v2 4/9] pnv/xive2: Add NVG and NVC to cache watch facility Michael Kowal
2024-07-16 7:29 ` Cédric Le Goater
2024-07-16 15:46 ` Mike Kowal
2024-07-16 18:39 ` Mike Kowal
2024-07-15 18:33 ` [PATCH v2 5/9] pnv/xive2: Configure Virtualization Structure Tables through the PC Michael Kowal
2024-07-16 7:06 ` Cédric Le Goater
2024-07-15 18:33 ` Michael Kowal [this message]
2024-07-16 7:05 ` [PATCH v2 6/9] pnv/xive2: Enable VST NVG and NVC index compression Cédric Le Goater
2024-07-15 18:33 ` [PATCH v2 7/9] pnv/xive2: Set Translation Table for the NVC port space Michael Kowal
2024-07-16 7:07 ` Cédric Le Goater
2024-07-15 18:33 ` [PATCH v2 8/9] pnv/xive2: Fail VST entry address computation if table has no VSD Michael Kowal
2024-07-16 7:05 ` Cédric Le Goater
2024-07-15 18:33 ` [PATCH v2 9/9] pnv/xive2: Move xive2_nvp_pic_print_info() to xive2.c Michael Kowal
2024-07-16 7:15 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240715183332.27287-7-kowal@linux.vnet.ibm.com \
--to=kowal@linux.vnet.ibm.com \
--cc=clg@kaod.org \
--cc=fbarrat@linux.ibm.com \
--cc=milesg@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).