From: Akihiko Odaki <akihiko.odaki@daynix.com>
To: Peter Maydell <peter.maydell@linaro.org>,
Thomas Huth <thuth@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, kvm@vger.kernel.org,
Akihiko Odaki <akihiko.odaki@daynix.com>
Subject: [PATCH v2 1/5] tests/arm-cpu-features: Do not assume PMU availability
Date: Tue, 16 Jul 2024 17:28:13 +0900 [thread overview]
Message-ID: <20240716-pmu-v2-1-f3e3e4b2d3d5@daynix.com> (raw)
In-Reply-To: <20240716-pmu-v2-0-f3e3e4b2d3d5@daynix.com>
Asahi Linux supports KVM but lacks PMU support.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
tests/qtest/arm-cpu-features.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/tests/qtest/arm-cpu-features.c b/tests/qtest/arm-cpu-features.c
index 966c65d5c3e4..cfd6f7735354 100644
--- a/tests/qtest/arm-cpu-features.c
+++ b/tests/qtest/arm-cpu-features.c
@@ -509,6 +509,7 @@ static void test_query_cpu_model_expansion_kvm(const void *data)
assert_set_feature(qts, "host", "kvm-no-adjvtime", false);
if (g_str_equal(qtest_get_arch(), "aarch64")) {
+ bool kvm_supports_pmu;
bool kvm_supports_steal_time;
bool kvm_supports_sve;
char max_name[8], name[8];
@@ -537,11 +538,6 @@ static void test_query_cpu_model_expansion_kvm(const void *data)
assert_has_feature_enabled(qts, "host", "aarch64");
- /* Enabling and disabling pmu should always work. */
- assert_has_feature_enabled(qts, "host", "pmu");
- assert_set_feature(qts, "host", "pmu", false);
- assert_set_feature(qts, "host", "pmu", true);
-
/*
* Some features would be enabled by default, but they're disabled
* because this instance of KVM doesn't support them. Test that the
@@ -551,11 +547,18 @@ static void test_query_cpu_model_expansion_kvm(const void *data)
assert_has_feature(qts, "host", "sve");
resp = do_query_no_props(qts, "host");
+ kvm_supports_pmu = resp_get_feature(resp, "pmu");
kvm_supports_steal_time = resp_get_feature(resp, "kvm-steal-time");
kvm_supports_sve = resp_get_feature(resp, "sve");
vls = resp_get_sve_vls(resp);
qobject_unref(resp);
+ if (kvm_supports_pmu) {
+ /* If we have pmu then we should be able to toggle it. */
+ assert_set_feature(qts, "host", "pmu", false);
+ assert_set_feature(qts, "host", "pmu", true);
+ }
+
if (kvm_supports_steal_time) {
/* If we have steal-time then we should be able to toggle it. */
assert_set_feature(qts, "host", "kvm-steal-time", false);
--
2.45.2
next prev parent reply other threads:[~2024-07-16 8:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-16 8:28 [PATCH v2 0/5] target/arm/kvm: Report PMU unavailability Akihiko Odaki
2024-07-16 8:28 ` Akihiko Odaki [this message]
2024-07-16 9:16 ` [PATCH v2 1/5] tests/arm-cpu-features: Do not assume PMU availability Philippe Mathieu-Daudé
2024-07-16 8:28 ` [PATCH v2 2/5] target/arm: Allow setting 'pmu' only for host and max Akihiko Odaki
2024-07-16 9:36 ` Peter Maydell
2024-07-16 8:28 ` [PATCH v2 3/5] target/arm: Do not allow setting 'pmu' for hvf Akihiko Odaki
2024-07-16 11:28 ` Peter Maydell
2024-07-16 8:28 ` [PATCH v2 4/5] target/arm: Always add pmu property Akihiko Odaki
2024-07-16 9:19 ` Philippe Mathieu-Daudé
2024-07-16 11:32 ` Peter Maydell
2024-07-16 11:36 ` Akihiko Odaki
2024-07-16 12:53 ` Peter Maydell
2024-07-16 8:28 ` [PATCH v2 5/5] target/arm/kvm: Report PMU unavailability Akihiko Odaki
2024-07-16 9:22 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240716-pmu-v2-1-f3e3e4b2d3d5@daynix.com \
--to=akihiko.odaki@daynix.com \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).