qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Akihiko Odaki <akihiko.odaki@daynix.com>
To: Peter Maydell <peter.maydell@linaro.org>,
	 Thomas Huth <thuth@redhat.com>,
	Laurent Vivier <lvivier@redhat.com>,
	 Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, kvm@vger.kernel.org,
	 Akihiko Odaki <akihiko.odaki@daynix.com>
Subject: [PATCH v2 2/5] target/arm: Allow setting 'pmu' only for host and max
Date: Tue, 16 Jul 2024 17:28:14 +0900	[thread overview]
Message-ID: <20240716-pmu-v2-2-f3e3e4b2d3d5@daynix.com> (raw)
In-Reply-To: <20240716-pmu-v2-0-f3e3e4b2d3d5@daynix.com>

Setting 'pmu' does not make sense for CPU types emulating physical
CPUs.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
 target/arm/cpu.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index 14d4eca12740..8c180c679ce2 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -1594,6 +1594,13 @@ static bool arm_get_pmu(Object *obj, Error **errp)
 static void arm_set_pmu(Object *obj, bool value, Error **errp)
 {
     ARMCPU *cpu = ARM_CPU(obj);
+    const char *typename = object_get_typename(obj);
+
+    if (strcmp(typename, ARM_CPU_TYPE_NAME("host")) &&
+        strcmp(typename, ARM_CPU_TYPE_NAME("max"))) {
+        error_setg(errp, "Setting 'pmu' is only supported by host and max");
+        return;
+    }
 
     if (value) {
         if (kvm_enabled() && !kvm_arm_pmu_supported()) {

-- 
2.45.2



  parent reply	other threads:[~2024-07-16  8:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-16  8:28 [PATCH v2 0/5] target/arm/kvm: Report PMU unavailability Akihiko Odaki
2024-07-16  8:28 ` [PATCH v2 1/5] tests/arm-cpu-features: Do not assume PMU availability Akihiko Odaki
2024-07-16  9:16   ` Philippe Mathieu-Daudé
2024-07-16  8:28 ` Akihiko Odaki [this message]
2024-07-16  9:36   ` [PATCH v2 2/5] target/arm: Allow setting 'pmu' only for host and max Peter Maydell
2024-07-16  8:28 ` [PATCH v2 3/5] target/arm: Do not allow setting 'pmu' for hvf Akihiko Odaki
2024-07-16 11:28   ` Peter Maydell
2024-07-16  8:28 ` [PATCH v2 4/5] target/arm: Always add pmu property Akihiko Odaki
2024-07-16  9:19   ` Philippe Mathieu-Daudé
2024-07-16 11:32   ` Peter Maydell
2024-07-16 11:36     ` Akihiko Odaki
2024-07-16 12:53       ` Peter Maydell
2024-07-16  8:28 ` [PATCH v2 5/5] target/arm/kvm: Report PMU unavailability Akihiko Odaki
2024-07-16  9:22   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240716-pmu-v2-2-f3e3e4b2d3d5@daynix.com \
    --to=akihiko.odaki@daynix.com \
    --cc=kvm@vger.kernel.org \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).