qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org, thuth@redhat.com, lvivier@redhat.com,
	pbonzini@redhat.com
Subject: Re: [PATCH] tests: increase timeout per instance of bios-tables-test
Date: Tue, 16 Jul 2024 09:06:59 -0400	[thread overview]
Message-ID: <20240716090554-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20240716125930.620861-1-imammedo@redhat.com>

On Tue, Jul 16, 2024 at 02:59:30PM +0200, Igor Mammedov wrote:
> CI often fails 'cross-i686-tci' job due to runner slowness
> Log shows that test almost complete, with a few remaining
> when bios-tables-test timeout hits:
> 
>   19/270 qemu:qtest+qtest-aarch64 / qtest-aarch64/bios-tables-test
>     TIMEOUT        610.02s   killed by signal 15 SIGTERM
>   ...
>   stderr:
>   TAP parsing error: Too few tests run (expected 8, got 7)
> 
> At the same time overall job running time is only ~30 out of 1hr allowed.
> 
> Increase bios-tables-test instance timeout on 5min as a fix
> for slow CI runners.
> 
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>

We can't just keep increasing the timeout.
The issue is checking wall time on a busy host,
isn't it? Let's check CPU time instead.

> ---
>  tests/qtest/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
> index 6508bfb1a2..ff9200f882 100644
> --- a/tests/qtest/meson.build
> +++ b/tests/qtest/meson.build
> @@ -1,6 +1,6 @@
>  slow_qtests = {
>    'aspeed_smc-test': 360,
> -  'bios-tables-test' : 610,
> +  'bios-tables-test' : 910,
>    'cdrom-test' : 610,
>    'device-introspect-test' : 720,
>    'migration-test' : 480,
> -- 
> 2.43.0



  reply	other threads:[~2024-07-16 13:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-16 12:59 [PATCH] tests: increase timeout per instance of bios-tables-test Igor Mammedov
2024-07-16 13:06 ` Michael S. Tsirkin [this message]
2024-07-16 13:41   ` Peter Maydell
2024-07-16 14:48   ` Igor Mammedov
2024-07-16 17:44   ` Thomas Huth
2024-07-16 19:52     ` Peter Maydell
2024-07-22  7:35 ` Thomas Huth
2024-07-22  7:47   ` Michael S. Tsirkin
2024-07-22  9:50   ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240716090554-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).