From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: richard.henderson@linaro.org,
"Michael S . Tsirkin" <mst@redhat.com>,
John Snow <jsnow@redhat.com>
Subject: [PULL 03/14] qapi/machine: Clean up documentation around CpuInstanceProperties
Date: Wed, 17 Jul 2024 12:48:56 +0200 [thread overview]
Message-ID: <20240717104907.2962784-4-armbru@redhat.com> (raw)
In-Reply-To: <20240717104907.2962784-1-armbru@redhat.com>
CpuInstanceProperties' doc comment describes its members as properties
to be passed to device_add when hot-plugging a CPU.
This was in fact the initial use of this type, with
query-hotpluggable-cpus: letting management applications find out what
properties need to be passed with device_add to hot-plug a CPU.
We've since added other uses: set-numa-node (commit 419fcdec3c1 and
f3be67812c2), and query-cpus-fast (commit ce74ee3dea6). These are not
about device-add.
query-hotpluggable-cpus uses CpuInstanceProperties within
HotpluggableCPU. Lift the documentation related to device-add from
CpuInstanceProperties to HotpluggableCPU.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20240711112228.2140606-3-armbru@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
---
qapi/machine.json | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/qapi/machine.json b/qapi/machine.json
index f15ad1b43e..50ff102d56 100644
--- a/qapi/machine.json
+++ b/qapi/machine.json
@@ -960,9 +960,7 @@
##
# @CpuInstanceProperties:
#
-# List of properties to be used for hotplugging a CPU instance, it
-# should be passed by management with device_add command when a CPU is
-# being hotplugged.
+# Properties identifying a CPU.
#
# Which members are optional and which mandatory depends on the
# architecture and board.
@@ -996,9 +994,6 @@
#
# @thread-id: thread number within the core the CPU belongs to
#
-# .. note:: Management should be prepared to pass through additional
-# properties with device_add.
-#
# Since: 2.7
##
{ 'struct': 'CpuInstanceProperties',
@@ -1020,7 +1015,8 @@
#
# @type: CPU object type for usage with device_add command
#
-# @props: list of properties to be used for hotplugging CPU
+# @props: list of properties to pass for hotplugging a CPU with
+# device_add
#
# @vcpus-count: number of logical VCPU threads @HotpluggableCPU
# provides
@@ -1028,6 +1024,9 @@
# @qom-path: link to existing CPU object if CPU is present or omitted
# if CPU is not present.
#
+# .. note:: Management should be prepared to pass through additional
+# properties with device_add.
+#
# Since: 2.7
##
{ 'struct': 'HotpluggableCPU',
--
2.45.0
next prev parent reply other threads:[~2024-07-17 10:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 10:48 [PULL 00/14] QAPI patches patches for 2024-07-17 Markus Armbruster
2024-07-17 10:48 ` [PULL 01/14] qapi/qom: Document feature unstable of @x-vfio-user-server Markus Armbruster
2024-07-17 10:48 ` [PULL 02/14] qapi/pci: Clean up documentation around PciDeviceClass Markus Armbruster
2024-07-17 10:48 ` Markus Armbruster [this message]
2024-07-17 10:48 ` [PULL 04/14] qapi/machine: Clarify query-uuid value when none has been specified Markus Armbruster
2024-07-17 10:48 ` [PULL 05/14] qapi/sockets: Move deprecation note out of SocketAddress doc comment Markus Armbruster
2024-07-17 10:48 ` [PULL 06/14] qapi/ui: Drop note on naming of SpiceQueryMouseMode Markus Armbruster
2024-07-17 10:49 ` [PULL 07/14] docs/qapidoc: factor out do_parse() Markus Armbruster
2024-07-17 10:49 ` [PULL 08/14] docs/qapidoc: create qmp-example directive Markus Armbruster
2024-07-17 10:49 ` [PULL 09/14] docs/qapidoc: add QMP highlighting to annotated qmp-example blocks Markus Armbruster
2024-07-17 10:49 ` [PULL 10/14] docs/sphinx: add CSS styling for qmp-example directive Markus Armbruster
2024-07-17 10:49 ` [PULL 11/14] qapi: convert "Example" sections without titles Markus Armbruster
2024-07-17 10:49 ` [PULL 12/14] qapi: convert "Example" sections with titles Markus Armbruster
2024-07-17 10:49 ` [PULL 13/14] qapi: convert "Example" sections with longer prose Markus Armbruster
2024-07-17 10:49 ` [PULL 14/14] qapi: remove "Example" doc section Markus Armbruster
2024-07-18 11:22 ` [PULL 00/14] QAPI patches patches for 2024-07-17 Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240717104907.2962784-4-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).