From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Thomas Huth" <thuth@redhat.com>,
"Daniel Henrique Barboza" <dbarboza@ventanamicro.com>,
"Alexandre Iooss" <erdnaxe@crans.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
qemu-arm@nongnu.org, "Bin Meng" <bmeng.cn@gmail.com>,
qemu-riscv@nongnu.org, "Aleksandar Rikalo" <arikalo@gmail.com>,
"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
"Liu Zhiwei" <zhiwei_liu@linux.alibaba.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Beraldo Leal" <bleal@redhat.com>,
"Li-Wen Hsu" <lwhsu@freebsd.org>, "Ed Maste" <emaste@freebsd.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Weiwei Li" <liwei1518@gmail.com>,
"Alistair Francis" <alistair.francis@wdc.com>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Mahmoud Mandour" <ma.mandourr@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Laurent Vivier" <laurent@vivier.eu>,
"Frédéric Pétrot" <frederic.petrot@univ-grenoble-alpes.fr>
Subject: [PATCH 07/15] plugins/execlog.c: correct dump of registers values
Date: Thu, 18 Jul 2024 10:45:15 +0100 [thread overview]
Message-ID: <20240718094523.1198645-8-alex.bennee@linaro.org> (raw)
In-Reply-To: <20240718094523.1198645-1-alex.bennee@linaro.org>
From: Frédéric Pétrot <frederic.petrot@univ-grenoble-alpes.fr>
Register values are dumped as 'sz' chunks of two nibbles in the execlog
plugin, sz was 1 too big.
Signed-off-by: Frédéric Pétrot <frederic.petrot@univ-grenoble-alpes.fr>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Message-Id: <20240620083805.73603-1-frederic.petrot@univ-grenoble-alpes.fr>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
contrib/plugins/execlog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/plugins/execlog.c b/contrib/plugins/execlog.c
index 371db97eb1..1c1601cc0b 100644
--- a/contrib/plugins/execlog.c
+++ b/contrib/plugins/execlog.c
@@ -101,7 +101,7 @@ static void insn_check_regs(CPU *cpu)
GByteArray *temp = reg->last;
g_string_append_printf(cpu->last_exec, ", %s -> 0x", reg->name);
/* TODO: handle BE properly */
- for (int i = sz; i >= 0; i--) {
+ for (int i = sz - 1; i >= 0; i--) {
g_string_append_printf(cpu->last_exec, "%02x",
reg->new->data[i]);
}
--
2.39.2
next prev parent reply other threads:[~2024-07-18 9:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-18 9:45 [PATCH 00/15] Final bits for 9.1-rc0 (docker, plugins, gdbstub, semihosting) Alex Bennée
2024-07-18 9:45 ` [PATCH 01/15] testing: bump to latest libvirt-ci Alex Bennée
2024-07-18 11:30 ` Philippe Mathieu-Daudé
2024-07-18 9:45 ` [PATCH 02/15] tests/avocado: Remove non-working sparc leon3 test Alex Bennée
2024-07-18 9:45 ` [PATCH 03/15] gdbstub: Re-factor gdb command extensions Alex Bennée
2024-07-18 9:45 ` [PATCH 04/15] plugins/stoptrigger: TCG plugin to stop execution under conditions Alex Bennée
2024-07-18 9:45 ` [PATCH 05/15] plugins: fix mem callback array size Alex Bennée
2024-07-18 9:45 ` [PATCH 06/15] tests/plugins: use qemu_plugin_outs for inline stats Alex Bennée
2024-07-18 11:32 ` Philippe Mathieu-Daudé
2024-07-18 16:37 ` Pierrick Bouvier
2024-07-18 9:45 ` Alex Bennée [this message]
2024-07-18 9:45 ` [PATCH 08/15] semihosting: Include missing 'gdbstub/syscalls.h' header Alex Bennée
2024-07-18 9:45 ` [PATCH 09/15] target/m68k: Add semihosting stub Alex Bennée
2024-07-18 9:45 ` [PATCH 10/15] target/mips: " Alex Bennée
2024-07-18 9:45 ` [PATCH 11/15] target/m68k: Restrict semihosting to TCG Alex Bennée
2024-07-18 9:45 ` [PATCH 12/15] target/mips: " Alex Bennée
2024-07-18 9:45 ` [PATCH 13/15] target/riscv: " Alex Bennée
2024-07-18 9:45 ` [PATCH 14/15] target/xtensa: " Alex Bennée
2024-07-18 9:45 ` [PATCH 15/15] semihosting: Restrict " Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240718094523.1198645-8-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=arikalo@gmail.com \
--cc=aurelien@aurel32.net \
--cc=bleal@redhat.com \
--cc=bmeng.cn@gmail.com \
--cc=dbarboza@ventanamicro.com \
--cc=emaste@freebsd.org \
--cc=erdnaxe@crans.org \
--cc=frederic.petrot@univ-grenoble-alpes.fr \
--cc=jcmvbkbc@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=laurent@vivier.eu \
--cc=liwei1518@gmail.com \
--cc=lwhsu@freebsd.org \
--cc=ma.mandourr@gmail.com \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).