qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PULL 22/26] target/arm: Use float_status copy in sme_fmopa_s
Date: Thu, 18 Jul 2024 14:20:24 +0100	[thread overview]
Message-ID: <20240718132028.697927-23-peter.maydell@linaro.org> (raw)
In-Reply-To: <20240718132028.697927-1-peter.maydell@linaro.org>

From: Daniyal Khan <danikhan632@gmail.com>

We made a copy above because the fp exception flags
are not propagated back to the FPST register, but
then failed to use the copy.

Cc: qemu-stable@nongnu.org
Fixes: 558e956c719 ("target/arm: Implement FMOPA, FMOPS (non-widening)")
Signed-off-by: Daniyal Khan <danikhan632@gmail.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Message-id: 20240717060149.204788-2-richard.henderson@linaro.org
[rth: Split from a larger patch]
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target/arm/tcg/sme_helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/arm/tcg/sme_helper.c b/target/arm/tcg/sme_helper.c
index e2e05750399..5a6dd76489f 100644
--- a/target/arm/tcg/sme_helper.c
+++ b/target/arm/tcg/sme_helper.c
@@ -916,7 +916,7 @@ void HELPER(sme_fmopa_s)(void *vza, void *vzn, void *vzm, void *vpn,
                         if (pb & 1) {
                             uint32_t *a = vza_row + H1_4(col);
                             uint32_t *m = vzm + H1_4(col);
-                            *a = float32_muladd(n, *m, *a, 0, vst);
+                            *a = float32_muladd(n, *m, *a, 0, &fpst);
                         }
                         col += 4;
                         pb >>= 4;
-- 
2.34.1



  parent reply	other threads:[~2024-07-18 13:23 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-18 13:20 [PULL 00/26] target-arm queue Peter Maydell
2024-07-18 13:20 ` [PULL 01/26] target/arm: Fix handling of LDAPR/STLR with negative offset Peter Maydell
2024-07-18 13:20 ` [PULL 02/26] target/arm: LDAPR should honour SCTLR_ELx.nAA Peter Maydell
2024-07-18 13:20 ` [PULL 03/26] hw/display/bcm2835_fb: fix fb_use_offsets condition Peter Maydell
2024-07-18 13:20 ` [PULL 04/26] hw/arm/smmu-common: Add missing size check for stage-1 Peter Maydell
2024-07-18 13:20 ` [PULL 05/26] hw/arm/smmu: Fix IPA for stage-2 events Peter Maydell
2024-07-18 13:20 ` [PULL 06/26] hw/arm/smmuv3: Fix encoding of CLASS in events Peter Maydell
2024-07-18 13:20 ` [PULL 07/26] hw/arm/smmu: Use enum for SMMU stage Peter Maydell
2024-07-18 13:20 ` [PULL 08/26] hw/arm/smmu: Split smmuv3_translate() Peter Maydell
2024-07-18 13:20 ` [PULL 09/26] hw/arm/smmu: Consolidate ASID and VMID types Peter Maydell
2024-07-18 13:20 ` [PULL 10/26] hw/arm/smmu: Introduce CACHED_ENTRY_TO_ADDR Peter Maydell
2024-07-18 13:20 ` [PULL 11/26] hw/arm/smmuv3: Translate CD and TT using stage-2 table Peter Maydell
2024-07-18 13:20 ` [PULL 12/26] hw/arm/smmu-common: Rework TLB lookup for nesting Peter Maydell
2024-07-18 13:20 ` [PULL 13/26] hw/arm/smmu-common: Add support for nested TLB Peter Maydell
2024-07-18 13:20 ` [PULL 14/26] hw/arm/smmu-common: Support nested translation Peter Maydell
2024-07-18 13:20 ` [PULL 15/26] hw/arm/smmu: Support nesting in smmuv3_range_inval() Peter Maydell
2024-07-18 13:20 ` [PULL 16/26] hw/arm/smmu: Introduce smmu_iotlb_inv_asid_vmid Peter Maydell
2024-07-18 13:20 ` [PULL 17/26] hw/arm/smmu: Support nesting in the rest of commands Peter Maydell
2024-07-18 13:20 ` [PULL 18/26] hw/arm/smmuv3: Support nested SMMUs in smmuv3_notify_iova() Peter Maydell
2024-07-18 13:20 ` [PULL 19/26] hw/arm/smmuv3: Handle translation faults according to SMMUPTWEventInfo Peter Maydell
2024-07-18 13:20 ` [PULL 20/26] hw/arm/smmuv3: Support and advertise nesting Peter Maydell
2024-07-18 13:20 ` [PULL 21/26] hw/arm/smmu: Refactor SMMU OAS Peter Maydell
2024-07-20 15:05   ` Peter Maydell
2024-07-20 22:07     ` Mostafa Saleh
2024-07-22  9:33       ` Peter Maydell
2024-07-18 13:20 ` Peter Maydell [this message]
2024-07-18 13:20 ` [PULL 23/26] target/arm: Use FPST_F16 for SME FMOPA (widening) Peter Maydell
2024-07-18 13:20 ` [PULL 24/26] tests/tcg/aarch64: Add test cases " Peter Maydell
2024-07-18 13:20 ` [PULL 25/26] tests/arm-cpu-features: Do not assume PMU availability Peter Maydell
2024-07-18 13:20 ` [PULL 26/26] hvf: arm: Do not advance PC when raising an exception Peter Maydell
2024-07-19  1:26 ` [PULL 00/26] target-arm queue Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240718132028.697927-23-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).