qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Akihiko Odaki <akihiko.odaki@daynix.com>
To: Peter Maydell <peter.maydell@linaro.org>,
	 Thomas Huth <thuth@redhat.com>,
	Laurent Vivier <lvivier@redhat.com>,
	 Paolo Bonzini <pbonzini@redhat.com>,
	Cornelia Huck <cohuck@redhat.com>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, kvm@vger.kernel.org,
	 Akihiko Odaki <akihiko.odaki@daynix.com>
Subject: [PATCH v4 3/6] target/arm: Always add pmu property for Armv7-A/R+
Date: Sat, 20 Jul 2024 18:30:51 +0900	[thread overview]
Message-ID: <20240720-pmu-v4-3-2a2b28f6b08f@daynix.com> (raw)
In-Reply-To: <20240720-pmu-v4-0-2a2b28f6b08f@daynix.com>

kvm-steal-time and sve properties are added for KVM even if the
corresponding features are not available. Always add pmu property for
Armv8. Note that the property is added only for Armv7-A/R+ as QEMU
currently emulates PMU only for such versions, and a different
version may have a different definition of PMU or may not have one at
all.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
 target/arm/cpu.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index 19191c239181..c1955a82fb3c 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -1741,6 +1741,10 @@ void arm_cpu_post_init(Object *obj)
 
     if (!arm_feature(&cpu->env, ARM_FEATURE_M)) {
         qdev_property_add_static(DEVICE(obj), &arm_cpu_reset_hivecs_property);
+
+        if (arm_feature(&cpu->env, ARM_FEATURE_V7)) {
+            object_property_add_bool(obj, "pmu", arm_get_pmu, arm_set_pmu);
+        }
     }
 
     if (arm_feature(&cpu->env, ARM_FEATURE_V8)) {
@@ -1770,7 +1774,6 @@ void arm_cpu_post_init(Object *obj)
 
     if (arm_feature(&cpu->env, ARM_FEATURE_PMU)) {
         cpu->has_pmu = true;
-        object_property_add_bool(obj, "pmu", arm_get_pmu, arm_set_pmu);
     }
 
     /*

-- 
2.45.2



  parent reply	other threads:[~2024-07-20  9:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-20  9:30 [PATCH v4 0/6] target/arm/kvm: Report PMU unavailability Akihiko Odaki
2024-07-20  9:30 ` [PATCH v4 1/6] target/arm/kvm: Set PMU for host only when available Akihiko Odaki
2024-07-20  9:30 ` [PATCH v4 2/6] target/arm/kvm: Do not silently remove PMU Akihiko Odaki
2024-07-20  9:30 ` Akihiko Odaki [this message]
2024-07-29 15:13   ` [PATCH v4 3/6] target/arm: Always add pmu property for Armv7-A/R+ Peter Maydell
2024-07-29 16:32     ` Akihiko Odaki
2024-07-20  9:30 ` [PATCH v4 4/6] hvf: arm: Raise an exception for sysreg by default Akihiko Odaki
2024-07-20  9:30 ` [PATCH v4 5/6] hvf: arm: Properly disable PMU Akihiko Odaki
2024-07-20  9:30 ` [PATCH v4 6/6] hvf: arm: Do not advance PC when raising an exception Akihiko Odaki
2024-08-02  6:41   ` Michael Tokarev
2024-08-02  6:44     ` Akihiko Odaki
2024-08-02  7:32       ` Michael Tokarev
2024-07-29 15:15 ` [PATCH v4 0/6] target/arm/kvm: Report PMU unavailability Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240720-pmu-v4-3-2a2b28f6b08f@daynix.com \
    --to=akihiko.odaki@daynix.com \
    --cc=cohuck@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).