From: Akihiko Odaki <akihiko.odaki@daynix.com>
To: Peter Maydell <peter.maydell@linaro.org>,
Thomas Huth <thuth@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Cornelia Huck <cohuck@redhat.com>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, kvm@vger.kernel.org,
Akihiko Odaki <akihiko.odaki@daynix.com>
Subject: [PATCH v4 6/6] hvf: arm: Do not advance PC when raising an exception
Date: Sat, 20 Jul 2024 18:30:54 +0900 [thread overview]
Message-ID: <20240720-pmu-v4-6-2a2b28f6b08f@daynix.com> (raw)
In-Reply-To: <20240720-pmu-v4-0-2a2b28f6b08f@daynix.com>
This is identical with commit 30a1690f2402 ("hvf: arm: Do not advance
PC when raising an exception") but for writes instead of reads.
Fixes: a2260983c655 ("hvf: arm: Add support for GICv3")
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
target/arm/hvf/hvf.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c
index adcdfae0b17f..c1496ad5be9b 100644
--- a/target/arm/hvf/hvf.c
+++ b/target/arm/hvf/hvf.c
@@ -1586,10 +1586,10 @@ static int hvf_sysreg_write(CPUState *cpu, uint32_t reg, uint64_t val)
case SYSREG_ICC_SGI1R_EL1:
case SYSREG_ICC_SRE_EL1:
/* Call the TCG sysreg handler. This is only safe for GICv3 regs. */
- if (!hvf_sysreg_write_cp(cpu, reg, val)) {
- hvf_raise_exception(cpu, EXCP_UDEF, syn_uncategorized());
+ if (hvf_sysreg_write_cp(cpu, reg, val)) {
+ return 0;
}
- return 0;
+ break;
case SYSREG_MDSCR_EL1:
env->cp15.mdscr_el1 = val;
return 0;
--
2.45.2
next prev parent reply other threads:[~2024-07-20 9:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-20 9:30 [PATCH v4 0/6] target/arm/kvm: Report PMU unavailability Akihiko Odaki
2024-07-20 9:30 ` [PATCH v4 1/6] target/arm/kvm: Set PMU for host only when available Akihiko Odaki
2024-07-20 9:30 ` [PATCH v4 2/6] target/arm/kvm: Do not silently remove PMU Akihiko Odaki
2024-07-20 9:30 ` [PATCH v4 3/6] target/arm: Always add pmu property for Armv7-A/R+ Akihiko Odaki
2024-07-29 15:13 ` Peter Maydell
2024-07-29 16:32 ` Akihiko Odaki
2024-07-20 9:30 ` [PATCH v4 4/6] hvf: arm: Raise an exception for sysreg by default Akihiko Odaki
2024-07-20 9:30 ` [PATCH v4 5/6] hvf: arm: Properly disable PMU Akihiko Odaki
2024-07-20 9:30 ` Akihiko Odaki [this message]
2024-08-02 6:41 ` [PATCH v4 6/6] hvf: arm: Do not advance PC when raising an exception Michael Tokarev
2024-08-02 6:44 ` Akihiko Odaki
2024-08-02 7:32 ` Michael Tokarev
2024-07-29 15:15 ` [PATCH v4 0/6] target/arm/kvm: Report PMU unavailability Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240720-pmu-v4-6-2a2b28f6b08f@daynix.com \
--to=akihiko.odaki@daynix.com \
--cc=cohuck@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).