From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14881C3DA49 for ; Sat, 20 Jul 2024 18:27:27 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sVEmn-0007io-SO; Sat, 20 Jul 2024 14:26:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sVEmm-0007iE-Do for qemu-devel@nongnu.org; Sat, 20 Jul 2024 14:26:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sVEmk-0001KZ-Ca for qemu-devel@nongnu.org; Sat, 20 Jul 2024 14:26:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721499979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=irWO/Dn6J7H6PPrSF9mtaxJKA9fZRKpBRrltB0ruxYY=; b=FFZmNp4hbsLL9ugL0pzbqAOWhgyMNMedbsp2j4GIrDUeONhH6VFI6swkoaLrG3DJPfoVtd dLe1lQ9OhcAL+YI9KwyPJPLpUXBX0l9Jm0QYzZ16ESBOHqhWFaMJ9oTzIA4IL39kq++AOl C3nz/Q4Uoi68pC7fcR4cv678dmklwfQ= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-554-6bs5FbMYNlybPu60kwSLbw-1; Sat, 20 Jul 2024 14:26:17 -0400 X-MC-Unique: 6bs5FbMYNlybPu60kwSLbw-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-426703ac88dso19669145e9.0 for ; Sat, 20 Jul 2024 11:26:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721499976; x=1722104776; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=irWO/Dn6J7H6PPrSF9mtaxJKA9fZRKpBRrltB0ruxYY=; b=Xim8DfiWO+htBZRGfZJIAiuduMhJ9CaJfxFn4KlgGfwoTGa7DvL35LI6Z5rTK8Pyz9 ZAwJ/BKJI+To/CdKE+x/RY9HviJ0QwFOaLGFud7aE0EpGip1GjTtpYuWQBNeieG/3pVd PAEB1vzQznOoz/bzGbc+nWBnWnCzQVO52rSzlWD2OpCCxL9V3tUS+hYqtugUqIpIhQjk ocq7Klx+9eeS/GDYAK/eS3w7QQ+hbh7bgMgPaRwlmVkxNqJObfbIx8A6EpwWRBzjL5jb Ndhw/RCkrncIN+2ylAROLWkzdXw/4HAmq31pdUhXwS8UjeE4IJ2KmNT95OaFhjPwBwMQ /8FQ== X-Gm-Message-State: AOJu0YyAtS1iLQvA9SoMa6A/L3z8R2cbNkydviZ2imKZBklRXwCSIgxo sanMVy0/KXzyIl4At8veApvD2eRNxZ8ntTxe3iwgGaJCiOT2rE3RwHDeUshd2f6BHIhvFQzemCd GpOHmj5mseEq4oOvzXEM+HgoBiaPpL55apc4Rno38JNee0m49iSCe X-Received: by 2002:a05:6000:4026:b0:367:8a3b:2098 with SMTP id ffacd0b85a97d-369bbbb2e21mr1512102f8f.3.1721499975975; Sat, 20 Jul 2024 11:26:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEGR8yq/KrGQ5j9ZdagJnuPkhagL3M/9bP7RCVqxRiYr5c/da2F/3q0KThQx+5t0H/rM0hoaw== X-Received: by 2002:a05:6000:4026:b0:367:8a3b:2098 with SMTP id ffacd0b85a97d-369bbbb2e21mr1512077f8f.3.1721499975240; Sat, 20 Jul 2024 11:26:15 -0700 (PDT) Received: from redhat.com (mob-5-90-113-158.net.vodafone.it. [5.90.113.158]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3687868b29fsm4361559f8f.32.2024.07.20.11.26.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Jul 2024 11:26:14 -0700 (PDT) Date: Sat, 20 Jul 2024 14:26:11 -0400 From: "Michael S. Tsirkin" To: Roy Hopkins Cc: qemu-devel@nongnu.org, Paolo Bonzini , Daniel P =?iso-8859-1?Q?=2E_Berrang=E9?= , Stefano Garzarella , Marcelo Tosatti , Cornelia Huck , Marcel Apfelbaum , Sergio Lopez , Eduardo Habkost , Alistair Francis , Peter Xu , David Hildenbrand , Igor Mammedov , Tom Lendacky , Michael Roth , Ani Sinha , =?iso-8859-1?Q?J=F6rg?= Roedel Subject: Re: [PATCH v4 00/17] Introduce support for IGVM files Message-ID: <20240720142552-mutt-send-email-mst@kernel.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=170.10.133.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Jul 03, 2024 at 12:05:38PM +0100, Roy Hopkins wrote: > Here is v4 of the set of patches to add support for IGVM files to QEMU. This is > based on commit 1a2d52c7fc of qemu. > > This version addresses all of the review comments from v3 along with a couple of > small bug fixes. This is a much smaller increment than in the previous version > of the series [1]. Thanks once again to the reviewers that have been looking at > this series. This v4 patch series is also available on github: [2] > > The previous version had a build issue when building without debug enabled. > Patch 8/17 has been added to fix this and I've updated my own process to test > both debug and release builds of QEMU. > > For testing IGVM support in QEMU you need to generate an IGVM file that is > configured for the platform you want to launch. You can use the `buildigvm` > test tool [3] to allow generation of IGVM files for all currently supported > platforms. Patch 11/17 contains information on how to generate an IGVM file > using this tool. PC things: Acked-by: Michael S. Tsirkin > Changes in v4: > > * Remove unused '#ifdef CONFIG_IGVM' sections > * Add "'if': 'CONFIG_IGVM'" for IgvmCfgProperties in qom.json > * Use error_fatal instead of error_abort in suggested locations > * Prevent addition of bios code when an IGVM file is provided and pci_enabled is false > * Add patch 6/17 to fix error handling from sev_encrypt_flash() > * Revert unrequired changes to return values in sev/*_launch_update() functions > * Add documentation to igvm.rst to describe how to use 'buildigvm' > * Various convention and code style changes as suggested in reviews > * Fix handling of sev_features for kernels that do not support KVM_SEV_INIT2 > * Move igvm-cfg from MachineState to X86MachineState > > Patch summary: > > 1-12: Add support and documentation for processing IGVM files for SEV, SEV-ES, > SEV-SNP and native platforms. > > 13-16: Processing of policy and SEV-SNP ID_BLOCK from IGVM file. > > 17: Add pre-processing of IGVM file to support synchronization of 'SEV_FEATURES' > from IGVM VMSA to KVM. > > [1] Link to v3: > https://lore.kernel.org/qemu-devel/cover.1718979106.git.roy.hopkins@suse.com/ > > [2] v4 patches also available here: > https://github.com/roy-hopkins/qemu/tree/igvm_master_v4 > > [3] `buildigvm` tool v0.2.0 > https://github.com/roy-hopkins/buildigvm/releases/tag/v0.2.0 > > Roy Hopkins (17): > meson: Add optional dependency on IGVM library > backends/confidential-guest-support: Add functions to support IGVM > backends/igvm: Add IGVM loader and configuration > hw/i386: Add igvm-cfg object and processing for IGVM files > i386/pc_sysfw: Ensure sysfw flash configuration does not conflict with > IGVM > sev: Fix error handling in sev_encrypt_flash() > sev: Update launch_update_data functions to use Error handling > target/i386: Allow setting of R_LDTR and R_TR with > cpu_x86_load_seg_cache() > i386/sev: Refactor setting of reset vector and initial CPU state > i386/sev: Implement ConfidentialGuestSupport functions for SEV > docs/system: Add documentation on support for IGVM > docs/interop/firmware.json: Add igvm to FirmwareDevice > backends/confidential-guest-support: Add set_guest_policy() function > backends/igvm: Process initialization sections in IGVM file > backends/igvm: Handle policy for SEV guests > i386/sev: Add implementation of CGS set_guest_policy() > sev: Provide sev_features flags from IGVM VMSA to KVM_SEV_INIT2 > > docs/interop/firmware.json | 9 +- > docs/system/i386/amd-memory-encryption.rst | 2 + > docs/system/igvm.rst | 173 ++++ > docs/system/index.rst | 1 + > meson.build | 8 + > qapi/qom.json | 17 + > backends/igvm.h | 23 + > include/exec/confidential-guest-support.h | 96 +++ > include/hw/i386/x86.h | 3 + > include/sysemu/igvm-cfg.h | 54 ++ > target/i386/cpu.h | 9 +- > target/i386/sev.h | 124 +++ > backends/confidential-guest-support.c | 43 + > backends/igvm-cfg.c | 66 ++ > backends/igvm.c | 958 +++++++++++++++++++++ > hw/i386/pc.c | 12 + > hw/i386/pc_piix.c | 10 + > hw/i386/pc_q35.c | 10 + > hw/i386/pc_sysfw.c | 31 +- > target/i386/sev.c | 844 ++++++++++++++++-- > backends/meson.build | 5 + > meson_options.txt | 2 + > qemu-options.hx | 25 + > scripts/meson-buildoptions.sh | 3 + > 24 files changed, 2447 insertions(+), 81 deletions(-) > create mode 100644 docs/system/igvm.rst > create mode 100644 backends/igvm.h > create mode 100644 include/sysemu/igvm-cfg.h > create mode 100644 backends/igvm-cfg.c > create mode 100644 backends/igvm.c > > -- > 2.43.0