qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>,
	qemu-devel@nongnu.org, lvivier@redhat.com, pbonzini@redhat.com
Subject: Re: [PATCH] tests: increase timeout per instance of bios-tables-test
Date: Mon, 22 Jul 2024 03:47:21 -0400	[thread overview]
Message-ID: <20240722034713-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <b538c18f-1b95-45b3-9aba-d1d92491c750@redhat.com>

On Mon, Jul 22, 2024 at 09:35:17AM +0200, Thomas Huth wrote:
> On 16/07/2024 14.59, Igor Mammedov wrote:
> > CI often fails 'cross-i686-tci' job due to runner slowness
> > Log shows that test almost complete, with a few remaining
> > when bios-tables-test timeout hits:
> > 
> >    19/270 qemu:qtest+qtest-aarch64 / qtest-aarch64/bios-tables-test
> >      TIMEOUT        610.02s   killed by signal 15 SIGTERM
> >    ...
> >    stderr:
> >    TAP parsing error: Too few tests run (expected 8, got 7)
> > 
> > At the same time overall job running time is only ~30 out of 1hr allowed.
> > 
> > Increase bios-tables-test instance timeout on 5min as a fix
> > for slow CI runners.
> > 
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > ---
> >   tests/qtest/meson.build | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Since we're entering the freeze period this week, I'm going to pick up this
> patch for my next pull request in the hope that it will help to get this job
> green again during the freeze period. But in the long run, it would be
> really good if someone familiar with the bios-tables-test could analyze why
> the run time increased so much in recent times for this test and provide a
> better fix for the problem.
> 
>  Thanks,
>   Thomas
> 

OK.
Acked-by: Michael S. Tsirkin <mst@redhat.com>




  reply	other threads:[~2024-07-22  7:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-16 12:59 [PATCH] tests: increase timeout per instance of bios-tables-test Igor Mammedov
2024-07-16 13:06 ` Michael S. Tsirkin
2024-07-16 13:41   ` Peter Maydell
2024-07-16 14:48   ` Igor Mammedov
2024-07-16 17:44   ` Thomas Huth
2024-07-16 19:52     ` Peter Maydell
2024-07-22  7:35 ` Thomas Huth
2024-07-22  7:47   ` Michael S. Tsirkin [this message]
2024-07-22  9:50   ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240722034713-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).