qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Zhenzhong Duan <zhenzhong.duan@intel.com>
To: qemu-devel@nongnu.org
Cc: alex.williamson@redhat.com, clg@redhat.com,
	eric.auger@redhat.com, joao.m.martins@oracle.com,
	chao.p.peng@intel.com, Zhenzhong Duan <zhenzhong.duan@intel.com>,
	Thomas Huth <thuth@redhat.com>,
	Tony Krowiak <akrowiak@linux.ibm.com>,
	Halil Pasic <pasic@linux.ibm.com>,
	Jason Herne <jjherne@linux.ibm.com>,
	qemu-s390x@nongnu.org (open list:S390 general arch...)
Subject: [PATCH 1/2] vfio/ap: Don't initialize HOST_IOMMU_DEVICE with mdev
Date: Mon, 22 Jul 2024 15:07:12 +0800	[thread overview]
Message-ID: <20240722070713.1342711-2-zhenzhong.duan@intel.com> (raw)
In-Reply-To: <20240722070713.1342711-1-zhenzhong.duan@intel.com>

mdevs aren't "physical" devices and when asking for backing IOMMU info,
it fails the entire provisioning of the guest. Fix that by setting
vbasedev->mdev true so skipping HostIOMMUDevice initialization in the
presence of mdevs.

Fixes: 930589520128 ("vfio/iommufd: Implement HostIOMMUDeviceClass::realize() handler")
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
---
 hw/vfio/ap.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
index 0c4354e3e7..391bfb72ca 100644
--- a/hw/vfio/ap.c
+++ b/hw/vfio/ap.c
@@ -230,6 +230,9 @@ static void vfio_ap_instance_init(Object *obj)
      */
     vfio_device_init(vbasedev, VFIO_DEVICE_TYPE_AP, &vfio_ap_ops,
                      DEVICE(vapdev), true);
+
+    /* AP device is mdev type device */
+    vbasedev->mdev = true;
 }
 
 #ifdef CONFIG_IOMMUFD
-- 
2.34.1



  reply	other threads:[~2024-07-22  7:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-22  7:07 [PATCH 0/2] Don't initialize HOST_IOMMU_DEVICE with mdev Zhenzhong Duan
2024-07-22  7:07 ` Zhenzhong Duan [this message]
2024-07-22  9:18   ` [PATCH 1/2] vfio/ap: " Joao Martins
2024-07-22 15:46     ` Anthony Krowiak
2024-07-22 15:52       ` Joao Martins
2024-07-22  7:07 ` [PATCH 2/2] vfio/ccw: " Zhenzhong Duan
2024-07-22  9:18   ` Joao Martins
2024-07-22 14:57   ` Eric Farman
2024-07-22 15:09     ` Joao Martins
2024-07-22 15:36       ` Cédric Le Goater
2024-07-22 17:45         ` Eric Farman
2024-07-23  2:52           ` Duan, Zhenzhong
2024-07-22  9:31 ` [PATCH 0/2] " Eric Auger
2024-07-22 10:02 ` Cédric Le Goater
2024-07-22 13:50 ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240722070713.1342711-2-zhenzhong.duan@intel.com \
    --to=zhenzhong.duan@intel.com \
    --cc=akrowiak@linux.ibm.com \
    --cc=alex.williamson@redhat.com \
    --cc=chao.p.peng@intel.com \
    --cc=clg@redhat.com \
    --cc=eric.auger@redhat.com \
    --cc=jjherne@linux.ibm.com \
    --cc=joao.m.martins@oracle.com \
    --cc=pasic@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).