qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Frédéric Pétrot" <frederic.petrot@univ-grenoble-alpes.fr>,
	"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Alexandre Iooss" <erdnaxe@crans.org>,
	"Mahmoud Mandour" <ma.mandourr@gmail.com>
Subject: [PULL 07/16] plugins/execlog.c: correct dump of registers values
Date: Mon, 22 Jul 2024 12:04:04 +0100	[thread overview]
Message-ID: <20240722110413.118418-8-alex.bennee@linaro.org> (raw)
In-Reply-To: <20240722110413.118418-1-alex.bennee@linaro.org>

From: Frédéric Pétrot <frederic.petrot@univ-grenoble-alpes.fr>

Register values are dumped as 'sz' chunks of two nibbles in the execlog
plugin, sz was 1 too big.

Signed-off-by: Frédéric Pétrot <frederic.petrot@univ-grenoble-alpes.fr>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Message-Id: <20240620083805.73603-1-frederic.petrot@univ-grenoble-alpes.fr>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240718094523.1198645-8-alex.bennee@linaro.org>

diff --git a/contrib/plugins/execlog.c b/contrib/plugins/execlog.c
index 371db97eb1..1c1601cc0b 100644
--- a/contrib/plugins/execlog.c
+++ b/contrib/plugins/execlog.c
@@ -101,7 +101,7 @@ static void insn_check_regs(CPU *cpu)
             GByteArray *temp = reg->last;
             g_string_append_printf(cpu->last_exec, ", %s -> 0x", reg->name);
             /* TODO: handle BE properly */
-            for (int i = sz; i >= 0; i--) {
+            for (int i = sz - 1; i >= 0; i--) {
                 g_string_append_printf(cpu->last_exec, "%02x",
                                        reg->new->data[i]);
             }
-- 
2.39.2



  parent reply	other threads:[~2024-07-22 11:05 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-22 11:03 [PULL 00/16] Final bits for 9.1-rc0 (docker, plugins, gdbstub, semihosting) Alex Bennée
2024-07-22 11:03 ` [PULL 01/16] testing: bump to latest libvirt-ci Alex Bennée
2024-07-22 11:03 ` [PULL 02/16] tests/avocado: Remove non-working sparc leon3 test Alex Bennée
2024-07-22 11:04 ` [PULL 03/16] gdbstub: Re-factor gdb command extensions Alex Bennée
2024-07-22 11:04 ` [PULL 04/16] plugins/stoptrigger: TCG plugin to stop execution under conditions Alex Bennée
2024-07-22 11:04 ` [PULL 05/16] plugins: fix mem callback array size Alex Bennée
2024-07-22 11:04 ` [PULL 06/16] tests/plugins: use qemu_plugin_outs for inline stats Alex Bennée
2024-07-22 11:04 ` Alex Bennée [this message]
2024-07-22 11:04 ` [PULL 08/16] semihosting: Include missing 'gdbstub/syscalls.h' header Alex Bennée
2024-07-22 11:04 ` [PULL 09/16] target/m68k: Add semihosting stub Alex Bennée
2024-07-22 11:04 ` [PULL 10/16] target/mips: " Alex Bennée
2024-07-22 11:04 ` [PULL 11/16] target/m68k: Restrict semihosting to TCG Alex Bennée
2024-07-22 11:04 ` [PULL 12/16] target/mips: " Alex Bennée
2024-07-22 11:04 ` [PULL 13/16] target/riscv: " Alex Bennée
2024-09-05 17:08   ` Thomas Huth
2024-09-06  8:20     ` Thomas Huth
2024-07-22 11:04 ` [PULL 14/16] target/xtensa: " Alex Bennée
2024-07-22 11:04 ` [PULL 15/16] semihosting: Restrict " Alex Bennée
2024-07-22 11:04 ` [PULL 16/16] tests/tcg/aarch64: Fix test-mte.py Alex Bennée
2024-07-22 21:07 ` [PULL 00/16] Final bits for 9.1-rc0 (docker, plugins, gdbstub, semihosting) Philippe Mathieu-Daudé
2024-07-22 21:09   ` Philippe Mathieu-Daudé
2024-07-22 23:00     ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240722110413.118418-8-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=erdnaxe@crans.org \
    --cc=frederic.petrot@univ-grenoble-alpes.fr \
    --cc=ma.mandourr@gmail.com \
    --cc=pierrick.bouvier@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).