qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: [PULL 10/12] qtest/fuzz: make range overlap check more readable
Date: Mon, 22 Jul 2024 14:00:24 +0200	[thread overview]
Message-ID: <20240722120026.675449-11-thuth@redhat.com> (raw)
In-Reply-To: <20240722120026.675449-1-thuth@redhat.com>

From: Yao Xingtao <yaoxt.fnst@fujitsu.com>

use ranges_overlap() instead of open-coding the overlap check to improve
the readability of the code.

Signed-off-by: Yao Xingtao <yaoxt.fnst@fujitsu.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Alexander Bulekov <alxndr@bu.edu>
Message-ID: <20240722040742.11513-8-yaoxt.fnst@fujitsu.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/qtest/fuzz/generic_fuzz.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/qtest/fuzz/generic_fuzz.c b/tests/qtest/fuzz/generic_fuzz.c
index ec842e03c5..d107a496da 100644
--- a/tests/qtest/fuzz/generic_fuzz.c
+++ b/tests/qtest/fuzz/generic_fuzz.c
@@ -11,6 +11,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/range.h"
 
 #include <wordexp.h>
 
@@ -211,7 +212,7 @@ void fuzz_dma_read_cb(size_t addr, size_t len, MemoryRegion *mr)
          i < dma_regions->len && (avoid_double_fetches || qtest_log_enabled);
          ++i) {
         region = g_array_index(dma_regions, address_range, i);
-        if (addr < region.addr + region.size && addr + len > region.addr) {
+        if (ranges_overlap(addr, len, region.addr, region.size)) {
             double_fetch = true;
             if (addr < region.addr
                 && avoid_double_fetches) {
-- 
2.45.2



  parent reply	other threads:[~2024-07-22 12:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-22 12:00 [PULL 00/12] QTests, Avocado and s390x fixes for 9.1 softfreeze Thomas Huth
2024-07-22 12:00 ` [PULL 01/12] tests/avocado/boot_xen.py: merge base classes Thomas Huth
2024-07-22 12:00 ` [PULL 02/12] tests/avocado/boot_xen.py: unify tags Thomas Huth
2024-07-22 12:00 ` [PULL 03/12] tests/avocado/boot_xen.py: use class attribute Thomas Huth
2024-07-22 12:00 ` [PULL 04/12] tests/avocado: Allow overwriting AVOCADO_SHOW env variable Thomas Huth
2024-07-22 12:00 ` [PULL 05/12] tests/avocado: Move LinuxTest related code into a separate file Thomas Huth
2024-07-22 12:00 ` [PULL 06/12] tests/avocado/mem-addr-space-check: Remove unused "import signal" Thomas Huth
2024-07-22 12:00 ` [PULL 07/12] tests/avocado: Remove the remainders of the virtiofs_submounts test Thomas Huth
2024-07-22 12:00 ` [PULL 08/12] tests/avocado/machine_aspeed.py: Increase timeout for TPM test Thomas Huth
2024-07-22 12:00 ` [PULL 09/12] hw: Fix crash that happens when introspecting scsi-block on older machine types Thomas Huth
2024-07-22 12:00 ` Thomas Huth [this message]
2024-07-22 12:00 ` [PULL 11/12] tests: increase timeout per instance of bios-tables-test Thomas Huth
2024-07-22 12:00 ` [PULL 12/12] target/s390x: filter deprecated properties based on model expansion type Thomas Huth
2024-07-23  2:14 ` [PULL 00/12] QTests, Avocado and s390x fixes for 9.1 softfreeze Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240722120026.675449-11-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).