qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: [PULL 01/12] tests/avocado/boot_xen.py: merge base classes
Date: Mon, 22 Jul 2024 14:00:15 +0200	[thread overview]
Message-ID: <20240722120026.675449-2-thuth@redhat.com> (raw)
In-Reply-To: <20240722120026.675449-1-thuth@redhat.com>

From: Cleber Rosa <crosa@redhat.com>

While it's a good practice to have reusable base classes, in this
specific case there's no other user of the BootXenBase class.

By unifying the class used in this test, we can improve readability
and have the opportunity to add some future improvements in a clearer
fashion.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
Message-ID: <20231208190911.102879-9-crosa@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/avocado/boot_xen.py | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/tests/avocado/boot_xen.py b/tests/avocado/boot_xen.py
index fc2faeedb5..f80cbcb8fb 100644
--- a/tests/avocado/boot_xen.py
+++ b/tests/avocado/boot_xen.py
@@ -17,7 +17,7 @@
 from boot_linux_console import LinuxKernelTest
 
 
-class BootXenBase(LinuxKernelTest):
+class BootXen(LinuxKernelTest):
     """
     Boots a Xen hypervisor with a Linux DomU kernel.
     """
@@ -59,9 +59,6 @@ def launch_xen(self, xen_path):
         console_pattern = 'VFS: Cannot open root device'
         wait_for_console_pattern(self, console_pattern, "Panic on CPU 0:")
 
-
-class BootXen(BootXenBase):
-
     def test_arm64_xen_411_and_dom0(self):
         """
         :avocado: tags=arch:aarch64
-- 
2.45.2



  reply	other threads:[~2024-07-22 12:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-22 12:00 [PULL 00/12] QTests, Avocado and s390x fixes for 9.1 softfreeze Thomas Huth
2024-07-22 12:00 ` Thomas Huth [this message]
2024-07-22 12:00 ` [PULL 02/12] tests/avocado/boot_xen.py: unify tags Thomas Huth
2024-07-22 12:00 ` [PULL 03/12] tests/avocado/boot_xen.py: use class attribute Thomas Huth
2024-07-22 12:00 ` [PULL 04/12] tests/avocado: Allow overwriting AVOCADO_SHOW env variable Thomas Huth
2024-07-22 12:00 ` [PULL 05/12] tests/avocado: Move LinuxTest related code into a separate file Thomas Huth
2024-07-22 12:00 ` [PULL 06/12] tests/avocado/mem-addr-space-check: Remove unused "import signal" Thomas Huth
2024-07-22 12:00 ` [PULL 07/12] tests/avocado: Remove the remainders of the virtiofs_submounts test Thomas Huth
2024-07-22 12:00 ` [PULL 08/12] tests/avocado/machine_aspeed.py: Increase timeout for TPM test Thomas Huth
2024-07-22 12:00 ` [PULL 09/12] hw: Fix crash that happens when introspecting scsi-block on older machine types Thomas Huth
2024-07-22 12:00 ` [PULL 10/12] qtest/fuzz: make range overlap check more readable Thomas Huth
2024-07-22 12:00 ` [PULL 11/12] tests: increase timeout per instance of bios-tables-test Thomas Huth
2024-07-22 12:00 ` [PULL 12/12] target/s390x: filter deprecated properties based on model expansion type Thomas Huth
2024-07-23  2:14 ` [PULL 00/12] QTests, Avocado and s390x fixes for 9.1 softfreeze Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240722120026.675449-2-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).