qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: [PULL 03/12] tests/avocado/boot_xen.py: use class attribute
Date: Mon, 22 Jul 2024 14:00:17 +0200	[thread overview]
Message-ID: <20240722120026.675449-4-thuth@redhat.com> (raw)
In-Reply-To: <20240722120026.675449-1-thuth@redhat.com>

From: Cleber Rosa <crosa@redhat.com>

Rather than defining a single use variable, let's just use the class
attribute directly.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20231208190911.102879-11-crosa@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/avocado/boot_xen.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/avocado/boot_xen.py b/tests/avocado/boot_xen.py
index f4b63c1ef2..f29bc58b9e 100644
--- a/tests/avocado/boot_xen.py
+++ b/tests/avocado/boot_xen.py
@@ -50,11 +50,10 @@ def launch_xen(self, xen_path):
 
         self.vm.set_console()
 
-        xen_command_line = self.XEN_COMMON_COMMAND_LINE
         self.vm.add_args('-machine', 'virtualization=on',
                          '-m', '768',
                          '-kernel', xen_path,
-                         '-append', xen_command_line,
+                         '-append', self.XEN_COMMON_COMMAND_LINE,
                          '-device',
                          'guest-loader,addr=0x47000000,kernel=%s,bootargs=console=hvc0'
                          % (kernel_path))
-- 
2.45.2



  parent reply	other threads:[~2024-07-22 12:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-22 12:00 [PULL 00/12] QTests, Avocado and s390x fixes for 9.1 softfreeze Thomas Huth
2024-07-22 12:00 ` [PULL 01/12] tests/avocado/boot_xen.py: merge base classes Thomas Huth
2024-07-22 12:00 ` [PULL 02/12] tests/avocado/boot_xen.py: unify tags Thomas Huth
2024-07-22 12:00 ` Thomas Huth [this message]
2024-07-22 12:00 ` [PULL 04/12] tests/avocado: Allow overwriting AVOCADO_SHOW env variable Thomas Huth
2024-07-22 12:00 ` [PULL 05/12] tests/avocado: Move LinuxTest related code into a separate file Thomas Huth
2024-07-22 12:00 ` [PULL 06/12] tests/avocado/mem-addr-space-check: Remove unused "import signal" Thomas Huth
2024-07-22 12:00 ` [PULL 07/12] tests/avocado: Remove the remainders of the virtiofs_submounts test Thomas Huth
2024-07-22 12:00 ` [PULL 08/12] tests/avocado/machine_aspeed.py: Increase timeout for TPM test Thomas Huth
2024-07-22 12:00 ` [PULL 09/12] hw: Fix crash that happens when introspecting scsi-block on older machine types Thomas Huth
2024-07-22 12:00 ` [PULL 10/12] qtest/fuzz: make range overlap check more readable Thomas Huth
2024-07-22 12:00 ` [PULL 11/12] tests: increase timeout per instance of bios-tables-test Thomas Huth
2024-07-22 12:00 ` [PULL 12/12] target/s390x: filter deprecated properties based on model expansion type Thomas Huth
2024-07-23  2:14 ` [PULL 00/12] QTests, Avocado and s390x fixes for 9.1 softfreeze Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240722120026.675449-4-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).