qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Michael Roth" <michael.roth@amd.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [PATCH 3/5] crypto: drop gnutls debug logging support
Date: Mon, 22 Jul 2024 14:16:09 +0100	[thread overview]
Message-ID: <20240722131611.2820041-4-berrange@redhat.com> (raw)
In-Reply-To: <20240722131611.2820041-1-berrange@redhat.com>

GNUTLS already supports dynamically enabling its logging at runtime by
setting the env var 'GNUTLS_DEBUG_LEVEL=10', so there is no need to
re-invent this logic in QEMU in a way that requires a re-compile.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 crypto/init.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/crypto/init.c b/crypto/init.c
index fb7f1bff10..2d6dfa3091 100644
--- a/crypto/init.c
+++ b/crypto/init.c
@@ -34,13 +34,6 @@
 
 #include "crypto/random.h"
 
-/* #define DEBUG_GNUTLS */
-#ifdef DEBUG_GNUTLS
-static void qcrypto_gnutls_log(int level, const char *str)
-{
-    fprintf(stderr, "%d: %s", level, str);
-}
-#endif
 
 int qcrypto_init(Error **errp)
 {
@@ -53,10 +46,6 @@ int qcrypto_init(Error **errp)
                    gnutls_strerror(ret));
         return -1;
     }
-#ifdef DEBUG_GNUTLS
-    gnutls_global_set_log_level(10);
-    gnutls_global_set_log_function(qcrypto_gnutls_log);
-#endif
 #endif
 
 #ifdef CONFIG_GCRYPT
-- 
2.45.2



  parent reply	other threads:[~2024-07-22 13:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-22 13:16 [PATCH 0/5] crypto: improve error reporting detail Daniel P. Berrangé
2024-07-22 13:16 ` [PATCH 1/5] qapi: allow for g_autoptr(Error) usage Daniel P. Berrangé
2024-07-22 14:31   ` Philippe Mathieu-Daudé
2024-07-23 11:36   ` Markus Armbruster
2024-07-23 13:06     ` Daniel P. Berrangé
2024-07-24  8:17       ` Markus Armbruster
2024-07-22 13:16 ` [PATCH 2/5] chardev: add tracing of socket error conditions Daniel P. Berrangé
2024-07-22 14:31   ` Philippe Mathieu-Daudé
2024-07-22 13:16 ` Daniel P. Berrangé [this message]
2024-07-22 14:32   ` [PATCH 3/5] crypto: drop gnutls debug logging support Philippe Mathieu-Daudé
2024-07-22 15:03     ` Daniel P. Berrangé
2024-07-22 13:16 ` [PATCH 4/5] crypto: push error reporting into TLS session I/O APIs Daniel P. Berrangé
2024-07-22 14:37   ` Philippe Mathieu-Daudé
2024-07-22 13:16 ` [PATCH 5/5] crypto: propagate errors from TLS session I/O callbacks Daniel P. Berrangé
2024-07-22 14:35   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240722131611.2820041-4-berrange@redhat.com \
    --to=berrange@redhat.com \
    --cc=armbru@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=michael.roth@amd.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).