* [PATCH] meson: build chardev trace files when have_block
@ 2024-07-23 10:35 Daniel P. Berrangé
2024-07-23 12:39 ` Marc-André Lureau
0 siblings, 1 reply; 2+ messages in thread
From: Daniel P. Berrangé @ 2024-07-23 10:35 UTC (permalink / raw)
To: qemu-devel
Cc: Thomas Huth, Daniel P. Berrangé, Paolo Bonzini,
Philippe Mathieu-Daudé, Marc-André Lureau
The QSD depends on chardev code, and is built when have_tools is
true. This means conditionalizing chardev trace on have_system
is wrong, we need have_block which is set have_system || have_tools.
This latent bug was historically harmless because only the spice
chardev included tracing, which wasn't built in a !have_system
scenario.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
This is an add-on needed for:
https://lists.nongnu.org/archive/html/qemu-devel/2024-07/msg05068.html
since I discovered a tools-only build fails
diff --git a/meson.build b/meson.build
index a1e51277b0..d3850a8c0f 100644
--- a/meson.build
+++ b/meson.build
@@ -3327,6 +3327,7 @@ if have_block
trace_events_subdirs += [
'authz',
'block',
+ 'chardev',
'io',
'nbd',
'scsi',
@@ -3338,7 +3339,6 @@ if have_system
'audio',
'backends',
'backends/tpm',
- 'chardev',
'ebpf',
'hw/9pfs',
'hw/acpi',
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] meson: build chardev trace files when have_block
2024-07-23 10:35 [PATCH] meson: build chardev trace files when have_block Daniel P. Berrangé
@ 2024-07-23 12:39 ` Marc-André Lureau
0 siblings, 0 replies; 2+ messages in thread
From: Marc-André Lureau @ 2024-07-23 12:39 UTC (permalink / raw)
To: Daniel P. Berrangé
Cc: qemu-devel, Thomas Huth, Paolo Bonzini,
Philippe Mathieu-Daudé
[-- Attachment #1: Type: text/plain, Size: 1314 bytes --]
On Tue, Jul 23, 2024 at 2:35 PM Daniel P. Berrangé <berrange@redhat.com>
wrote:
> The QSD depends on chardev code, and is built when have_tools is
> true. This means conditionalizing chardev trace on have_system
> is wrong, we need have_block which is set have_system || have_tools.
>
> This latent bug was historically harmless because only the spice
> chardev included tracing, which wasn't built in a !have_system
> scenario.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> This is an add-on needed for:
>
> https://lists.nongnu.org/archive/html/qemu-devel/2024-07/msg05068.html
>
> since I discovered a tools-only build fails
>
> diff --git a/meson.build b/meson.build
> index a1e51277b0..d3850a8c0f 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -3327,6 +3327,7 @@ if have_block
> trace_events_subdirs += [
> 'authz',
> 'block',
> + 'chardev',
> 'io',
> 'nbd',
> 'scsi',
> @@ -3338,7 +3339,6 @@ if have_system
> 'audio',
> 'backends',
> 'backends/tpm',
> - 'chardev',
> 'ebpf',
> 'hw/9pfs',
> 'hw/acpi',
> --
> 2.45.2
>
>
[-- Attachment #2: Type: text/html, Size: 2258 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-23 12:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-23 10:35 [PATCH] meson: build chardev trace files when have_block Daniel P. Berrangé
2024-07-23 12:39 ` Marc-André Lureau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).