From: Salil Mehta via <qemu-devel@nongnu.org>
To: <qemu-devel@nongnu.org>, <qemu-arm@nongnu.org>, <mst@redhat.com>,
<peter.maydell@linaro.org>
Cc: <salil.mehta@huawei.com>, <maz@kernel.org>,
<jean-philippe@linaro.org>, <jonathan.cameron@huawei.com>,
<lpieralisi@kernel.org>, <richard.henderson@linaro.org>,
<imammedo@redhat.com>, <andrew.jones@linux.dev>,
<david@redhat.com>, <philmd@linaro.org>, <eric.auger@redhat.com>,
<oliver.upton@linux.dev>, <pbonzini@redhat.com>,
<will@kernel.org>, <gshan@redhat.com>, <rafael@kernel.org>,
<alex.bennee@linaro.org>, <linux@armlinux.org.uk>,
<darren@os.amperecomputing.com>, <ilkka@os.amperecomputing.com>,
<vishnu@os.amperecomputing.com>, <karl.heubaum@oracle.com>,
<miguel.luis@oracle.com>, <salil.mehta@opnsrc.net>,
<zhukeqian1@huawei.com>, <wangxiongfeng2@huawei.com>,
<wangyanan55@huawei.com>, <jiakernel2@gmail.com>,
<maobibo@loongson.cn>, <lixianglai@loongson.cn>,
<npiggin@gmail.com>, <harshpb@linux.ibm.com>,
<linuxarm@huawei.com>
Subject: [PATCH] accel/kvm/kvm-all: Fixes the missing break in vCPU unpark logic
Date: Thu, 25 Jul 2024 15:51:32 +0100 [thread overview]
Message-ID: <20240725145132.99355-1-salil.mehta@huawei.com> (raw)
Loop should exit prematurely on successfully finding out the parked vCPU (struct
KVMParkedVcpu) in the 'struct KVMState' maintained 'kvm_parked_vcpus' list of
parked vCPUs.
Fixes: Coverity CID 1558552
Fixes: 08c3286822 ("accel/kvm: Extract common KVM vCPU {creation,parking} code")
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Message-ID: <CAFEAcA-3_d1c7XSXWkFubD-LsW5c5i95e6xxV09r2C9yGtzcdA@mail.gmail.com>
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
---
accel/kvm/kvm-all.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index 0aa4b4624a..c181297f00 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -362,6 +362,7 @@ int kvm_unpark_vcpu(KVMState *s, unsigned long vcpu_id)
QLIST_REMOVE(cpu, node);
kvm_fd = cpu->kvm_fd;
g_free(cpu);
+ break;
}
}
--
2.34.1
next reply other threads:[~2024-07-25 14:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-25 14:51 Salil Mehta via [this message]
2024-07-25 19:57 ` [PATCH] accel/kvm/kvm-all: Fixes the missing break in vCPU unpark logic Philippe Mathieu-Daudé
2024-07-26 0:27 ` Gavin Shan
2024-07-26 8:47 ` Zhao Liu
2024-07-26 9:33 ` Igor Mammedov
2024-07-31 8:48 ` Salil Mehta via
2024-07-31 11:39 ` Peter Maydell
2024-07-31 12:32 ` Salil Mehta via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240725145132.99355-1-salil.mehta@huawei.com \
--to=qemu-devel@nongnu.org \
--cc=alex.bennee@linaro.org \
--cc=andrew.jones@linux.dev \
--cc=darren@os.amperecomputing.com \
--cc=david@redhat.com \
--cc=eric.auger@redhat.com \
--cc=gshan@redhat.com \
--cc=harshpb@linux.ibm.com \
--cc=ilkka@os.amperecomputing.com \
--cc=imammedo@redhat.com \
--cc=jean-philippe@linaro.org \
--cc=jiakernel2@gmail.com \
--cc=jonathan.cameron@huawei.com \
--cc=karl.heubaum@oracle.com \
--cc=linux@armlinux.org.uk \
--cc=linuxarm@huawei.com \
--cc=lixianglai@loongson.cn \
--cc=lpieralisi@kernel.org \
--cc=maobibo@loongson.cn \
--cc=maz@kernel.org \
--cc=miguel.luis@oracle.com \
--cc=mst@redhat.com \
--cc=npiggin@gmail.com \
--cc=oliver.upton@linux.dev \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=rafael@kernel.org \
--cc=richard.henderson@linaro.org \
--cc=salil.mehta@huawei.com \
--cc=salil.mehta@opnsrc.net \
--cc=vishnu@os.amperecomputing.com \
--cc=wangxiongfeng2@huawei.com \
--cc=wangyanan55@huawei.com \
--cc=will@kernel.org \
--cc=zhukeqian1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).