qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Eduardo Habkost" <eduardo@habkost.net>,
	"Thomas Huth" <thuth@redhat.com>,
	"Beraldo Leal" <bleal@redhat.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Bin Meng" <bmeng.cn@gmail.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	qemu-riscv@nongnu.org, "Weiwei Li" <liwei1518@gmail.com>,
	"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Liu Zhiwei" <zhiwei_liu@linux.alibaba.com>,
	"Daniel Henrique Barboza" <dbarboza@ventanamicro.com>,
	qemu-s390x@nongnu.org, "Cleber Rosa" <crosa@redhat.com>,
	"Ilya Leoshkevich" <iii@linux.ibm.com>,
	"Mahmoud Mandour" <ma.mandourr@gmail.com>,
	qemu-arm@nongnu.org, "Alexandre Iooss" <erdnaxe@crans.org>,
	"Song Gao" <gaosong@loongson.cn>,
	"David Hildenbrand" <david@redhat.com>,
	"Alistair Francis" <alistair.francis@wdc.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>
Subject: [PATCH 13/14] contrib/plugins: add compat for g_memdup2
Date: Mon, 29 Jul 2024 15:44:13 +0100	[thread overview]
Message-ID: <20240729144414.830369-14-alex.bennee@linaro.org> (raw)
In-Reply-To: <20240729144414.830369-1-alex.bennee@linaro.org>

We were premature if bumping this because some of our builds are still
on older glibs. Just copy the compat handler for now and we can remove
it later.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Fixes: ee293103b0 (plugins: update lockstep to use g_memdup2)
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2161
---
 contrib/plugins/lockstep.c | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
index 6a7e9bbb39..62981d4e09 100644
--- a/contrib/plugins/lockstep.c
+++ b/contrib/plugins/lockstep.c
@@ -101,6 +101,31 @@ static void plugin_exit(qemu_plugin_id_t id, void *p)
     plugin_cleanup(id);
 }
 
+/*
+ * g_memdup has been deprecated in Glib since 2.68 and
+ * will complain about it if you try to use it. However until
+ * glib_req_ver for QEMU is bumped we make a copy of the glib-compat
+ * handler.
+ */
+static inline gpointer g_memdup2_qemu(gconstpointer mem, gsize byte_size)
+{
+#if GLIB_CHECK_VERSION(2, 68, 0)
+    return g_memdup2(mem, byte_size);
+#else
+    gpointer new_mem;
+
+    if (mem && byte_size != 0) {
+        new_mem = g_malloc(byte_size);
+        memcpy(new_mem, mem, byte_size);
+    } else {
+        new_mem = NULL;
+    }
+
+    return new_mem;
+#endif
+}
+#define g_memdup2(m, s) g_memdup2_qemu(m, s)
+
 static void report_divergance(ExecState *us, ExecState *them)
 {
     DivergeState divrec = { log, 0 };
-- 
2.39.2



  parent reply	other threads:[~2024-07-29 14:46 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-29 14:44 [PATCH 00/14] Various fixes and tweaks for 9.1-rc0/1 Alex Bennée
2024-07-29 14:44 ` [PATCH 01/14] gitlab: record installed packages in /packages.txt in containers Alex Bennée
2024-07-29 22:21   ` Richard Henderson
2024-07-29 14:44 ` [PATCH 02/14] gitlab: display /packages.txt in build jobs Alex Bennée
2024-07-29 22:22   ` Richard Henderson
2024-07-29 14:44 ` [PATCH 03/14] tests/tcg: Use --noexecstack with assembler files Alex Bennée
2024-07-29 14:44 ` [PATCH 04/14] tests/tcg/loongarch64: Use --no-warn-rwx-segments to link system tests Alex Bennée
2024-07-29 14:44 ` [PATCH 05/14] tests/tcg: update README Alex Bennée
2024-07-29 22:23   ` Richard Henderson
2024-07-29 14:44 ` [PATCH 06/14] docs/devel: update the testing introduction Alex Bennée
2024-07-29 22:24   ` Richard Henderson
2024-07-29 14:44 ` [PATCH 07/14] docs/devel: document how to run individual TCG tests Alex Bennée
2024-07-29 22:25   ` Richard Henderson
2024-07-29 14:44 ` [PATCH 08/14] tests/avocado: remove tcg_plugins virt_mem_icount test Alex Bennée
2024-07-29 22:26   ` Richard Henderson
2024-08-12  6:25   ` Thomas Huth
2024-07-29 14:44 ` [PATCH 09/14] tests/tcg: move test plugins into tcg subdir Alex Bennée
2024-07-29 15:15   ` Philippe Mathieu-Daudé
2024-07-29 22:27   ` Richard Henderson
2024-07-29 14:44 ` [PATCH 10/14] docs: split TCG plugin usage from devel section Alex Bennée
2024-07-29 22:29   ` Richard Henderson
2024-07-29 14:44 ` [PATCH 11/14] contrib/plugins/cache.c: Remove redundant check of l2_access Alex Bennée
2024-07-29 22:30   ` Richard Henderson
2024-07-29 14:44 ` [PATCH 12/14] contrib/plugins: be more vocal building Alex Bennée
2024-07-29 14:44 ` Alex Bennée [this message]
2024-07-29 15:16   ` [PATCH 13/14] contrib/plugins: add compat for g_memdup2 Philippe Mathieu-Daudé
2024-07-29 14:44 ` [PATCH 14/14] plugin/loader: handle basic help query Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240729144414.830369-14-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=alistair.francis@wdc.com \
    --cc=bleal@redhat.com \
    --cc=bmeng.cn@gmail.com \
    --cc=crosa@redhat.com \
    --cc=david@redhat.com \
    --cc=dbarboza@ventanamicro.com \
    --cc=eduardo@habkost.net \
    --cc=erdnaxe@crans.org \
    --cc=gaosong@loongson.cn \
    --cc=iii@linux.ibm.com \
    --cc=liwei1518@gmail.com \
    --cc=ma.mandourr@gmail.com \
    --cc=palmer@dabbelt.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=pierrick.bouvier@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    --cc=zhiwei_liu@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).