qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
	"Alexandre Iooss" <erdnaxe@crans.org>,
	"Mahmoud Mandour" <ma.mandourr@gmail.com>,
	"Pierrick Bouvier" <pierrick.bouvier@linaro.org>
Subject: [PULL 14/14] plugin/loader: handle basic help query
Date: Tue, 30 Jul 2024 17:22:37 +0100	[thread overview]
Message-ID: <20240730162237.1425515-15-alex.bennee@linaro.org> (raw)
In-Reply-To: <20240730162237.1425515-1-alex.bennee@linaro.org>

As the list of options isn't fixed we do all the parsing by hand.
Without any named arguments we automatically fill the "file" option
with the value give so check if it is requesting help and dump some
basic usage text.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240729144414.830369-15-alex.bennee@linaro.org>

diff --git a/plugins/loader.c b/plugins/loader.c
index 513a429c57..ebc01da9c6 100644
--- a/plugins/loader.c
+++ b/plugins/loader.c
@@ -18,6 +18,7 @@
 #include "qemu/osdep.h"
 #include "qemu/error-report.h"
 #include "qemu/config-file.h"
+#include "qemu/help_option.h"
 #include "qapi/error.h"
 #include "qemu/lockable.h"
 #include "qemu/option.h"
@@ -98,7 +99,12 @@ static int plugin_add(void *opaque, const char *name, const char *value,
     bool is_on;
     char *fullarg;
 
-    if (strcmp(name, "file") == 0) {
+    if (is_help_option(value)) {
+        printf("Plugin options\n");
+        printf("  file=<path/to/plugin.so>\n");
+        printf("  plugin specific arguments\n");
+        exit(0);
+    } else if (strcmp(name, "file") == 0) {
         if (strcmp(value, "") == 0) {
             error_setg(errp, "requires a non-empty argument");
             return 1;
-- 
2.39.2



  parent reply	other threads:[~2024-07-30 16:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-30 16:22 [PULL for 9.1-rc1 00/14] Minor bug fixes and documentation cleanups Alex Bennée
2024-07-30 16:22 ` [PULL 01/14] gitlab: record installed packages in /packages.txt in containers Alex Bennée
2024-07-30 16:22 ` [PULL 02/14] gitlab: display /packages.txt in build jobs Alex Bennée
2024-07-30 16:22 ` [PULL 03/14] tests/tcg: Use --noexecstack with assembler files Alex Bennée
2024-07-30 16:22 ` [PULL 04/14] tests/tcg/loongarch64: Use --no-warn-rwx-segments to link system tests Alex Bennée
2024-07-30 16:22 ` [PULL 05/14] tests/tcg: update README Alex Bennée
2024-07-30 16:22 ` [PULL 06/14] docs/devel: update the testing introduction Alex Bennée
2024-07-30 16:22 ` [PULL 07/14] docs/devel: document how to run individual TCG tests Alex Bennée
2024-07-30 16:22 ` [PULL 08/14] tests/avocado: remove tcg_plugins virt_mem_icount test Alex Bennée
2024-07-30 16:22 ` [PULL 09/14] tests/tcg: move test plugins into tcg subdir Alex Bennée
2024-07-30 16:22 ` [PULL 10/14] docs: split TCG plugin usage from devel section Alex Bennée
2024-07-30 16:22 ` [PULL 11/14] contrib/plugins/cache.c: Remove redundant check of l2_access Alex Bennée
2024-07-30 16:22 ` [PULL 12/14] contrib/plugins: be more vocal building Alex Bennée
2024-07-30 16:22 ` [PULL 13/14] contrib/plugins: add compat for g_memdup2 Alex Bennée
2024-07-30 16:22 ` Alex Bennée [this message]
2024-07-31  6:17 ` [PULL for 9.1-rc1 00/14] Minor bug fixes and documentation cleanups Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240730162237.1425515-15-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=erdnaxe@crans.org \
    --cc=ma.mandourr@gmail.com \
    --cc=pierrick.bouvier@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).