From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: qemu-devel@nongnu.org, Igor Mammedov <imammedo@redhat.com>,
Ani Sinha <anisinha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Eduardo Habkost <eduardo@habkost.net>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Peter Hilber <peter.hilber@opensynergy.com>,
"Mohamed Abuelfotoh, Hazem" <abuehaze@amazon.com>
Subject: Re: [PATCH v2] hw/acpi: Add vmclock device
Date: Tue, 30 Jul 2024 16:45:53 -0400 [thread overview]
Message-ID: <20240730164434-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <546A904C-FEEB-4365-B7AA-CA4E3D03300C@infradead.org>
On Tue, Jul 30, 2024 at 08:04:17PM +0100, David Woodhouse wrote:
> On 30 July 2024 18:53:18 BST, "Michael S. Tsirkin" <mst@redhat.com> wrote:
> >We don't want to manually sync headers with Linux.
>
> Indeed. I was briefly tempted to fake it, but figured it might get lost if we subsequently do run the script to automatically merge from Linux, before the guest driver is merged there.
>
> >I think Linux abi should live under uapi. When it is there, we can use
> >./scripts/update-linux-headers.sh machinery to import it.
>
> This isn't just Linux ABI. It's intended as hypervisor to guest ABI too. In the fullness of time I'm hoping it'll actually be a virtio header. In the meantime, best not to overthink it. It's fine in hw/acpi alongside the device itself for now, I think.
This is exactly the same as e.g. virtio. We use Linux as a source of truth, it's
easier to share with other hypervisors this way. And UAPI and hypervisor
ABI requirements wrt stability are mostly the same. It works.
--
MST
next prev parent reply other threads:[~2024-07-30 20:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 16:33 [PATCH v2] hw/acpi: Add vmclock device David Woodhouse
2024-07-30 17:53 ` Michael S. Tsirkin
2024-07-30 19:04 ` David Woodhouse
2024-07-30 20:45 ` Michael S. Tsirkin [this message]
2024-07-31 0:23 ` David Woodhouse
2024-07-31 21:19 ` Michael S. Tsirkin
2024-08-01 8:49 ` David Woodhouse
2024-08-01 9:48 ` Michael S. Tsirkin
2024-08-01 10:00 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240730164434-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=abuehaze@amazon.com \
--cc=anisinha@redhat.com \
--cc=dwmw2@infradead.org \
--cc=eduardo@habkost.net \
--cc=imammedo@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.hilber@opensynergy.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).