From: Andrew Jones <ajones@ventanamicro.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Daniel Henrique Barboza <dbarboza@ventanamicro.com>,
qemu-devel@nongnu.org, pbonzini@redhat.com,
richard.henderson@linaro.org, berrange@redhat.com,
eduardo@habkost.net
Subject: Re: [PATCH v2 2/2] qom/object, accel-system: add support to Accel globals
Date: Wed, 31 Jul 2024 09:41:39 +0200 [thread overview]
Message-ID: <20240731-b34061e3e3d7ce4c3d76f481@orel> (raw)
In-Reply-To: <87bk2ekr8p.fsf@pond.sub.org>
On Wed, Jul 31, 2024 at 08:30:46AM GMT, Markus Armbruster wrote:
> I apologize for the delay.
>
> Daniel Henrique Barboza <dbarboza@ventanamicro.com> writes:
>
> > We're not honouring KVM options that are provided by any -accel option
> > aside from the first. In this example:
> >
> > qemu-system-riscv64 -accel kvm,riscv-aia=emul (...) \
> > -accel kvm,riscv-aia=hwaccel
> >
> > 'riscv-aia' will be set to 'emul', ignoring the last occurrence of the
> > option that set 'riscv-aia' to 'hwaccel'.
>
> The way you phrase this, it sounds like a bug. But as far as I know,
> -accel is meant to have fallback semantics: we use the first one that
> works.
The fact that some (most?) parameters have override semantics and some
have fallback semantics makes our complicated command line even more
complicated, especially since there's no way to know which is which.
IMHO, always having override semantics and then providing new parameters,
e.g. -accel-fallback (or a property, -accel fallback=on,...), would go a
long way to bringing some order to the universe.
>
> Perhaps:
>
> -accel has fallback semantics, i.e. we try accelerators in order until
> we find one that works. Any remainder is ignored.
>
> Because of that, you can't override properties like this:
>
> qemu-system-riscv64 -accel kvm,riscv-aia=emul (...) \
> -accel kvm,riscv-aia=hwaccel
>
> When KVM is available, 'riscv-aia' will be set to 'emul', and the
> second -accel is ignored. When KVM is not available, neither option
> works, and the command fails.
>
> Why would you want to override accelerator properties?
Testing. Many properties are only available to allow the user to force
non defaults. The example above isn't exactly what triggered this. The
real use is, '-accel kvm' is the default used by libvirt and when
riscv-aia=hwaccel is possible, it will default to hwaccel. In order to
test riscv-aia emulation support using libvirt (which doesn't yet allow
selecting anything riscv specific), I attempted to use the qemu
commandline element to override -accel with kvm,riscv-aia=emul.
Thanks,
drew
next prev parent reply other threads:[~2024-07-31 7:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 20:41 [PATCH v2 0/2] object,accel-system: allow Accel type globals Daniel Henrique Barboza
2024-07-03 20:41 ` [PATCH v2 1/2] qom/object, qdev: move globals functions to object.c Daniel Henrique Barboza
2024-07-26 16:42 ` Daniel P. Berrangé
2024-08-01 6:58 ` object_new() cannot fail, and that's fundamental (was: [PATCH v2 1/2] qom/object, qdev: move globals functions to object.c) Markus Armbruster
2024-08-01 11:56 ` Daniel P. Berrangé
2024-07-03 20:41 ` [PATCH v2 2/2] qom/object, accel-system: add support to Accel globals Daniel Henrique Barboza
2024-07-31 6:30 ` Markus Armbruster
2024-07-31 7:41 ` Andrew Jones [this message]
2024-07-31 8:42 ` Markus Armbruster
2024-08-07 9:46 ` Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240731-b34061e3e3d7ce4c3d76f481@orel \
--to=ajones@ventanamicro.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dbarboza@ventanamicro.com \
--cc=eduardo@habkost.net \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).