qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [PULL 10/10] qemu-vmsr-helper: implement --verbose/-v
Date: Wed, 31 Jul 2024 13:18:06 +0200	[thread overview]
Message-ID: <20240731111806.167225-11-pbonzini@redhat.com> (raw)
In-Reply-To: <20240731111806.167225-1-pbonzini@redhat.com>

Similar to qemu-pr-helper, do not print errors from the socket handling loop
unless a --verbose or -v option is provided explicitly on the command line.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 tools/i386/qemu-vmsr-helper.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/tools/i386/qemu-vmsr-helper.c b/tools/i386/qemu-vmsr-helper.c
index 585eaf88b37..a35dcb88a3f 100644
--- a/tools/i386/qemu-vmsr-helper.c
+++ b/tools/i386/qemu-vmsr-helper.c
@@ -54,6 +54,7 @@ static enum { RUNNING, TERMINATE, TERMINATING } state;
 static QIOChannelSocket *server_ioc;
 static int server_watch;
 static int num_active_sockets = 1;
+static bool verbose;
 
 #ifdef CONFIG_LIBCAP_NG
 static int uid = -1;
@@ -265,7 +266,11 @@ static void coroutine_fn vh_co_entry(void *opaque)
 
 out:
     if (local_err) {
-        error_report_err(local_err);
+        if (!verbose) {
+            error_free(local_err);
+        } else {
+            error_report_err(local_err);
+        }
     }
 
     object_unref(OBJECT(client->ioc));
@@ -431,6 +436,9 @@ int main(int argc, char **argv)
         case 'd':
             daemonize = true;
             break;
+        case 'v':
+            verbose = true;
+            break;
         case 'T':
             trace_opt_parse(optarg);
             break;
-- 
2.45.2



  parent reply	other threads:[~2024-07-31 11:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-31 11:17 [PULL 00/10] i386, tests/vm changes for QEMU 9.1-rc Paolo Bonzini
2024-07-31 11:17 ` [PULL 01/10] tests/vm/openbsd: Install tomli Paolo Bonzini
2024-07-31 11:17 ` [PULL 02/10] target/i386: Change unavail from u32 to u64 Paolo Bonzini
2024-07-31 11:17 ` [PULL 03/10] target/i386/cpu: Remove unnecessary SGX feature words checks Paolo Bonzini
2024-07-31 11:18 ` [PULL 04/10] target/i386/cpu: Explicitly express SGX_LC and SGX feature words dependency Paolo Bonzini
2024-07-31 11:18 ` [PULL 05/10] target/i386/cpu: Add dependencies of CPUID 0x12 leaves Paolo Bonzini
2024-07-31 11:18 ` [PULL 06/10] target/i386/cpu: Mask off SGX/SGX_LC feature words for non-PC machine Paolo Bonzini
2024-07-31 11:18 ` [PULL 07/10] target/i386: Fix typo that assign same value twice Paolo Bonzini
2024-07-31 11:18 ` [PULL 08/10] target/i386: Clean up error cases for vmsr_read_thread_stat() Paolo Bonzini
2024-07-31 11:18 ` [PULL 09/10] qemu-vmsr-helper: fix socket loop breakage Paolo Bonzini
2024-07-31 11:18 ` Paolo Bonzini [this message]
2024-08-01  0:00 ` [PULL 00/10] i386, tests/vm changes for QEMU 9.1-rc Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240731111806.167225-11-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).