From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Zhao Liu <zhao1.liu@intel.com>
Subject: [PULL 06/10] target/i386/cpu: Mask off SGX/SGX_LC feature words for non-PC machine
Date: Wed, 31 Jul 2024 13:18:02 +0200 [thread overview]
Message-ID: <20240731111806.167225-7-pbonzini@redhat.com> (raw)
In-Reply-To: <20240731111806.167225-1-pbonzini@redhat.com>
From: Zhao Liu <zhao1.liu@intel.com>
Only PC machine supports SGX, so mask off SGX related feature words for
non-PC machine (microvm).
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Link: https://lore.kernel.org/r/20240730045544.2516284-5-zhao1.liu@intel.com
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
include/hw/i386/sgx-epc.h | 1 +
hw/i386/sgx-stub.c | 5 +++++
hw/i386/sgx.c | 8 ++++++++
target/i386/cpu.c | 15 +++++++++++++++
4 files changed, 29 insertions(+)
diff --git a/include/hw/i386/sgx-epc.h b/include/hw/i386/sgx-epc.h
index 3e00efd870c..41d55da4799 100644
--- a/include/hw/i386/sgx-epc.h
+++ b/include/hw/i386/sgx-epc.h
@@ -58,6 +58,7 @@ typedef struct SGXEPCState {
int nr_sections;
} SGXEPCState;
+bool check_sgx_support(void);
bool sgx_epc_get_section(int section_nr, uint64_t *addr, uint64_t *size);
void sgx_epc_build_srat(GArray *table_data);
diff --git a/hw/i386/sgx-stub.c b/hw/i386/sgx-stub.c
index 16b1dfd90bb..38ff75e9f37 100644
--- a/hw/i386/sgx-stub.c
+++ b/hw/i386/sgx-stub.c
@@ -32,6 +32,11 @@ void pc_machine_init_sgx_epc(PCMachineState *pcms)
memset(&pcms->sgx_epc, 0, sizeof(SGXEPCState));
}
+bool check_sgx_support(void)
+{
+ return false;
+}
+
bool sgx_epc_get_section(int section_nr, uint64_t *addr, uint64_t *size)
{
return true;
diff --git a/hw/i386/sgx.c b/hw/i386/sgx.c
index 849472a1286..4900dd414a1 100644
--- a/hw/i386/sgx.c
+++ b/hw/i386/sgx.c
@@ -266,6 +266,14 @@ void hmp_info_sgx(Monitor *mon, const QDict *qdict)
size);
}
+bool check_sgx_support(void)
+{
+ if (!object_dynamic_cast(qdev_get_machine(), TYPE_PC_MACHINE)) {
+ return false;
+ }
+ return true;
+}
+
bool sgx_epc_get_section(int section_nr, uint64_t *addr, uint64_t *size)
{
PCMachineState *pcms =
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 28b46ef536f..85ef7452c04 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -6103,6 +6103,21 @@ uint64_t x86_cpu_get_supported_feature_word(X86CPU *cpu, FeatureWord w)
}
break;
+ case FEAT_7_0_EBX:
+#ifndef CONFIG_USER_ONLY
+ if (!check_sgx_support()) {
+ unavail = CPUID_7_0_EBX_SGX;
+ }
+#endif
+ break;
+ case FEAT_7_0_ECX:
+#ifndef CONFIG_USER_ONLY
+ if (!check_sgx_support()) {
+ unavail = CPUID_7_0_ECX_SGX_LC;
+ }
+#endif
+ break;
+
default:
break;
}
--
2.45.2
next prev parent reply other threads:[~2024-07-31 11:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 11:17 [PULL 00/10] i386, tests/vm changes for QEMU 9.1-rc Paolo Bonzini
2024-07-31 11:17 ` [PULL 01/10] tests/vm/openbsd: Install tomli Paolo Bonzini
2024-07-31 11:17 ` [PULL 02/10] target/i386: Change unavail from u32 to u64 Paolo Bonzini
2024-07-31 11:17 ` [PULL 03/10] target/i386/cpu: Remove unnecessary SGX feature words checks Paolo Bonzini
2024-07-31 11:18 ` [PULL 04/10] target/i386/cpu: Explicitly express SGX_LC and SGX feature words dependency Paolo Bonzini
2024-07-31 11:18 ` [PULL 05/10] target/i386/cpu: Add dependencies of CPUID 0x12 leaves Paolo Bonzini
2024-07-31 11:18 ` Paolo Bonzini [this message]
2024-07-31 11:18 ` [PULL 07/10] target/i386: Fix typo that assign same value twice Paolo Bonzini
2024-07-31 11:18 ` [PULL 08/10] target/i386: Clean up error cases for vmsr_read_thread_stat() Paolo Bonzini
2024-07-31 11:18 ` [PULL 09/10] qemu-vmsr-helper: fix socket loop breakage Paolo Bonzini
2024-07-31 11:18 ` [PULL 10/10] qemu-vmsr-helper: implement --verbose/-v Paolo Bonzini
2024-08-01 0:00 ` [PULL 00/10] i386, tests/vm changes for QEMU 9.1-rc Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240731111806.167225-7-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).