From: Akihiko Odaki <akihiko.odaki@daynix.com>
To: Alexander Graf <agraf@csgraf.de>,
Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org,
Richard Henderson <richard.henderson@linaro.org>,
Akihiko Odaki <akihiko.odaki@daynix.com>
Subject: [PATCH] hvf: arm: Fix hvf_sysreg_read_cp() call
Date: Fri, 02 Aug 2024 17:37:52 +0900 [thread overview]
Message-ID: <20240802-hvf-v1-1-e2c0292037e5@daynix.com> (raw)
Commit 05b8d7249109 ("hvf: arm: Do not advance PC when raising an
exception") changed val from uint64_t to a pointer to uint64_t in
hvf_sysreg_read(), but didn't change its hvf_sysreg_read_cp() call.
Fixes: 05b8d7249109 ("hvf: arm: Do not advance PC when raising an exception")
Reported-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
target/arm/hvf/hvf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c
index c1496ad5be9b..ace83671b594 100644
--- a/target/arm/hvf/hvf.c
+++ b/target/arm/hvf/hvf.c
@@ -1280,7 +1280,7 @@ static int hvf_sysreg_read(CPUState *cpu, uint32_t reg, uint64_t *val)
case SYSREG_ICC_SRE_EL1:
case SYSREG_ICC_CTLR_EL1:
/* Call the TCG sysreg handler. This is only safe for GICv3 regs. */
- if (hvf_sysreg_read_cp(cpu, reg, &val)) {
+ if (hvf_sysreg_read_cp(cpu, reg, val)) {
return 0;
}
break;
---
base-commit: 31669121a01a14732f57c49400bc239cf9fd505f
change-id: 20240802-hvf-40971c54eccf
Best regards,
--
Akihiko Odaki <akihiko.odaki@daynix.com>
next reply other threads:[~2024-08-02 8:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 8:37 Akihiko Odaki [this message]
2024-08-02 8:44 ` [PATCH] hvf: arm: Fix hvf_sysreg_read_cp() call Peter Maydell
2024-08-02 9:50 ` Richard Henderson
2024-08-02 15:53 ` Philippe Mathieu-Daudé
2024-08-02 23:30 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240802-hvf-v1-1-e2c0292037e5@daynix.com \
--to=akihiko.odaki@daynix.com \
--cc=agraf@csgraf.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).