From: Sahil Siddiq <icegambit91@gmail.com>
To: eperezma@redhat.com, sgarzare@redhat.com
Cc: mst@redhat.com, qemu-devel@nongnu.org, icegambit91@gmail.com,
Sahil Siddiq <sahilcdq@proton.me>
Subject: [RFC v3 0/3] Add packed virtqueue to shadow virtqueue
Date: Fri, 2 Aug 2024 16:51:35 +0530 [thread overview]
Message-ID: <20240802112138.46831-1-sahilcdq@proton.me> (raw)
Hi,
Here's a new patch series that incorporates all
the suggested changes from v2.
I have tried my best to deduplicate the implementation.
Please let me know if I have missed something.
I'll also test these changes out by following the
suggestions given in response to v1. I'll have more
confidence once I know these changes work.
Thanks,
Sahil
v1: https://lists.nongnu.org/archive/html/qemu-devel/2024-06/msg03417.html
v2: https://lists.nongnu.org/archive/html/qemu-devel/2024-07/msg06196.html
Changes v2 -> v3:
* vhost-shadow-virtqueue.c
- Move parts common to "vhost_svq_add_split" and
"vhost_svq_add_packed" to "vhost_svq_add".
(vhost_svq_add_packed):
- Refactor to minimize duplicate code between
this and "vhost_svq_add_split"
- Fix code style issues.
(vhost_svq_add_split):
- Merge with "vhost_svq_vring_write_descs()"
- Refactor to minimize duplicate code between
this and "vhost_svq_add_packed"
(vhost_svq_add):
- Refactor to minimize duplicate code between
split and packed version of "vhost_svq_add"
(vhost_svq_memory_packed): New function
(vhost_svq_start):
- Remove common variables out of if-else branch.
(vhost_svq_stop):
- Add support for packed vq.
(vhost_svq_get_vring_addr): Revert changes
(vhost_svq_get_vring_addr_packed): Likwise.
* vhost-shadow-virtqueue.h
- Revert changes made to "vhost_svq_get_vring_addr*"
functions.
* vhost-vdpa.c: Revert changes.
Sahil Siddiq (3):
vhost: Introduce packed vq and add buffer elements
vhost: Data structure changes to support packed vqs
vhost: Allocate memory for packed vring
hw/virtio/vhost-shadow-virtqueue.c | 230 ++++++++++++++++++++---------
hw/virtio/vhost-shadow-virtqueue.h | 70 ++++++---
2 files changed, 206 insertions(+), 94 deletions(-)
--
2.45.2
next reply other threads:[~2024-08-02 11:23 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 11:21 Sahil Siddiq [this message]
2024-08-02 11:21 ` [RFC v3 1/3] vhost: Introduce packed vq and add buffer elements Sahil Siddiq
2024-08-07 16:40 ` Eugenio Perez Martin
2024-08-02 11:21 ` [RFC v3 2/3] vhost: Data structure changes to support packed vqs Sahil Siddiq
2024-08-02 11:21 ` [RFC v3 3/3] vhost: Allocate memory for packed vring Sahil Siddiq
2024-08-07 16:22 ` Eugenio Perez Martin
2024-08-11 15:37 ` Sahil
2024-08-11 17:20 ` Sahil
2024-08-12 6:31 ` Eugenio Perez Martin
2024-08-12 19:32 ` Sahil
2024-08-13 6:53 ` Eugenio Perez Martin
2024-08-21 12:19 ` Sahil
2024-08-27 15:30 ` Eugenio Perez Martin
2024-08-30 10:20 ` Sahil
2024-08-30 10:48 ` Eugenio Perez Martin
2024-09-08 19:46 ` Sahil
2024-09-09 12:34 ` Eugenio Perez Martin
2024-09-11 19:36 ` Sahil
2024-09-12 9:54 ` Eugenio Perez Martin
2024-09-16 4:34 ` Sahil
2024-09-24 5:31 ` Sahil
2024-09-24 10:46 ` Eugenio Perez Martin
2024-09-30 5:34 ` Sahil
2024-10-28 5:37 ` Sahil Siddiq
2024-10-28 8:10 ` Eugenio Perez Martin
2024-10-31 5:10 ` Sahil Siddiq
2024-11-13 5:10 ` Sahil Siddiq
2024-11-13 11:30 ` Eugenio Perez Martin
2024-12-05 20:38 ` Sahil Siddiq
2024-08-07 16:41 ` [RFC v3 0/3] Add packed virtqueue to shadow virtqueue Eugenio Perez Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240802112138.46831-1-sahilcdq@proton.me \
--to=icegambit91@gmail.com \
--cc=eperezma@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sahilcdq@proton.me \
--cc=sgarzare@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).