qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Jason Wang" <jasowang@redhat.com>,
	"Yuri Benditovich" <yuri.benditovich@daynix.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Andrew Melnychenko" <andrew@daynix.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH 0/5] Report fatal errors from failure with pre-opened eBPF RSS FDs
Date: Tue,  6 Aug 2024 15:56:48 +0100	[thread overview]
Message-ID: <20240806145653.1632478-1-berrange@redhat.com> (raw)

The virtio-net code for eBPF RSS is still ignoring errors when
failing to load the eBPF RSS program passed in by the mgmt app
via pre-opened FDs.

This series re-factors the eBPF common code so that it actually
reports using "Error" objects. Then it makes virtio-net treat
a failure to load pre-opened FDs as a fatal problem. When doing
speculative opening of eBPF FDs, QEMU merely prints a warning,
and allows the software fallback to continue.

Trace event coverage is significantly expanded to make this all
much more debuggable too.

Daniel P. Berrangé (5):
  hw/net: fix typo s/epbf/ebpf/ in virtio-net
  ebpf: drop redundant parameter checks in static methods
  ebpf: add formal error reporting to all APIs
  hw/net: report errors from failing to use eBPF RSS FDs
  ebpf: improve trace event coverage to all key operations

 ebpf/ebpf_rss.c     | 118 ++++++++++++++++++++++++++++----------------
 ebpf/ebpf_rss.h     |  10 ++--
 ebpf/trace-events   |   6 ++-
 hw/net/virtio-net.c |  53 +++++++++++++-------
 4 files changed, 123 insertions(+), 64 deletions(-)

-- 
2.45.2



             reply	other threads:[~2024-08-06 14:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-06 14:56 Daniel P. Berrangé [this message]
2024-08-06 14:56 ` [PATCH 1/5] hw/net: fix typo s/epbf/ebpf/ in virtio-net Daniel P. Berrangé
2024-08-06 15:10   ` Philippe Mathieu-Daudé
2024-08-06 14:56 ` [PATCH 2/5] ebpf: drop redundant parameter checks in static methods Daniel P. Berrangé
2024-08-06 14:56 ` [PATCH 3/5] ebpf: add formal error reporting to all APIs Daniel P. Berrangé
2024-08-06 15:11   ` Philippe Mathieu-Daudé
2024-08-06 15:20     ` Daniel P. Berrangé
2024-08-07  7:37       ` Philippe Mathieu-Daudé
2024-08-07  7:39         ` Philippe Mathieu-Daudé
2024-08-07  9:13         ` Daniel P. Berrangé
2024-08-06 14:56 ` [PATCH 4/5] hw/net: report errors from failing to use eBPF RSS FDs Daniel P. Berrangé
2024-08-06 14:56 ` [PATCH 5/5] ebpf: improve trace event coverage to all key operations Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240806145653.1632478-1-berrange@redhat.com \
    --to=berrange@redhat.com \
    --cc=andrew@daynix.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yuri.benditovich@daynix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).