From: Juraj Marcin <jmarcin@redhat.com>
To: qemu-devel@nongnu.org
Cc: David Hildenbrand <david@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Subject: [PATCH 2/4] reset: Add RESET_TYPE_WAKEUP
Date: Tue, 6 Aug 2024 18:07:52 +0200 [thread overview]
Message-ID: <20240806160756.182524-3-jmarcin@redhat.com> (raw)
In-Reply-To: <20240806160756.182524-1-jmarcin@redhat.com>
Some devices need to distinguish cold start reset from waking up from a
suspended state. This patch adds new value to the enum, and updates the
i386 wakeup method to use this new reset type.
Signed-off-by: Juraj Marcin <jmarcin@redhat.com>
---
docs/devel/reset.rst | 7 +++++++
hw/i386/pc.c | 2 +-
include/hw/resettable.h | 2 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/docs/devel/reset.rst b/docs/devel/reset.rst
index 9746a4e8a0..30c9a0cc2b 100644
--- a/docs/devel/reset.rst
+++ b/docs/devel/reset.rst
@@ -44,6 +44,13 @@ The Resettable interface handles reset types with an enum ``ResetType``:
value on each cold reset, such as RNG seed information, and which they
must not reinitialize on a snapshot-load reset.
+``RESET_TYPE_WAKEUP``
+ This type is used when the machine is woken up from a suspended state (deep
+ sleep, suspend-to-ram). Devices that must not be reset to their initial state
+ after wake-up (for example virtio-mem) can use this state to differentiate
+ cold start from wake-up can use this state to differentiate cold start from
+ wake-up.
+
Devices which implement reset methods must treat any unknown ``ResetType``
as equivalent to ``RESET_TYPE_COLD``; this will reduce the amount of
existing code we need to change if we add more types in future.
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index ccb9731c91..49efd0a997 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1716,7 +1716,7 @@ static void pc_machine_reset(MachineState *machine, ResetType type)
static void pc_machine_wakeup(MachineState *machine)
{
cpu_synchronize_all_states();
- pc_machine_reset(machine, RESET_TYPE_COLD);
+ pc_machine_reset(machine, RESET_TYPE_WAKEUP);
cpu_synchronize_all_post_reset();
}
diff --git a/include/hw/resettable.h b/include/hw/resettable.h
index 7e249deb8b..edb1f1361b 100644
--- a/include/hw/resettable.h
+++ b/include/hw/resettable.h
@@ -29,6 +29,7 @@ typedef struct ResettableState ResettableState;
* Types of reset.
*
* + Cold: reset resulting from a power cycle of the object.
+ * + Wakeup: reset resulting from a wake-up from a suspended state.
*
* TODO: Support has to be added to handle more types. In particular,
* ResettableState structure needs to be expanded.
@@ -36,6 +37,7 @@ typedef struct ResettableState ResettableState;
typedef enum ResetType {
RESET_TYPE_COLD,
RESET_TYPE_SNAPSHOT_LOAD,
+ RESET_TYPE_WAKEUP,
} ResetType;
/*
--
2.45.2
next prev parent reply other threads:[~2024-08-06 16:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 16:07 [PATCH 0/4] virtio-mem: Implement support for suspend+wake-up with plugged memory Juraj Marcin
2024-08-06 16:07 ` [PATCH 1/4] reset: Use ResetType for qemu_devices_reset() and MachineClass->reset() Juraj Marcin
2024-08-06 16:39 ` David Hildenbrand
2024-08-07 10:03 ` Juraj Marcin
2024-08-08 12:32 ` Peter Maydell
2024-08-06 16:07 ` Juraj Marcin [this message]
2024-08-06 16:41 ` [PATCH 2/4] reset: Add RESET_TYPE_WAKEUP David Hildenbrand
2024-08-08 12:18 ` Peter Maydell
2024-08-08 15:28 ` Juraj Marcin
2024-08-08 15:31 ` David Hildenbrand
2024-08-08 15:56 ` Peter Maydell
2024-08-08 16:04 ` David Hildenbrand
2024-08-08 16:17 ` Peter Maydell
2024-08-08 16:29 ` David Hildenbrand
2024-08-08 17:30 ` Peter Maydell
2024-08-08 18:07 ` David Hildenbrand
2024-08-06 16:07 ` [PATCH 3/4] virtio-mem: Implement Resettable interface instead of using LegacyReset Juraj Marcin
2024-08-06 16:42 ` David Hildenbrand
2024-08-08 12:25 ` Peter Maydell
2024-08-08 12:37 ` David Hildenbrand
2024-08-08 15:47 ` Peter Maydell
2024-08-09 13:06 ` Juraj Marcin
2024-08-06 16:07 ` [PATCH 4/4] virtio-mem: Add support for suspend+wake-up with plugged memory Juraj Marcin
2024-08-06 16:43 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240806160756.182524-3-jmarcin@redhat.com \
--to=jmarcin@redhat.com \
--cc=david@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).