qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Zach van Rijn" <me@zv.io>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Laurent Vivier" <laurent@vivier.eu>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH v3 3/5] linux-user: Factor print_buf_len() out
Date: Wed,  7 Aug 2024 14:43:04 +0200	[thread overview]
Message-ID: <20240807124306.52903-4-philmd@linaro.org> (raw)
In-Reply-To: <20240807124306.52903-1-philmd@linaro.org>

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 linux-user/strace.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/linux-user/strace.c b/linux-user/strace.c
index 80f64ff40c..210ff86afc 100644
--- a/linux-user/strace.c
+++ b/linux-user/strace.c
@@ -1655,6 +1655,13 @@ print_buf(abi_long addr, abi_long len, int last)
     }
 }
 
+static void
+print_buf_len(abi_long addr, abi_long len, int last)
+{
+    print_buf(addr, len, 0);
+    print_raw_param(TARGET_ABI_FMT_ld, len, last);
+}
+
 /*
  * Prints out raw parameter using given format.  Caller needs
  * to do byte swapping if needed.
@@ -2742,8 +2749,7 @@ static void do_print_sendrecv(const char *name, abi_long arg1)
 
     qemu_log("%s(", name);
     print_sockfd(sockfd, 0);
-    print_buf(msg, len, 0);
-    print_raw_param(TARGET_ABI_FMT_ld, len, 0);
+    print_buf_len(msg, len, 0);
     print_flags(msg_flags, flags, 1);
     qemu_log(")");
 }
@@ -2761,8 +2767,7 @@ static void do_print_msgaddr(const char *name, abi_long arg1)
 
     qemu_log("%s(", name);
     print_sockfd(sockfd, 0);
-    print_buf(msg, len, 0);
-    print_raw_param(TARGET_ABI_FMT_ld, len, 0);
+    print_buf_len(msg, len, 0);
     print_flags(msg_flags, flags, 0);
     print_sockaddr(addr, addrlen, 0);
     qemu_log(")");
-- 
2.45.2



  parent reply	other threads:[~2024-08-07 12:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-07 12:43 [PATCH v3 0/5] linux-user: Trace sendto/recvfrom Philippe Mathieu-Daudé
2024-08-07 12:43 ` [PATCH v3 1/5] linux-user: Correct print_sockaddr() format Philippe Mathieu-Daudé
2024-10-02  7:54   ` Ilya Leoshkevich
2024-10-05 18:05     ` Richard Henderson
2024-08-07 12:43 ` [PATCH v3 2/5] linux-user: Display sockaddr buffer as pointer Philippe Mathieu-Daudé
2024-10-02  7:43   ` Ilya Leoshkevich
2024-08-07 12:43 ` Philippe Mathieu-Daudé [this message]
2024-10-02  7:41   ` [PATCH v3 3/5] linux-user: Factor print_buf_len() out Ilya Leoshkevich
2024-08-07 12:43 ` [PATCH v3 4/5] linux-user: Add strace for sendto() Philippe Mathieu-Daudé
2024-10-02  7:40   ` Ilya Leoshkevich
2024-08-07 12:43 ` [PATCH v3 5/5] linux-user: Add strace for recvfrom() Philippe Mathieu-Daudé
2024-10-02  6:55   ` Ilya Leoshkevich
2024-10-05 18:31     ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240807124306.52903-4-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=laurent@vivier.eu \
    --cc=me@zv.io \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).