qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Akihiko Odaki <akihiko.odaki@daynix.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Cédric Le Goater" <clg@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Eduardo Habkost" <eduardo@habkost.net>,
	"Jason Wang" <jasowang@redhat.com>,
	"Sriram Yagnaraman" <sriram.yagnaraman@ericsson.com>,
	"Keith Busch" <kbusch@kernel.org>,
	"Klaus Jensen" <its@irrelevant.dk>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
	 Yui Washizu <yui.washidu@gmail.com>,
	 Akihiko Odaki <akihiko.odaki@daynix.com>
Subject: [PATCH for-9.2 v7 1/9] hw/pci: Do not add ROM BAR for SR-IOV VF
Date: Tue, 13 Aug 2024 15:37:00 +0900	[thread overview]
Message-ID: <20240813-sriov-v7-1-8515e3774df7@daynix.com> (raw)
In-Reply-To: <20240813-sriov-v7-0-8515e3774df7@daynix.com>

A SR-IOV VF cannot have a ROM BAR.

Co-developed-by: Yui Washizu <yui.washidu@gmail.com>
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
 hw/pci/pci.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index d2eaf0c51dde..60b1747d60e6 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -2359,6 +2359,14 @@ static void pci_add_option_rom(PCIDevice *pdev, bool is_default_rom,
         return;
     }
 
+    if (pci_is_vf(pdev)) {
+        if (pdev->rom_bar > 0) {
+            error_setg(errp, "ROM BAR cannot be enabled for SR-IOV VF");
+        }
+
+        return;
+    }
+
     if (load_file || pdev->romsize == UINT32_MAX) {
         path = qemu_find_file(QEMU_FILE_TYPE_BIOS, pdev->romfile);
         if (path == NULL) {

-- 
2.46.0



  reply	other threads:[~2024-08-13  6:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-13  6:36 [PATCH for-9.2 v7 0/9] virtio-net: add support for SR-IOV emulation Akihiko Odaki
2024-08-13  6:37 ` Akihiko Odaki [this message]
2024-08-13  6:37 ` [PATCH for-9.2 v7 2/9] hw/pci: Fix SR-IOV VF number calculation Akihiko Odaki
2024-08-13  6:37 ` [PATCH for-9.2 v7 3/9] pcie_sriov: Ensure PF and VF are mutually exclusive Akihiko Odaki
2024-08-13  6:37 ` [PATCH for-9.2 v7 4/9] pcie_sriov: Check PCI Express for SR-IOV PF Akihiko Odaki
2024-08-13  6:37 ` [PATCH for-9.2 v7 5/9] pcie_sriov: Allow user to create SR-IOV device Akihiko Odaki
2024-08-13  6:37 ` [PATCH for-9.2 v7 6/9] virtio-pci: Implement SR-IOV PF Akihiko Odaki
2024-08-13  6:37 ` [PATCH for-9.2 v7 7/9] virtio-net: Implement SR-IOV VF Akihiko Odaki
2024-08-13  6:37 ` [PATCH for-9.2 v7 8/9] docs: Document composable SR-IOV device Akihiko Odaki
2024-08-13  6:37 ` [PATCH for-9.2 v7 9/9] pcie_sriov: Make a PCI device with user-created VF ARI-capable Akihiko Odaki
2024-08-21 10:18 ` [PATCH for-9.2 v7 0/9] virtio-net: add support for SR-IOV emulation Yui Washizu
2024-08-23  5:06   ` Akihiko Odaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240813-sriov-v7-1-8515e3774df7@daynix.com \
    --to=akihiko.odaki@daynix.com \
    --cc=alex.williamson@redhat.com \
    --cc=berrange@redhat.com \
    --cc=clg@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=its@irrelevant.dk \
    --cc=jasowang@redhat.com \
    --cc=kbusch@kernel.org \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sriram.yagnaraman@ericsson.com \
    --cc=yui.washidu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).