From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: gaosong@loongson.cn, qemu-stable@nongnu.org
Subject: [PATCH for-9.1] linux-user: Handle short reads in mmap_h_gt_g
Date: Fri, 16 Aug 2024 07:32:31 +1000 [thread overview]
Message-ID: <20240815213231.303424-1-richard.henderson@linaro.org> (raw)
In particular, if an image has a large bss, we can hit
EOF before reading all host_len bytes of the mapping.
Cc: qemu-stable@nongnu.org
Fixes: eb5027ac618 ("linux-user: Split out mmap_h_gt_g")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2504
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/mmap.c | 19 +++++++++++++++----
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/linux-user/mmap.c b/linux-user/mmap.c
index 6418e811f6..de9ab13754 100644
--- a/linux-user/mmap.c
+++ b/linux-user/mmap.c
@@ -853,10 +853,21 @@ static abi_long mmap_h_gt_g(abi_ulong start, abi_ulong len,
}
if (misaligned_offset) {
- /* TODO: The read could be short. */
- if (pread(fd, p, host_len, offset + real_start - start) != host_len) {
- do_munmap(p, host_len);
- return -1;
+ size_t o = 0;
+ while (1) {
+ ssize_t r = pread(fd, p + o, host_len - o,
+ o + offset + real_start - start);
+ if (likely(r == host_len - o) || r == 0) {
+ /* Complete or EOF */
+ break;
+ }
+ if (unlikely(r == -1)) {
+ /* Error */
+ do_munmap(p, host_len);
+ return -1;
+ }
+ /* Short read -- iterate */
+ o += r;
}
if (!(host_prot & PROT_WRITE)) {
mprotect(p, host_len, host_prot);
--
2.43.0
next reply other threads:[~2024-08-15 21:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 21:32 Richard Henderson [this message]
2024-08-16 1:32 ` [PATCH for-9.1] linux-user: Handle short reads in mmap_h_gt_g gaosong
2024-08-16 5:57 ` Philippe Mathieu-Daudé
2024-08-16 8:10 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240815213231.303424-1-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=gaosong@loongson.cn \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).