From: Igor Mammedov <imammedo@redhat.com>
To: Ricardo Ribalda <ribalda@chromium.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Ani Sinha <anisinha@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Eduardo Habkost <eduardo@habkost.net>,
qemu-devel@nongnu.org, righi.andrea@gmail.com
Subject: Re: [PATCH v5 0/3] hw/i386/acpi: Pre-compute the _PRT table
Date: Wed, 21 Aug 2024 16:45:53 +0200 [thread overview]
Message-ID: <20240821164553.63007e25@imammedo.users.ipa.redhat.com> (raw)
In-Reply-To: <20240814115736.1580337-1-ribalda@chromium.org>
On Wed, 14 Aug 2024 11:56:08 +0000
Ricardo Ribalda <ribalda@chromium.org> wrote:
> Today for x86 the _PRT() table is computed in runtime.
> Under some configurations, computing the _PRT table can take more than
> 30 seconds and the ACPI timeout is violated.
>
> This patchset modifies _PRT() to return a pre-computed table.
To be sure we are not breaking anything boot tested it with
rhel6.7/9.0, winxp, ws2022
> Changelog v3->v4 Thanks Richard:
> - Make link_name struct static
>
> Changelog v3->v4 Thanks Igor:
> - Add missing files to tests/qtest/bios-tables-test-allowed-diff.h
>
> Changelog v2->v3 Thanks Michael:
> - Code style
> - Add cover letter
>
> Ricardo Ribalda (3):
> tests/acpi: pc: allow DSDT acpi table changes
> hw/i386/acpi-build: Return a pre-computed _PRT table
> tests/acpi: pc: update golden masters for DSDT
>
> hw/i386/acpi-build.c | 120 +++++----------------------
> tests/data/acpi/x86/pc/DSDT | Bin 6830 -> 8527 bytes
> tests/data/acpi/x86/pc/DSDT.acpierst | Bin 6741 -> 8438 bytes
> tests/data/acpi/x86/pc/DSDT.acpihmat | Bin 8155 -> 9852 bytes
> tests/data/acpi/x86/pc/DSDT.bridge | Bin 13701 -> 15398 bytes
> tests/data/acpi/x86/pc/DSDT.cphp | Bin 7294 -> 8991 bytes
> tests/data/acpi/x86/pc/DSDT.dimmpxm | Bin 8484 -> 10181 bytes
> tests/data/acpi/x86/pc/DSDT.hpbridge | Bin 6781 -> 8478 bytes
> tests/data/acpi/x86/pc/DSDT.hpbrroot | Bin 3337 -> 5034 bytes
> tests/data/acpi/x86/pc/DSDT.ipmikcs | Bin 6902 -> 8599 bytes
> tests/data/acpi/x86/pc/DSDT.memhp | Bin 8189 -> 9886 bytes
> tests/data/acpi/x86/pc/DSDT.nohpet | Bin 6688 -> 8385 bytes
> tests/data/acpi/x86/pc/DSDT.numamem | Bin 6836 -> 8533 bytes
> tests/data/acpi/x86/pc/DSDT.roothp | Bin 10623 -> 12320 bytes
> tests/data/acpi/x86/q35/DSDT.cxl | Bin 9714 -> 13148 bytes
> tests/data/acpi/x86/q35/DSDT.viot | Bin 9464 -> 14615 bytes
> 16 files changed, 22 insertions(+), 98 deletions(-)
>
next prev parent reply other threads:[~2024-08-21 14:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 11:56 [PATCH v5 0/3] hw/i386/acpi: Pre-compute the _PRT table Ricardo Ribalda
2024-08-14 11:56 ` [PATCH v5 1/3] tests/acpi: pc: allow DSDT acpi table changes Ricardo Ribalda
2024-08-21 14:21 ` Igor Mammedov
2024-08-14 11:56 ` [PATCH v5 2/3] hw/i386/acpi-build: Return a pre-computed _PRT table Ricardo Ribalda
2024-08-14 11:56 ` [PATCH v5 3/3] tests/acpi: pc: update golden masters for DSDT Ricardo Ribalda
2024-08-21 14:44 ` Igor Mammedov
2024-08-21 14:45 ` Igor Mammedov [this message]
2024-09-22 11:57 ` [PATCH v5 0/3] hw/i386/acpi: Pre-compute the _PRT table Mark Cave-Ayland
2024-09-22 13:11 ` Ricardo Ribalda
2024-09-22 13:22 ` Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240821164553.63007e25@imammedo.users.ipa.redhat.com \
--to=imammedo@redhat.com \
--cc=anisinha@redhat.com \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ribalda@chromium.org \
--cc=richard.henderson@linaro.org \
--cc=righi.andrea@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).