From: "Corvin Köhne" <c.koehne@beckhoff.com>
To: <qemu-devel@nongnu.org>
Cc: "Alex Williamson" <alex.williamson@redhat.com>,
"Cédric Le Goater" <clg@redhat.com>
Subject: [PATCH 7/7] vfio/igd: correctly calculate stolen memory size for gen 9 and later
Date: Thu, 22 Aug 2024 15:54:16 +0200 [thread overview]
Message-ID: <20240822135420.58849-7-c.koehne@beckhoff.com> (raw)
In-Reply-To: <20240822111819.34306-1-c.koehne@beckhoff.com>
We have to update the calculation of the stolen memory size because
we've seen devices using values of 0xf0 and above for the graphics mode
select field. The new calculation was taken from the linux kernel [1].
[1] https://github.com/torvalds/linux/blob/7c626ce4bae1ac14f60076d00eafe71af30450ba/arch/x86/kernel/early-quirks.c#L455-L460
Signed-off-by: Corvin Köhne <c.koehne@beckhoff.com>
---
hw/vfio/igd.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/hw/vfio/igd.c b/hw/vfio/igd.c
index 122432e6a6..70c60fe7bc 100644
--- a/hw/vfio/igd.c
+++ b/hw/vfio/igd.c
@@ -487,11 +487,18 @@ static int igd_get_stolen_mb(int gen, uint32_t gmch)
gms = (gmch >> 8) & 0xff;
}
- if (gms > 0x10) {
- error_report("Unsupported IGD GMS value 0x%x", gms);
- return 0;
+ if (gen < 9) {
+ if (gms > 0x10) {
+ error_report("Unsupported IGD GMS value 0x%x", gms);
+ return 0;
+ }
+ return gms * 32;
+ } else {
+ if (gms < 0xf0)
+ return gms * 32;
+ else
+ return gms * 4 + 4;
}
- return gms * 32;
}
void vfio_probe_igd_bar4_quirk(VFIOPCIDevice *vdev, int nr)
--
2.46.0
This email contains confidential information. If you have received it in error, you must not read, use, copy or pass on this e-mail or its attachments. If you have received the e-mail in error, please inform me immediately by reply e-mail and then delete this e-mail from your system. Thank you
Diese E-Mail enthält vertrauliche Informationen. Sollten Sie sie irrtümlich erhalten haben, dürfen Sie diese E-Mail oder ihre Anhänge nicht lesen, verwenden, kopieren oder weitergeben. Sollten Sie die Mail versehentlich erhalten haben, teilen Sie mir dies bitte umgehend per Antwort-E-Mail mit und löschen Sie diese E-Mail dann aus Ihrem System. Vielen Dank
Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Beckhoff
Registered office: Verl, Germany | Register court: Guetersloh HRA 7075
prev parent reply other threads:[~2024-08-22 13:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 11:08 [PATCH 0/7] vfio/igd: add passthrough support for IGDs of gen 11 and later Corvin Köhne
2024-08-22 11:08 ` [PATCH 1/7] vfio/igd: return an invalid generation for unknown devices Corvin Köhne
2024-08-22 11:08 ` [PATCH 2/7] vfio/igd: support legacy mode for all known generations Corvin Köhne
2024-08-22 11:08 ` [PATCH 3/7] vfio/igd: use new BDSM register location and size for gen 11 and later Corvin Köhne
2024-08-22 11:08 ` [PATCH 4/7] vfio/igd: add new bar0 quirk to emulate BDSM mirror Corvin Köhne
2024-08-26 16:35 ` Alex Williamson
2024-08-28 10:40 ` Corvin Köhne
2024-08-28 12:50 ` Corvin Köhne
2024-08-28 13:08 ` Cédric Le Goater
2024-08-22 13:54 ` [PATCH 5/7] vfio/igd: add ID's for ElkhartLake and TigerLake Corvin Köhne
2024-08-22 13:54 ` [PATCH 6/7] vfio/igd: don't set stolen memory size to zero Corvin Köhne
2024-08-22 13:54 ` Corvin Köhne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240822135420.58849-7-c.koehne@beckhoff.com \
--to=c.koehne@beckhoff.com \
--cc=alex.williamson@redhat.com \
--cc=clg@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).