From: Pavel Pisa <pisa@fel.cvut.cz>
To: Doug Brown <doug@schmorgal.com>
Cc: Francisco Iglesias <francisco.iglesias@amd.com>,
Jason Wang <jasowang@redhat.com>,
qemu-devel@nongnu.org, Paolo Bonzini <bonzini@gnu.org>
Subject: Re: [PATCH 2/5] hw/net/can/xlnx-versal-canfd: Fix CAN FD flag check
Date: Sun, 25 Aug 2024 18:50:34 +0200 [thread overview]
Message-ID: <202408251850.34384.pisa@fel.cvut.cz> (raw)
In-Reply-To: <5aef262f-b1a7-4317-802e-8681451ac54f@schmorgal.com>
Hello Doug
On Saturday 24 of August 2024 03:54:00 Doug Brown wrote:
> Thank you for reviewing all of my patches, Francisco.
>
> Now, all of these patches are reviewed but there are a few other issues
> we talked about here (dlc2len/len2dlc and issues with the flags), and I
> also found a FIFO issue. Would it make the most sense for me to submit a
> V2 of this series with a few extra patches tacked on the end, or should
> I wait for this series to be applied first? I can do it either way, I
> just wasn't sure what would be preferred.
I agree with both ways,
1) merging actual versing and then providing followup
patches
2) updating and extending the series
I have little inclination to the second choice (2), because
you have already patch where you touch dlc2len/len2dlc issue
and making it without middle step would be more straightforward
and readable to me.
Anyway, I am the initiator of QEMU CAN subsystem as GSoC and studnets
mentor and coauthor but I have no commit right to the QEMU mainline.
So actual merge has to be realized by people with commit right.
Paolo Bonzini has provided help with CAN subsystem integration
and the committing.
Best wishes,
Pavel
--
Pavel Pisa
phone: +420 603531357
e-mail: pisa@cmp.felk.cvut.cz
Department of Control Engineering FEE CVUT
Karlovo namesti 13, 121 35, Prague 2
university: http://control.fel.cvut.cz/
personal: http://cmp.felk.cvut.cz/~pisa
social: https://social.kernel.org/ppisa
projects: https://www.openhub.net/accounts/ppisa
CAN related:http://canbus.pages.fel.cvut.cz/
RISC-V education: https://comparch.edu.cvut.cz/
Open Technologies Research Education and Exchange Services
https://gitlab.fel.cvut.cz/otrees/org/-/wikis/home
next prev parent reply other threads:[~2024-08-25 16:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-16 16:35 [PATCH 0/5] hw/net/can/xlnx-versal-canfd: Miscellaneous fixes Doug Brown
2024-08-16 16:35 ` [PATCH 1/5] hw/net/can/xlnx-versal-canfd: Fix interrupt level Doug Brown
2024-08-21 7:30 ` Francisco Iglesias
2024-08-16 16:35 ` [PATCH 2/5] hw/net/can/xlnx-versal-canfd: Fix CAN FD flag check Doug Brown
2024-08-21 6:57 ` Pavel Pisa
2024-08-22 0:01 ` Doug Brown
2024-08-22 1:11 ` Pavel Pisa
2024-08-24 1:54 ` Doug Brown
2024-08-25 16:50 ` Pavel Pisa [this message]
2024-08-25 17:30 ` Peter Maydell
2024-08-25 21:21 ` Doug Brown
2024-08-21 7:33 ` Francisco Iglesias
2024-08-16 16:35 ` [PATCH 3/5] hw/net/can/xlnx-versal-canfd: Translate CAN ID registers Doug Brown
2024-08-23 17:08 ` Francisco Iglesias
2024-08-16 16:35 ` [PATCH 4/5] hw/net/can/xlnx-versal-canfd: Fix byte ordering Doug Brown
2024-08-23 17:52 ` Francisco Iglesias
2024-08-16 16:35 ` [PATCH 5/5] hw/net/can/xlnx-versal-canfd: Handle RX of short FD frames Doug Brown
2024-08-23 18:11 ` Francisco Iglesias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202408251850.34384.pisa@fel.cvut.cz \
--to=pisa@fel.cvut.cz \
--cc=bonzini@gnu.org \
--cc=doug@schmorgal.com \
--cc=francisco.iglesias@amd.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).